External/oott
1
0
Fork 0
mirror of https://github.com/rzuasti/oott.git synced 2026-07-08 19:21:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

Make notification mark-as-read reliably update the list

Browse Source 
Three intertwined fixes so that marking a notification as read from the
trailing menu, swipe-dismiss, and 'Mark all as read' all consistently
update the UI and surface backend failures.

- Guard the mark-read, mark-new, and mark-all calls with try/catch; on
  failure show a snackbar with the mapped error and leave the list
  untouched.
- Use the State's own `mounted` and `context` after the await instead of
  the per-card BuildContext, so the SliverList rebuild reliably runs
  even when the originating NotificationCard's element has been swapped
  out by the reconciliation. _setRead and _markAllAsRead no longer take
  a BuildContext.
- Replace `Dismissible(key: UniqueKey())` with `ValueKey(item.id)` in
  the notification card. UniqueKey was regenerated on every build,
  forcing the Dismissible/PopupMenuButton subtree to be disposed on any
  parent rebuild; the open menu's `mounted` check would then drop
  `onSelected` silently.
- Add `ValueKey(device.macAddress)` to the device list rows for the
  same reason, anchoring each row's Element (and its PopupMenuButton
  State) to its device identity instead of its list position.

Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This commit is contained in:
rzuasti
2026-05-31 10:28:23 -04:00
co-authored by Claude Opus 4.7
parent bb677aeebf
commit 61f2579152
3 changed files with 40 additions and 30 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/lib/home/notifications_list.dart
+30 -21
View File
@@ -112,32 +112,41 @@ class _NotificationsListState extends State<NotificationsList> with RouteAware {
}
}
Future<void> _markAllAsRead(BuildContext context) async {
await BackendAPI.instance.markAllNotificationsAsRead();
_fetchPage(_currentPage);
if (context.mounted) {
UISnackbars.showSuccess(context, 'All notifications marked as read');
Future<void> _markAllAsRead() async {
try {
await BackendAPI.instance.markAllNotificationsAsRead();
} catch (e) {
if (!mounted) return;
UISnackbars.showError(context, dioErrorToUserMessage(e));
return;
}
if (!mounted) return;
_fetchPage(_currentPage);
UISnackbars.showSuccess(context, 'All notifications marked as read');
}
Future<bool> _setRead(
BuildContext context,
oott_model.Notification item,
bool read,
) async {
Future<bool> _setRead(oott_model.Notification item, bool read) async {
if (item.isNew == !read) {
UISnackbars.showWarning(
context,
'Notification was already marked as ${read ? 'read' : 'unread'}',
);
if (mounted) {
UISnackbars.showWarning(
context,
'Notification was already marked as ${read ? 'read' : 'unread'}',
);
}
return false;
}
if (read) {
await BackendAPI.instance.markNotificationAsRead(item.id);
} else {
await BackendAPI.instance.markNotificationAsNew(item.id);
try {
if (read) {
await BackendAPI.instance.markNotificationAsRead(item.id);
} else {
await BackendAPI.instance.markNotificationAsNew(item.id);
}
} catch (e) {
if (!mounted) return false;
UISnackbars.showError(context, dioErrorToUserMessage(e));
return false;
}
if (!context.mounted) return false;
if (!mounted) return false;
UISnackbars.showSuccess(
context,
'Event marked as ${read ? 'read' : 'unread'}',
@@ -185,7 +194,7 @@ class _NotificationsListState extends State<NotificationsList> with RouteAware {
const Spacer(),
if (_filter == _NotificationFilter.newOnly && _items.isNotEmpty)
IconButton(
onPressed: () => _markAllAsRead(context),
onPressed: _markAllAsRead,
icon: const Icon(Icons.done_all),
tooltip: 'Mark all as read',
),
@@ -266,7 +275,7 @@ class _NotificationsListState extends State<NotificationsList> with RouteAware {
return NotificationCard(
item: item,
formatter: formatter,
onSetRead: (ctx, read) => _setRead(ctx, item, read),
onSetRead: (read) => _setRead(item, read),
);
},
);