From 3ebb35933e15c2c4594e7eb1503246fe6c665c25 Mon Sep 17 00:00:00 2001 From: rzuasti Date: Sat, 6 Jun 2026 16:22:38 -0400 Subject: [PATCH] Drop the status block from new-device notifications New devices are never registered, so the status line only ever read "Not registered" and added no information. Remove it from the single new-device notification body (the consolidated summary never had one). Co-Authored-By: Claude Opus 4.8 --- TODO.md | 2 +- backend/src/events.rs | 7 +++---- 2 files changed, 4 insertions(+), 5 deletions(-) diff --git a/TODO.md b/TODO.md index 1fbb075..03b94fe 100644 --- a/TODO.md +++ b/TODO.md @@ -20,7 +20,7 @@ ## Backend -- [ ] In notifications, when its a new device(s) found notification, remove the status block (new devices are never registered) +- [x] In notifications, when its a new device(s) found notification, remove the status block (new devices are never registered) - [x] In notifications, when the vendor is empty put (unknown) - [ ] Implement the pushover API call directly to support HTML content and review notification text to use it diff --git a/backend/src/events.rs b/backend/src/events.rs index 9fc2a59..af4dce0 100644 --- a/backend/src/events.rs +++ b/backend/src/events.rs @@ -196,9 +196,6 @@ fn render_new_device(device: &Device) -> (String, String) { writeln!(body, " Vendor: {}", vendor_or_placeholder(device)).unwrap(); writeln!(body, " Type: {}", device_type_or_placeholder(device)).unwrap(); writeln!(body).unwrap(); - writeln!(body, "Status").unwrap(); - writeln!(body, " {}", registration_line(device)).unwrap(); - writeln!(body).unwrap(); write!( body, "If you do not recognise this device, consider investigating before \ @@ -688,7 +685,9 @@ mod tests { assert!(body.contains("Name: printer.local")); assert!(body.contains("Vendor: Apple, Inc.")); assert!(body.contains("Type: Smartphone")); - assert!(body.contains("Not registered")); + // New devices are never registered, so the status block is omitted entirely. + assert!(!body.contains("Status")); + assert!(!body.contains("registered")); assert!(body.contains("If you do not recognise this device")); // Private data must never appear in the body. assert!(!body.contains("aa:bb:cc:dd:ee:ff"));