External/oott
1
0
Fork 0
mirror of https://github.com/rzuasti/oott.git synced 2026-07-08 19:21:54 +02:00
Code Issues Packages Projects Releases Wiki Activity

Add sort-by-device-type to the devices list

Browse Source 
Wide layout makes the leading device-type icon column header tappable to
sort; narrow layout gains a "Device Type" option in the sort sheet. The
backend already whitelisted device_type as a sort column.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This commit is contained in:
rzuasti
2026-06-05 19:37:38 -04:00
co-authored by Claude Opus 4.8
parent 863e37d06e
commit 3cb104e364
4 changed files with 119 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
frontend/test/widget/device_list_test.dart
+62
View File
@@ -101,6 +101,68 @@ void main() {
await tearDownTree(tester);
});
testWidgets('tapping the device-type header sorts by device type', (
tester,
) async {
// Default ordering (last_seen, desc) returns two devices.
adapter.onGet(
'/devices',
(server) => server.reply(200, [
deviceJson(macAddress: '00:00:00:00:00:01'),
deviceJson(macAddress: '00:00:00:00:00:02'),
]),
queryParameters: {
'is_registered': false,
'sort_by': 'last_seen',
'sort_order': 'desc',
'page_offset': 0,
'page_limit': 11,
},
);
// Sorting by device type (asc) returns a single, distinguishable device.
adapter.onGet(
'/devices',
(server) =>
server.reply(200, [deviceJson(macAddress: '00:00:00:00:00:03')]),
queryParameters: {
'is_registered': false,
'sort_by': 'device_type',
'sort_order': 'asc',
'page_offset': 0,
'page_limit': 11,
},
);
await pumpScreen(tester, const DeviceList());
await pumpUntilFound(tester, find.byType(DeviceRowWide));
expect(find.byType(DeviceRowWide), findsNWidgets(2));
await tester.tap(find.byTooltip('Sort by device type'));
for (var i = 0;
i < 40 && find.byType(DeviceRowWide).evaluate().length != 1;
i++) {
await tester.pump(const Duration(milliseconds: 10));
}
expect(find.byType(DeviceRowWide), findsOneWidget);
await tearDownTree(tester);
});
testWidgets('the sort sheet offers ordering by device type', (tester) async {
adapter.onGet('/devices', (server) => server.reply(200, [deviceJson()]));
// A phone-width viewport so the compact layout with the sort button shows.
await pumpScreen(tester, const DeviceList(), size: const Size(500, 900));
await pumpUntilFound(tester, find.byType(DeviceRowCompact));
await tester.tap(find.byTooltip('Sort'));
await tester.pumpAndSettle();
expect(find.text('Device Type'), findsOneWidget);
await tearDownTree(tester);
});
testWidgets('pulling the list down refetches devices', (tester) async {
// A single reply list whose contents are swapped before the pull, so the
// same route re-serializes fresh data on the refresh request.