Extract DeviceType as an enum with icon and label getters

Mirrors the NotificationType pattern. Removes duplicated _deviceTypes
list and _deviceIcon() helper from both device screens, centralising
all type-to-icon logic in the model.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This commit is contained in:
rzuasti
2026-05-27 19:06:09 -04:00
co-authored by Claude Sonnet 4.6
parent 2da339a2b0
commit 1b470fc28f
4 changed files with 66 additions and 98 deletions
+12 -44
View File
@@ -2,22 +2,12 @@ import 'package:flutter/material.dart';
import 'package:go_router/go_router.dart';
import '../model/device.dart';
import '../model/device_type.dart';
import '../utils/friendly_date_formatter.dart';
import '../utils/oott_api.dart';
import '../utils/ui_snackbars.dart';
import '../widgets/status_badge.dart';
const _deviceTypes = [
'phone',
'laptop',
'tablet',
'server',
'router',
'tv',
'printer',
'unknown',
];
enum _DeviceFilter { newDevices, registered, all }
class DeviceList extends StatefulWidget {
@@ -111,9 +101,7 @@ class _DeviceListState extends State<DeviceList> {
Future<void> _showRegisterDialog(Device device) async {
final formKey = GlobalKey<FormState>();
String owner = '';
String deviceType = _deviceTypes.contains(device.deviceType)
? device.deviceType
: 'unknown';
DeviceType deviceType = device.deviceType;
final saved = await showDialog<bool>(
context: context,
@@ -135,12 +123,15 @@ class _DeviceListState extends State<DeviceList> {
const SizedBox(height: 16),
InputDecorator(
decoration: const InputDecoration(labelText: 'Device Type'),
child: DropdownButton<String>(
child: DropdownButton<DeviceType>(
value: deviceType,
isExpanded: true,
underline: const SizedBox(),
items: _deviceTypes
.map((t) => DropdownMenuItem(value: t, child: Text(t)))
items: DeviceType.values
.map(
(t) =>
DropdownMenuItem(value: t, child: Text(t.label)),
)
.toList(),
onChanged: (value) =>
setDialogState(() => deviceType = value ?? deviceType),
@@ -174,7 +165,7 @@ class _DeviceListState extends State<DeviceList> {
await BackendAPI.instance.registerDevice(
device.macAddress,
owner,
deviceType,
deviceType.name,
);
if (!mounted) return;
UISnackbars.showSuccess(context, 'Device registered');
@@ -185,27 +176,6 @@ class _DeviceListState extends State<DeviceList> {
}
}
IconData _deviceIcon(String deviceType) {
switch (deviceType.toLowerCase()) {
case 'phone':
return Icons.phone_android;
case 'laptop':
return Icons.laptop;
case 'tablet':
return Icons.tablet_android;
case 'server':
return Icons.dns;
case 'router':
return Icons.router;
case 'tv':
return Icons.tv;
case 'printer':
return Icons.print;
default:
return Icons.device_unknown;
}
}
String _emptyMessage() {
switch (_filter) {
case _DeviceFilter.newDevices:
@@ -281,12 +251,10 @@ class _DeviceListState extends State<DeviceList> {
onTap: () =>
context.push('/devices/${device.macAddress}'),
leading: Tooltip(
message:
device.deviceType.isEmpty ||
device.deviceType == 'unknown'
message: device.deviceType == DeviceType.unknown
? 'Device type unknown'
: device.deviceType,
child: Icon(_deviceIcon(device.deviceType)),
: device.deviceType.label,
child: Icon(device.deviceType.icon),
),
title: Row(
children: [