mirror of https://github.com/projectdiscovery/nuclei.git synced 2025-12-18 04:55:28 +00:00

History

fix(tmplexec): memory blowup in multiproto (#6258 )

* bugfix: fix memory blowup using previousEvent for multi-proto execution

* refactor(tmplexec): uses supported protocol types

Signed-off-by: Dwi Siswanto <git@dw1.io>

* add co-author

Co-authored-by: Nakul Bharti <knakul853@users.noreply.github.com>
Signed-off-by: Dwi Siswanto <git@dw1.io>

* refactor(tmplexec): mv builder inside loop scope

Signed-off-by: Dwi Siswanto <git@dw1.io>

* refactor(tmplexec): skip existing keys in `FillPreviousEvent`

The `FillPreviousEvent` func was modified to
prevent overwriting/duplicating entries in the
previous map.

It now checks if a key `k` from
`event.InternalEvent` already exists in the
previous map. If it does, the key is skipped. This
ensures that if `k` was already set (potentially
w/o a prefix), it's not re-added with an `ID_`
prefix.

Additionally, keys in `event.InternalEvent` that
already start with the current `ID_` prefix are
also skipped to avoid redundant prefixing.

This change simplifies the logic by removing the
`reqTypeWithIndexRegex` and directly addresses the
potential for duplicate / incorrectly prefixed
keys when `event.InternalEvent` grows during
protocol request execution.

Signed-off-by: Dwi Siswanto <git@dw1.io>

* chore(tmplexec): naming convention, `ID` => `protoID`

Signed-off-by: Dwi Siswanto <git@dw1.io>

* chore(tmplexec): it's request ID lol sorry

Signed-off-by: Dwi Siswanto <git@dw1.io>

---------

Signed-off-by: Dwi Siswanto <git@dw1.io>
Co-authored-by: Ice3man <nizamulrana@gmail.com>
Co-authored-by: Nakul Bharti <knakul853@users.noreply.github.com>

2025-06-17 04:53:32 +05:30

flow

feat: fixed max-host-error blocking + progress mismatch + misc (#6193 )

2025-05-07 17:22:15 +05:30

generic

fix(tmplexec): memory blowup in multiproto (#6258 )

2025-06-17 04:53:32 +05:30

multiproto

fix(tmplexec): memory blowup in multiproto (#6258 )

2025-06-17 04:53:32 +05:30

utils

fix(tmplexec): memory blowup in multiproto (#6258 )

2025-06-17 04:53:32 +05:30

doc.go

nuclei v3 : misc updates (#4247 )

2023-10-17 17:44:13 +05:30

exec.go

fix: race condition of the lastmatcherevent (#6080 )

2025-03-03 16:10:12 +05:30

interface.go

scan error formatting (#5628 )

2024-09-14 00:06:08 +05:30

README.md

nuclei v3 : misc updates (#4247 )

2023-10-17 17:44:13 +05:30

README.md

tmplexec

tmplexec also known as template executer executes template it is different from protocols package which only contains logic within the scope of one protocol. tmplexec is resposible for executing Template with defined logic. with introduction of multi protocol and flow templates (deprecated package protocols/common/executer) did not seem appropriate/helpful anymore as it is outside of protocol scope and deals with execution of template which can contain 1 requests , or multiple requests of same protocol or multiple requests of different protocols. tmplexec is responsible for executing template and handling all logic related to it.

Engine/Backends

Currently there are 3 engines for template execution

Generic => executes request[s] of same/one protocol
MultiProtocol => executes requests of multiple protocols with shared logic between protocol requests see multiprotocol
Flow => executes requests of one or multiple protocol requests as specified by template in javascript (aka flow) flow