From 357916a6e233276f9d73b58877b407f9de1c7655 Mon Sep 17 00:00:00 2001 From: mzack Date: Sun, 2 Jan 2022 09:09:10 +0100 Subject: [PATCH 1/2] Replacing murmur3 with internal safe-pointer version --- v2/pkg/operators/common/dsl/dsl.go | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/v2/pkg/operators/common/dsl/dsl.go b/v2/pkg/operators/common/dsl/dsl.go index 430be116f..55db83fd3 100644 --- a/v2/pkg/operators/common/dsl/dsl.go +++ b/v2/pkg/operators/common/dsl/dsl.go @@ -153,7 +153,9 @@ func init() { return hex.EncodeToString(hash.Sum(nil)), nil }), "mmh3": makeDslFunction(1, func(args ...interface{}) (interface{}, error) { - return fmt.Sprintf("%d", int32(murmur3.Sum32WithSeed([]byte(types.ToString(args[0])), 0))), nil + hasher := murmur3.New32WithSeed(0) + hasher.Write([]byte(fmt.Sprint(args[0]))) + return fmt.Sprint(hasher.Sum32()), nil }), "contains": makeDslFunction(2, func(args ...interface{}) (interface{}, error) { return strings.Contains(types.ToString(args[0]), types.ToString(args[1])), nil From 256c1f411e72901fcef5f841e55d3e44988a07ab Mon Sep 17 00:00:00 2001 From: mzack Date: Tue, 4 Jan 2022 18:10:20 +0100 Subject: [PATCH 2/2] fixing mmh3 signed int32 calculation --- v2/pkg/operators/common/dsl/dsl.go | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/v2/pkg/operators/common/dsl/dsl.go b/v2/pkg/operators/common/dsl/dsl.go index 55db83fd3..03f5da994 100644 --- a/v2/pkg/operators/common/dsl/dsl.go +++ b/v2/pkg/operators/common/dsl/dsl.go @@ -155,7 +155,7 @@ func init() { "mmh3": makeDslFunction(1, func(args ...interface{}) (interface{}, error) { hasher := murmur3.New32WithSeed(0) hasher.Write([]byte(fmt.Sprint(args[0]))) - return fmt.Sprint(hasher.Sum32()), nil + return fmt.Sprintf("%d", int32(hasher.Sum32())), nil }), "contains": makeDslFunction(2, func(args ...interface{}) (interface{}, error) { return strings.Contains(types.ToString(args[0]), types.ToString(args[1])), nil