From 88a13de2c2c54855ab51dec256de375f6eb45e4d Mon Sep 17 00:00:00 2001 From: coo1estguy <70365929+coolestcodeguy@users.noreply.github.com> Date: Mon, 28 Sep 2026 13:14:53 +0530 Subject: [PATCH] fix(ci): build root package before typechecking workspace packages Workspace packages import 'notifkit' which resolves to root dist/index.d.mts. Running build first ensures declaration files exist before workspace typecheck runs. --- .github/workflows/ci.yml | 6 +++--- package.json | 2 +- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index 8a924b2..56c6531 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -35,12 +35,12 @@ jobs: - name: Typecheck run: npm run typecheck - - name: Typecheck workspace packages - run: npm run typecheck:workspaces - - name: Build run: npm run build + - name: Typecheck workspace packages + run: npm run typecheck:workspaces + - name: Lint # Not `npm run lint` — that script carries --fix, which would paper over # violations instead of reporting them. diff --git a/package.json b/package.json index d8e9c99..bcd68c3 100644 --- a/package.json +++ b/package.json @@ -70,7 +70,7 @@ "typecheck": "tsc --noEmit", "typecheck:workspaces": "npm run typecheck --workspaces --if-present", "prepare": "husky", - "prepublishOnly": "npm run typecheck && npm run typecheck:workspaces && npm run build && npm run build:dashboard" + "prepublishOnly": "npm run typecheck && npm run build && npm run typecheck:workspaces && npm run build:dashboard" }, "dependencies": { "ai": "^7.0.118",