fixing job state setting when job is disabled

This commit is contained in:
orangecoding
2026-06-13 13:14:07 +02:00
parent 3249881771
commit 72c2c02e49
4 changed files with 76 additions and 3 deletions

View File

@@ -29,7 +29,7 @@ export default async function jobPlugin(fastify) {
fastify.get('/', async (request) => {
const isUserAdmin = isAdmin(request);
return jobStorage
.getJobs()
.getJobs({ includeDisabled: true })
.filter(
(job) =>
isUserAdmin ||

View File

@@ -169,9 +169,17 @@ export const removeJobsByUserId = (userId) => {
/**
* Get all jobs.
*
* By default only enabled jobs are returned, since most callers (scheduler,
* geocoding cron, tracker, dashboard) operate on active jobs only. The UI,
* however, must also be able to load disabled jobs (e.g. to edit them or view
* their listings), so it passes `includeDisabled: true`.
*
* @param {Object} [params]
* @param {boolean} [params.includeDisabled=false] - When true, disabled jobs are included.
* @returns {Job[]} List of jobs ordered by name (NULLs last).
*/
export const getJobs = () => {
export const getJobs = ({ includeDisabled = false } = {}) => {
const rows = SqliteConnection.query(
`SELECT j.id,
j.user_id AS userId,
@@ -186,7 +194,7 @@ export const getJobs = () => {
j.last_run_at AS lastRunAt,
(SELECT COUNT(1) FROM listings l WHERE l.job_id = j.id AND l.is_active = 1 AND l.manually_deleted = 0) AS numberOfFoundListings
FROM jobs j
WHERE j.enabled = 1
${includeDisabled ? '' : 'WHERE j.enabled = 1'}
ORDER BY j.name IS NULL, j.name`,
);
return rows.map((row) => ({