External/fredy
1
0
Fork 0
mirror of https://github.com/orangecoding/fredy.git synced 2026-06-16 12:31:07 +00:00
Code Issues Packages Projects Releases Wiki Activity

FIX: the previous commit was a little to early. Fixed 1aimmobilien provider

Browse Source
This commit is contained in:
Christian Kellner
2018-01-25 16:51:05 +01:00
parent a84591d2a6
commit 60f02f4d7a
3 changed files with 24 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
lib/notification/notify.js
View File

@@ -3,15 +3,15 @@ const path = './adapter';
/** Read every integration existing in ./adapter **/ /** Read every integration existing in ./adapter **/
const adapter = fs const adapter = fs
.readdirSync('./lib/notification/adapter') .readdirSync('./lib/notification/adapter')
.map(integPath => require(`${path}/${integPath}`)) .map(integPath => require(`${path}/${integPath}`))
.filter(integration => integration.enabled()); .filter(integration => integration.enabled());
if (adapter.length === 0) { if (adapter.length === 0) {
throw new Error('Please specify at least one notification provider'); throw new Error('Please specify at least one notification provider');
} }
exports.send = (serviceName, payload) => { exports.send = (serviceName, payload) => {
//this is not being used in tests, therefor adapter are always set //this is not being used in tests, therefor adapter are always set
return adapter.map(a => a.send(serviceName, payload)); return adapter.map(a => a.send(serviceName, payload));
}; };

4
lib/provider/einsAImmobilien.js
View File

@@ -4,7 +4,7 @@ const utils = require('../utils');
function normalize(o) { function normalize(o) {
const size = `${o.size.replace(' Wohnfläche ', '').trim()} / ${o.rooms.trim()}`; const size = `${o.size.replace(' Wohnfläche ', '').trim()} / ${o.rooms.trim()}`;
const link = `https://www.1a-immobilienmarkt.de/expose/13691814${o.id}.html` const link = `https://www.1a-immobilienmarkt.de/expose/${o.id}.html`;
return Object.assign(o, { size, link }); return Object.assign(o, { size, link });
} }
@@ -34,4 +34,4 @@ const einsAImmobilien = {
filter: applyBlacklist filter: applyBlacklist
}; };
module.exports = new Fredy(einsAImmobilien); module.exports = new Fredy(einsAImmobilien);

35
test/einsAImmobilien.test.js
View File

@@ -22,26 +22,23 @@ describe('#einsAImmobilien testsuite()', () => {
expect(immonetDbContent.einsAImmobilien).to.be.a('array'); expect(immonetDbContent.einsAImmobilien).to.be.a('array');
// const notificationObj = mockNotification.get(); const notificationObj = mockNotification.get();
// expect(notificationObj).to.be.a('object'); expect(notificationObj).to.be.a('object');
// expect(notificationObj.serviceName).to.equal('einsAImmobilien'); expect(notificationObj.serviceName).to.equal('einsAImmobilien');
//
// /** check the actual structure **/
// expect(notificationObj.payload.id).to.be.a('number');
// expect(notificationObj.payload.price).to.be.a('string');
// expect(notificationObj.payload.size).to.be.a('string');
// expect(notificationObj.payload.title).to.be.a('string');
// expect(notificationObj.payload.link).to.be.a('string');
// expect(notificationObj.payload.address).to.be.a('string');
//
// /** check the values if possible **/
// expect(notificationObj.payload.id).to.equal(immonetDbContent.immonet[immonetDbContent.immonet.length - 1]);
// expect(notificationObj.payload.price).that.does.include('€');
// expect(notificationObj.payload.size).that.does.include('m²');
// expect(notificationObj.payload.title).to.be.not.empty;
// expect(notificationObj.payload.link).that.does.include('https://www.immonet.de');
// expect(notificationObj.payload.address).to.be.not.empty;
/** check the actual structure **/
expect(notificationObj.payload.id).to.be.a('number');
expect(notificationObj.payload.price).to.be.a('string');
expect(notificationObj.payload.size).to.be.a('string');
expect(notificationObj.payload.title).to.be.a('string');
expect(notificationObj.payload.link).to.be.a('string');
/** check the values if possible **/
expect(notificationObj.payload.id).to.equal(immonetDbContent.einsAImmobilien[immonetDbContent.einsAImmobilien.length - 1]);
expect(notificationObj.payload.price).that.does.include('EUR');
expect(notificationObj.payload.size).that.does.include('m²');
expect(notificationObj.payload.title).to.be.not.empty;
expect(notificationObj.payload.link).that.does.include('https://www.1a-immobilienmarkt.de');
resolve(); resolve();
}); });
}); });