Improve comments for clarity

This commit is contained in:
buildplan
2025-10-14 13:30:14 +01:00
committed by GitHub
parent 255f3ac9c8
commit aa88da96f9

View File

@@ -574,38 +574,30 @@ cleanup_provider_packages() {
print_warning "Removing critical packages can break system functionality." print_warning "Removing critical packages can break system functionality."
fi fi
# Arrays to track findings
local PROVIDER_PACKAGES=() local PROVIDER_PACKAGES=()
local PROVIDER_SERVICES=() local PROVIDER_SERVICES=()
local PROVIDER_USERS=() local PROVIDER_USERS=()
local ROOT_SSH_KEYS=() local ROOT_SSH_KEYS=()
# Extended list of common provider and virtualization packages # List of common provider and virtualization packages
local COMMON_PROVIDER_PKGS=( local COMMON_PROVIDER_PKGS=(
# QEMU/KVM, Virtio, Generic virtualization
"qemu-guest-agent" "qemu-guest-agent"
"virtio-utils" "virtio-utils"
"virt-what" "virt-what"
# Cloud-init and cloud utilities
"cloud-init" "cloud-init"
"cloud-guest-utils" "cloud-guest-utils"
"cloud-initramfs-growroot" "cloud-initramfs-growroot"
"cloud-utils" "cloud-utils"
# VMware, Xen, Hyper-V, Oracle
"open-vm-tools" "open-vm-tools"
"xe-guest-utilities" "xe-guest-utilities"
"xen-tools" "xen-tools"
"hyperv-daemons" "hyperv-daemons"
"oracle-cloud-agent" "oracle-cloud-agent"
# AWS
"aws-systems-manager-agent" "aws-systems-manager-agent"
"amazon-ssm-agent" "amazon-ssm-agent"
# Google Cloud
"google-compute-engine" "google-compute-engine"
"google-osconfig-agent" "google-osconfig-agent"
# Azure
"walinuxagent" "walinuxagent"
# Popular VPS Providers
"hetzner-needrestart" "hetzner-needrestart"
"digitalocean-agent" "digitalocean-agent"
"do-agent" "do-agent"
@@ -613,7 +605,6 @@ cleanup_provider_packages() {
"vultr-monitoring" "vultr-monitoring"
"scaleway-ecosystem" "scaleway-ecosystem"
"ovh-rtm" "ovh-rtm"
# OpenStack (guest-side only)
"openstack-guest-utils" "openstack-guest-utils"
"openstack-nova-agent" "openstack-nova-agent"
) )
@@ -692,7 +683,7 @@ cleanup_provider_packages() {
echo echo
fi fi
# 1. SSH KEY AUDIT # Audit and optionally clean up root SSH keys
if [[ ${#ROOT_SSH_KEYS[@]} -gt 0 ]]; then if [[ ${#ROOT_SSH_KEYS[@]} -gt 0 ]]; then
print_section "Root SSH Key Audit" print_section "Root SSH Key Audit"
print_warning "SSH keys in /root/.ssh/authorized_keys can allow provider or previous admins access." print_warning "SSH keys in /root/.ssh/authorized_keys can allow provider or previous admins access."
@@ -738,7 +729,7 @@ cleanup_provider_packages() {
echo echo
fi fi
# 2. CLOUD-INIT HANDLING # Special handling for cloud-init due to its complexity
if [[ " ${PROVIDER_PACKAGES[*]} " =~ " cloud-init " ]]; then if [[ " ${PROVIDER_PACKAGES[*]} " =~ " cloud-init " ]]; then
print_section "Cloud-Init Management" print_section "Cloud-Init Management"
echo -e "${CYAN} cloud-init${NC}" echo -e "${CYAN} cloud-init${NC}"
@@ -802,7 +793,7 @@ cleanup_provider_packages() {
echo echo
fi fi
# 3. PACKAGE REMOVAL # Remove identified provider packages
if [[ ${#PROVIDER_PACKAGES[@]} -gt 0 ]]; then if [[ ${#PROVIDER_PACKAGES[@]} -gt 0 ]]; then
print_section "Provider Package Removal" print_section "Provider Package Removal"
@@ -877,7 +868,7 @@ cleanup_provider_packages() {
echo echo
fi fi
# 4. SYSTEM USER CLEANUP # Check and remove default users
if [[ ${#PROVIDER_USERS[@]} -gt 0 ]]; then if [[ ${#PROVIDER_USERS[@]} -gt 0 ]]; then
print_section "Provider User Cleanup" print_section "Provider User Cleanup"
print_warning "Default users created during provisioning can be security risks." print_warning "Default users created during provisioning can be security risks."
@@ -967,7 +958,7 @@ cleanup_provider_packages() {
echo echo
fi fi
# 5. CLEANUP # Final cleanup step
if [[ "$CLEANUP_PREVIEW" == "true" ]] || confirm "Remove residual configuration files and unused dependencies?" "y"; then if [[ "$CLEANUP_PREVIEW" == "true" ]] || confirm "Remove residual configuration files and unused dependencies?" "y"; then
if [[ "$CLEANUP_PREVIEW" == "true" ]]; then if [[ "$CLEANUP_PREVIEW" == "true" ]]; then
print_info "[PREVIEW] Would run: apt-get autoremove --purge -y" print_info "[PREVIEW] Would run: apt-get autoremove --purge -y"