refactor: move registration logic to Processor

src/Controller/HomeController.php

@@ -2,11 +2,15 @@
 
 namespace App\Controller;
 
+use App\Repository\UserRepository;
+use App\Security\EmailVerifier;
 use KnpU\OAuth2ClientBundle\Client\ClientRegistry;
+use Psr\Log\LoggerInterface;
 use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
 use Symfony\Bundle\SecurityBundle\Security;
 use Symfony\Component\DependencyInjection\ParameterBag\ParameterBagInterface;
 use Symfony\Component\HttpFoundation\RedirectResponse;
+use Symfony\Component\HttpFoundation\Request;
 use Symfony\Component\HttpFoundation\Response;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 use Symfony\Component\Routing\Attribute\Route;
@@ -17,6 +21,8 @@ class HomeController extends AbstractController
     public function __construct(
         private readonly RouterInterface $router,
         private readonly ParameterBagInterface $parameterBag,
+        private readonly EmailVerifier $emailVerifier,
+        private readonly LoggerInterface $logger,
     ) {
     }
 
@@ -46,4 +52,28 @@ class HomeController extends AbstractController
 
         return $response;
     }
+
+    #[Route('/verify/email', name: 'app_verify_email')]
+    public function verifyUserEmail(Request $request, UserRepository $userRepository): Response
+    {
+        $id = $request->query->get('id');
+
+        if (null === $id) {
+            return $this->redirectToRoute('index');
+        }
+
+        $user = $userRepository->find($id);
+
+        if (null === $user) {
+            return $this->redirectToRoute('index');
+        }
+
+        $this->emailVerifier->handleEmailConfirmation($request, $user);
+
+        $this->logger->info('User has validated his email address', [
+            'username' => $user->getUserIdentifier(),
+        ]);
+
+        return $this->redirectToRoute('index');
+    }
 }

src/Controller/RegistrationController.php

@@ -1,134 +0,0 @@
-<?php
-
-namespace App\Controller;
-
-use App\Entity\User;
-use App\Repository\UserRepository;
-use App\Security\EmailVerifier;
-use Doctrine\ORM\EntityManagerInterface;
-use Psr\Log\LoggerInterface;
-use Symfony\Bridge\Twig\Mime\TemplatedEmail;
-use Symfony\Bundle\FrameworkBundle\Controller\AbstractController;
-use Symfony\Component\HttpFoundation\Request;
-use Symfony\Component\HttpFoundation\Response;
-use Symfony\Component\HttpKernel\Exception\BadRequestHttpException;
-use Symfony\Component\HttpKernel\Exception\TooManyRequestsHttpException;
-use Symfony\Component\HttpKernel\Exception\UnauthorizedHttpException;
-use Symfony\Component\HttpKernel\KernelInterface;
-use Symfony\Component\Mailer\Exception\TransportExceptionInterface;
-use Symfony\Component\Mime\Address;
-use Symfony\Component\PasswordHasher\Hasher\UserPasswordHasherInterface;
-use Symfony\Component\RateLimiter\RateLimiterFactory;
-use Symfony\Component\Routing\Attribute\Route;
-use Symfony\Component\Serializer\SerializerInterface;
-use Symfony\Component\Validator\Validator\ValidatorInterface;
-
-class RegistrationController extends AbstractController
-{
-    public function __construct(
-        private readonly EmailVerifier $emailVerifier,
-        private readonly string $mailerSenderEmail,
-        private readonly string $mailerSenderName,
-        private readonly RateLimiterFactory $userRegisterLimiter,
-        private readonly EntityManagerInterface $em,
-        private readonly SerializerInterface $serializer,
-        private readonly LoggerInterface $logger,
-        private readonly KernelInterface $kernel,
-        private readonly ValidatorInterface $validator,
-    ) {
-    }
-
-    /**
-     * @throws TransportExceptionInterface
-     */
-    #[Route(
-        path: '/api/register',
-        name: 'user_register',
-        defaults: [
-            '_api_resource_class' => User::class,
-            '_api_operation_name' => 'user_register',
-        ],
-        methods: ['POST']
-    )]
-    public function register(Request $request, UserPasswordHasherInterface $userPasswordHasher): Response
-    {
-        if (false === $this->getParameter('registration_enabled')) {
-            throw new UnauthorizedHttpException('', 'Registration is disabled on this instance');
-        }
-
-        if (false === $this->kernel->isDebug()) {
-            $limiter = $this->userRegisterLimiter->create($request->getClientIp());
-            $limit = $limiter->consume();
-
-            if (!$limit->isAccepted()) {
-                throw new TooManyRequestsHttpException($limit->getRetryAfter()->getTimestamp() - time());
-            }
-        }
-
-        $user = $this->serializer->deserialize($request->getContent(), User::class, 'json', ['groups' => 'user:register']);
-        $violations = $this->validator->validate($user);
-
-        if ($violations->count() > 0) {
-            throw new BadRequestHttpException($violations->get(0));
-        }
-
-        $user->setPassword(
-            $userPasswordHasher->hashPassword(
-                $user,
-                $user->getPlainPassword()
-            )
-        )->setCreatedAt(new \DateTimeImmutable());
-
-        if (false === (bool) $this->getParameter('registration_verify_email')) {
-            $user->setVerifiedAt($user->getCreatedAt());
-        } else {
-            $email = $this->emailVerifier->sendEmailConfirmation('app_verify_email', $user,
-                (new TemplatedEmail())
-                    ->from(new Address($this->mailerSenderEmail, $this->mailerSenderName))
-                    ->to($user->getEmail())
-                    ->locale('en')
-                    ->subject('Please Confirm your Email')
-                    ->htmlTemplate('emails/success/confirmation_email.html.twig')
-            );
-
-            $signedUrl = (string) $email->getContext()['signedUrl'];
-            $this->logger->notice('The validation link for this user is generated', [
-                'username' => $user->getUserIdentifier(),
-                'signedUrl' => $signedUrl,
-            ]);
-        }
-
-        $this->em->persist($user);
-        $this->em->flush();
-
-        $this->logger->info('New user has registered', [
-            'username' => $user->getUserIdentifier(),
-        ]);
-
-        return new Response(null, 201);
-    }
-
-    #[Route('/verify/email', name: 'app_verify_email')]
-    public function verifyUserEmail(Request $request, UserRepository $userRepository): Response
-    {
-        $id = $request->query->get('id');
-
-        if (null === $id) {
-            return $this->redirectToRoute('index');
-        }
-
-        $user = $userRepository->find($id);
-
-        if (null === $user) {
-            return $this->redirectToRoute('index');
-        }
-
-        $this->emailVerifier->handleEmailConfirmation($request, $user);
-
-        $this->logger->info('User has validated his email address', [
-            'username' => $user->getUserIdentifier(),
-        ]);
-
-        return $this->redirectToRoute('index');
-    }
-}