From 0657891b8d8773a371ce49c4949de197aecd9eb5 Mon Sep 17 00:00:00 2001 From: Stefan Warnat Date: Sun, 22 Sep 2024 18:48:32 +0200 Subject: [PATCH 1/2] fix: RDAP Server of DENIC do not return events Signed-off-by: Stefan Warnat --- src/Service/RDAPService.php | 38 +++++++++++++++++++------------------ 1 file changed, 20 insertions(+), 18 deletions(-) diff --git a/src/Service/RDAPService.php b/src/Service/RDAPService.php index 2805b27..39c9a3e 100644 --- a/src/Service/RDAPService.php +++ b/src/Service/RDAPService.php @@ -232,25 +232,27 @@ readonly class RDAPService $event->setDeleted(true); } - foreach ($res['events'] as $rdapEvent) { - if ($rdapEvent['eventAction'] === EventAction::LastUpdateOfRDAPDatabase->value) { - continue; + if(!empty($res["events"])) { + foreach ($res['events'] as $rdapEvent) { + if ($rdapEvent['eventAction'] === EventAction::LastUpdateOfRDAPDatabase->value) { + continue; + } + + $event = $this->domainEventRepository->findOneBy([ + 'action' => $rdapEvent['eventAction'], + 'date' => new \DateTimeImmutable($rdapEvent['eventDate']), + 'domain' => $domain, + ]); + + if (null === $event) { + $event = new DomainEvent(); + } + $domain->addEvent($event + ->setAction($rdapEvent['eventAction']) + ->setDate(new \DateTimeImmutable($rdapEvent['eventDate'])) + ->setDeleted(false) + ); } - - $event = $this->domainEventRepository->findOneBy([ - 'action' => $rdapEvent['eventAction'], - 'date' => new \DateTimeImmutable($rdapEvent['eventDate']), - 'domain' => $domain, - ]); - - if (null === $event) { - $event = new DomainEvent(); - } - $domain->addEvent($event - ->setAction($rdapEvent['eventAction']) - ->setDate(new \DateTimeImmutable($rdapEvent['eventDate'])) - ->setDeleted(false) - ); } /** @var DomainEntity $domainEntity */ From a94a775ee6a4da932d00680ec29b7e5c380e0c10 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ma=C3=ABl=20Gangloff?= Date: Sun, 22 Sep 2024 19:49:35 +0200 Subject: [PATCH 2/2] chore: reformat code --- src/Service/RDAPService.php | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/src/Service/RDAPService.php b/src/Service/RDAPService.php index 39c9a3e..f20c2cb 100644 --- a/src/Service/RDAPService.php +++ b/src/Service/RDAPService.php @@ -232,18 +232,18 @@ readonly class RDAPService $event->setDeleted(true); } - if(!empty($res["events"])) { + if (array_key_exists('events', $res) && is_array($res['events'])) { foreach ($res['events'] as $rdapEvent) { if ($rdapEvent['eventAction'] === EventAction::LastUpdateOfRDAPDatabase->value) { continue; } - + $event = $this->domainEventRepository->findOneBy([ 'action' => $rdapEvent['eventAction'], 'date' => new \DateTimeImmutable($rdapEvent['eventDate']), 'domain' => $domain, ]); - + if (null === $event) { $event = new DomainEvent(); }