From 37cd4edccebe3200f53d8dd5455f2ccf6493ac9a Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ma=C3=ABl=20Gangloff?= <contact@maelgangloff.fr>
Date: Sun, 6 Oct 2024 20:37:56 +0200
Subject: [PATCH] chore: remove isDeleted check in orderDomain

---
 assets/components/tracking/connector/ConnectorForm.tsx | 6 +++---
 assets/utils/providers/index.tsx                       | 4 +++-
 src/Service/Connector/AutodnsProvider.php              | 4 ----
 src/Service/Connector/GandiProvider.php                | 4 ----
 src/Service/Connector/OvhProvider.php                  | 4 ----
 translations/translations.pot                          | 8 ++++----
 6 files changed, 10 insertions(+), 20 deletions(-)

diff --git a/assets/components/tracking/connector/ConnectorForm.tsx b/assets/components/tracking/connector/ConnectorForm.tsx
index af697e6..f5a914f 100644
--- a/assets/components/tracking/connector/ConnectorForm.tsx
+++ b/assets/components/tracking/connector/ConnectorForm.tsx
@@ -154,11 +154,11 @@ export function ConnectorForm({form, onCreate}: { form: FormInstance, onCreate:
                     <Input.Password autoComplete='off' required={true} placeholder=''/>
                 </Form.Item>
                 <Form.Item
-                    label={t`Domain Contact Handle ID`}
+                    label={t`Owner nic-handle`}
                     name={['authData', 'contactid']}
                     help={<Typography.Text
-                        type='secondary'>{t`The Contact ID for ownership of registered Domains. `}<a
-                        href="https://cloud.autodns.com/contacts/domain">{t`You got from this page`}</a></Typography.Text>}
+                        type='secondary'>{t`The nic-handle of the domain name owner`}<a
+                        href="https://cloud.autodns.com/contacts/domain">{t`You can get it from this page`}</a></Typography.Text>}
                     rules={[{required: true, message: t`Required`}]}
                     required={true}>
                     <Input autoComplete='off' required={true} placeholder=''/>
diff --git a/assets/utils/providers/index.tsx b/assets/utils/providers/index.tsx
index 7a04219..80d3264 100644
--- a/assets/utils/providers/index.tsx
+++ b/assets/utils/providers/index.tsx
@@ -21,7 +21,7 @@ export const helpGetTokenLink = (provider?: string) => {
             </Typography.Link>
         case ConnectorProvider.AUTODNS:
             return <Typography.Link target='_blank' href="https://en.autodns.com/domain-robot-api/">
-                {t`Because of some limitations in API of AutoDNS, we suggest to create an dedicated user for API with limited rights.`}
+                {t`Because of some limitations in API of AutoDNS, we suggest to create an dedicated user for API with limited rights`}
             </Typography.Link>
         default:
             return <></>
@@ -35,6 +35,8 @@ export const tosHyperlink = (provider?: string) => {
             return 'https://www.ovhcloud.com/fr/terms-and-conditions/contracts/'
         case ConnectorProvider.GANDI:
             return 'https://www.gandi.net/en/contracts/terms-of-service'
+        case ConnectorProvider.NAMECHEAP:
+            return 'https://www.namecheap.com/legal/universal/universal-tos/'
         case ConnectorProvider.AUTODNS:
             return 'https://www.internetx.com/agb/'
         default:
diff --git a/src/Service/Connector/AutodnsProvider.php b/src/Service/Connector/AutodnsProvider.php
index d97f94f..c121156 100644
--- a/src/Service/Connector/AutodnsProvider.php
+++ b/src/Service/Connector/AutodnsProvider.php
@@ -35,10 +35,6 @@ class AutodnsProvider extends AbstractProvider
      */
     public function orderDomain(Domain $domain, bool $dryRun = false): void
     {
-        if (!$domain->getDeleted()) {
-            throw new \InvalidArgumentException('The domain name still appears in the WHOIS database');
-        }
-
         $ldhName = $domain->getLdhName();
         if (!$ldhName) {
             throw new \InvalidArgumentException('Domain name cannot be null');
diff --git a/src/Service/Connector/GandiProvider.php b/src/Service/Connector/GandiProvider.php
index 348c134..fb90b09 100644
--- a/src/Service/Connector/GandiProvider.php
+++ b/src/Service/Connector/GandiProvider.php
@@ -34,10 +34,6 @@ class GandiProvider extends AbstractProvider
      */
     public function orderDomain(Domain $domain, bool $dryRun = false): void
     {
-        if (!$domain->getDeleted()) {
-            throw new \InvalidArgumentException('The domain name still appears in the WHOIS database');
-        }
-
         $ldhName = $domain->getLdhName();
         if (!$ldhName) {
             throw new \InvalidArgumentException('Domain name cannot be null');
diff --git a/src/Service/Connector/OvhProvider.php b/src/Service/Connector/OvhProvider.php
index 1d917e9..c2795f8 100644
--- a/src/Service/Connector/OvhProvider.php
+++ b/src/Service/Connector/OvhProvider.php
@@ -53,10 +53,6 @@ class OvhProvider extends AbstractProvider
      */
     public function orderDomain(Domain $domain, bool $dryRun = false): void
     {
-        if (!$domain->getDeleted()) {
-            throw new \InvalidArgumentException('The domain name still appears in the WHOIS database');
-        }
-
         $ldhName = $domain->getLdhName();
         if (!$ldhName) {
             throw new \InvalidArgumentException('Domain name cannot be null');
diff --git a/translations/translations.pot b/translations/translations.pot
index 30df91e..740145e 100644
--- a/translations/translations.pot
+++ b/translations/translations.pot
@@ -242,15 +242,15 @@ msgid "AutoDNS Password"
 msgstr ""
 
 #: assets/components/tracking/connector/ConnectorForm.tsx:157
-msgid "Domain Contact Handle ID"
+msgid "Owner nic-handle"
 msgstr ""
 
 #: assets/components/tracking/connector/ConnectorForm.tsx:160
-msgid "The Contact ID for ownership of registered Domains. "
+msgid "The nic-handle of the domain name owner"
 msgstr ""
 
 #: assets/components/tracking/connector/ConnectorForm.tsx:161
-msgid "You got from this page"
+msgid "You can get it from this page"
 msgstr ""
 
 #: assets/components/tracking/connector/ConnectorForm.tsx:168
@@ -1102,7 +1102,7 @@ msgstr ""
 #: assets/utils/providers/index.tsx:24
 msgid ""
 "Because of some limitations in API of AutoDNS, we suggest to create an "
-"dedicated user for API with limited rights."
+"dedicated user for API with limited rights"
 msgstr ""
 
 #: assets/utils/providers/ovh.tsx:5