From 2a64bceceebfa8fa949b545f8fefc6d21c968cd1 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ma=C3=ABl=20Gangloff?= <contact@maelgangloff.fr>
Date: Sun, 22 Dec 2024 23:48:37 +0100
Subject: [PATCH] fix: some RDAP servers return the same entity twice

---
 src/Service/RDAPService.php | 14 ++++++++++++--
 1 file changed, 12 insertions(+), 2 deletions(-)

diff --git a/src/Service/RDAPService.php b/src/Service/RDAPService.php
index 84a6031..676cc8a 100644
--- a/src/Service/RDAPService.php
+++ b/src/Service/RDAPService.php
@@ -323,6 +323,7 @@ readonly class RDAPService
 
     /**
      * @throws \DateMalformedStringException
+     * @throws \Exception
      */
     private function updateDomainEntities(Domain $domain, array $rdapData): void
     {
@@ -351,6 +352,7 @@ readonly class RDAPService
                     ->setDeleted(false));
 
                 $this->em->persist($domainEntity);
+                $this->em->flush();
             }
         }
     }
@@ -395,6 +397,9 @@ readonly class RDAPService
         return $nameserver;
     }
 
+    /**
+     * @throws \DateMalformedStringException
+     */
     private function updateNameserverEntities(Nameserver $nameserver, array $rdapNameserver): void
     {
         if (!array_key_exists('entities', $rdapNameserver) || !is_array($rdapNameserver['entities'])) {
@@ -403,7 +408,6 @@ readonly class RDAPService
 
         foreach ($rdapNameserver['entities'] as $rdapEntity) {
             $roles = $this->extractEntityRoles($rdapNameserver['entities'], $rdapEntity);
-
             $entity = $this->registerEntity($rdapEntity, $roles, $nameserver->getLdhName());
 
             $nameserverEntity = $this->nameserverEntityRepository->findOneBy([
@@ -429,7 +433,13 @@ readonly class RDAPService
             fn ($e) => $e['roles'],
             array_filter(
                 $entities,
-                fn ($e) => $targetEntity === $e
+                fn ($e) => array_key_exists('handle', $targetEntity) && array_key_exists('handle', $e)
+                    ? $targetEntity['handle'] === $e['handle']
+                    : (
+                        array_key_exists('vcardArray', $targetEntity) && array_key_exists('vcardArray', $e)
+                            ? $targetEntity['vcardArray'] === $e['vcardArray']
+                            : $targetEntity === $e
+                    )
             )
         );