chore: in fact, it is ICANN that accredits the registrars

This commit is contained in:
Maël Gangloff
2025-09-12 23:34:58 +02:00
parent 71e23ca83d
commit 0be609cc9d
5 changed files with 55 additions and 18 deletions

View File

@@ -0,0 +1,37 @@
<?php
declare(strict_types=1);
namespace DoctrineMigrations;
use Doctrine\DBAL\Schema\Schema;
use Doctrine\Migrations\AbstractMigration;
/**
* Auto-generated Migration: Please modify to your needs!
*/
final class Version20250912212814 extends AbstractMigration
{
public function getDescription(): string
{
return 'Rename IANA columns to ICANN';
}
public function up(Schema $schema): void
{
$this->addSql('ALTER TABLE entity RENAME COLUMN iana_registrar_name TO icann_registrar_name');
$this->addSql('ALTER TABLE entity RENAME COLUMN iana_rdap_base_url TO icann_rdap_base_url');
$this->addSql('ALTER TABLE entity RENAME COLUMN iana_status TO icann_status');
$this->addSql('ALTER TABLE entity RENAME COLUMN iana_updated TO icann_updated');
$this->addSql('ALTER TABLE entity RENAME COLUMN iana_date TO icann_date');
}
public function down(Schema $schema): void
{
$this->addSql('ALTER TABLE entity RENAME COLUMN icann_registrar_name TO iana_registrar_name');
$this->addSql('ALTER TABLE entity RENAME COLUMN icann_rdap_base_url TO iana_rdap_base_url');
$this->addSql('ALTER TABLE entity RENAME COLUMN icann_status TO iana_status');
$this->addSql('ALTER TABLE entity RENAME COLUMN icann_updated TO iana_updated');
$this->addSql('ALTER TABLE entity RENAME COLUMN icann_date TO iana_date');
}
}

View File

@@ -8,7 +8,7 @@ use ApiPlatform\Metadata\Operation;
use App\Entity\Entity; use App\Entity\Entity;
use Doctrine\ORM\QueryBuilder; use Doctrine\ORM\QueryBuilder;
class NotNullAccreditationIanaExtension implements QueryCollectionExtensionInterface class NotNullAccreditationIcannExtension implements QueryCollectionExtensionInterface
{ {
public function applyToCollection( public function applyToCollection(
QueryBuilder $queryBuilder, QueryBuilder $queryBuilder,
@@ -20,9 +20,9 @@ class NotNullAccreditationIanaExtension implements QueryCollectionExtensionInter
if (Entity::class !== $resourceClass) { if (Entity::class !== $resourceClass) {
return; return;
} }
if ($operation && 'iana_accreditations_collection' === $operation->getName()) { if ($operation && 'icann_accreditations_collection' === $operation->getName()) {
$rootAlias = $queryBuilder->getRootAliases()[0]; $rootAlias = $queryBuilder->getRootAliases()[0];
$queryBuilder->andWhere(sprintf('%s.ianaAccreditation.status IS NOT NULL', $rootAlias)); $queryBuilder->andWhere(sprintf('%s.icannAccreditation.status IS NOT NULL', $rootAlias));
} }
} }
} }

View File

@@ -21,11 +21,11 @@ use Symfony\Component\Serializer\Attribute\SerializedName;
#[ApiResource( #[ApiResource(
operations: [ operations: [
new GetCollection( new GetCollection(
uriTemplate: '/entities/iana-accreditations', uriTemplate: '/entities/icann-accreditations',
openapiContext: [ openapiContext: [
'parameters' => [ 'parameters' => [
[ [
'name' => 'ianaAccreditation.status', 'name' => 'icannAccreditation.status',
'in' => 'query', 'in' => 'query',
'required' => true, 'required' => true,
'schema' => [ 'schema' => [
@@ -37,13 +37,13 @@ use Symfony\Component\Serializer\Attribute\SerializedName;
], ],
'style' => 'form', 'style' => 'form',
'explode' => true, 'explode' => true,
'description' => 'Filter by IANA accreditation status', 'description' => 'Filter by ICANN accreditation status',
], ],
], ],
], ],
description: 'IANA Registrar IDs list', description: 'ICANN Registrar IDs list',
normalizationContext: ['groups' => ['entity:list']], normalizationContext: ['groups' => ['entity:list']],
name: 'iana_accreditations_collection' name: 'icann_accreditations_collection'
), ),
/* /*
new GetCollection( new GetCollection(
@@ -70,7 +70,7 @@ use Symfony\Component\Serializer\Attribute\SerializedName;
#[ApiFilter( #[ApiFilter(
SearchFilter::class, SearchFilter::class,
properties: [ properties: [
'ianaAccreditation.status' => 'exact', 'icannAccreditation.status' => 'exact',
] ]
)] )]
class Entity class Entity
@@ -120,16 +120,16 @@ class Entity
#[Groups(['entity:item', 'domain:item'])] #[Groups(['entity:item', 'domain:item'])]
private ?array $remarks = null; private ?array $remarks = null;
#[Embedded(class: IanaAccreditation::class, columnPrefix: 'iana_')] #[Embedded(class: IcannAccreditation::class, columnPrefix: 'icann_')]
#[Groups(['entity:list', 'entity:item', 'domain:item'])] #[Groups(['entity:list', 'entity:item', 'domain:item'])]
private ?IanaAccreditation $ianaAccreditation = null; private ?IcannAccreditation $icannAccreditation = null;
public function __construct() public function __construct()
{ {
$this->domainEntities = new ArrayCollection(); $this->domainEntities = new ArrayCollection();
$this->nameserverEntities = new ArrayCollection(); $this->nameserverEntities = new ArrayCollection();
$this->events = new ArrayCollection(); $this->events = new ArrayCollection();
$this->ianaAccreditation = new IanaAccreditation(); $this->icannAccreditation = new IcannAccreditation();
} }
public function getHandle(): ?string public function getHandle(): ?string
@@ -282,13 +282,13 @@ class Entity
return $this; return $this;
} }
public function getIanaAccreditation(): ?IanaAccreditation public function getIcannAccreditation(): ?IcannAccreditation
{ {
return null === $this->ianaAccreditation->getStatus() ? null : $this->ianaAccreditation; return null === $this->icannAccreditation->getStatus() ? null : $this->icannAccreditation;
} }
public function setIanaAccreditation(?IanaAccreditation $ianaAccreditation): void public function setIcannAccreditation(?IcannAccreditation $icannAccreditation): void
{ {
$this->ianaAccreditation = $ianaAccreditation; $this->icannAccreditation = $icannAccreditation;
} }
} }

View File

@@ -9,7 +9,7 @@ use Doctrine\ORM\Mapping\Embeddable;
use Symfony\Component\Serializer\Attribute\Groups; use Symfony\Component\Serializer\Attribute\Groups;
#[Embeddable] #[Embeddable]
class IanaAccreditation class IcannAccreditation
{ {
#[ORM\Column(length: 255, nullable: true)] #[ORM\Column(length: 255, nullable: true)]
#[Groups(['entity:item', 'entity:list', 'domain:item'])] #[Groups(['entity:item', 'entity:list', 'domain:item'])]

View File

@@ -849,7 +849,7 @@ class RDAPService
->setTld(null) ->setTld(null)
->setJCard(['vcard', [['version', [], 'text', '4.0'], ['fn', [], 'text', (string) $registrar->name]]]) ->setJCard(['vcard', [['version', [], 'text', '4.0'], ['fn', [], 'text', (string) $registrar->name]]])
->setRemarks(null) ->setRemarks(null)
->getIanaAccreditation() ->getIcannAccreditation()
->setRegistrarName($registrar->name) ->setRegistrarName($registrar->name)
->setStatus(RegistrarStatus::from($registrar->status)) ->setStatus(RegistrarStatus::from($registrar->status))
->setRdapBaseUrl($registrar->rdapurl->count() ? ($registrar->rdapurl->server) : null) ->setRdapBaseUrl($registrar->rdapurl->count() ? ($registrar->rdapurl->server) : null)