mirror of
https://github.com/JuliusBrussee/caveman.git
synced 2026-08-11 13:21:09 +02:00
Julius BrusseeandClaude Opus 4.7
754795ada4
Two bugs at the curl|bash entry point made the headline install command
fail immediately:
1. install.sh used `${BASH_SOURCE[0]}` under `set -u`. That variable is
unset when bash is invoked from stdin (curl | bash), tripping the
nounset trap before we ever reached the npx fallback.
2. install.sh + install.ps1 passed `--` between npx and the package args.
On modern npm, npx forwards the literal `--` to bin/install.js, which
parseArgs rejected as an unknown flag.
Fix:
- install.sh: default BASH_SOURCE[0] to empty so the curl-pipe path falls
through cleanly under set -u.
- install.sh + install.ps1: drop the `--` separator. npm 7+ npx already
forwards trailing args correctly.
- bin/install.js parseArgs: accept a bare `--` as a no-op (POSIX
end-of-options marker) so future shim drift can't re-break this.
- New regression test asserts `--` is accepted.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
63 lines
1.9 KiB
PowerShell
63 lines
1.9 KiB
PowerShell
# caveman — installer shim (Windows / PowerShell).
|
|
#
|
|
# Thin wrapper around bin/install.js (the unified Node installer). Every flag
|
|
# you'd pass to bin/install.js can be passed here; we just forward them.
|
|
#
|
|
# One-line install:
|
|
# irm https://raw.githubusercontent.com/JuliusBrussee/caveman/main/install.ps1 | iex
|
|
#
|
|
# Local clone:
|
|
# pwsh install.ps1 [flags]
|
|
#
|
|
# Why a Node installer? install.sh + install.ps1 used to be parallel sources of
|
|
# truth and constantly drifted (issue #249 was a `node -e "..."` quoting bug
|
|
# that silently dropped the JSON merge step on every Windows install). One
|
|
# Node script works everywhere without quoting bugs.
|
|
|
|
[CmdletBinding()]
|
|
param(
|
|
[Parameter(ValueFromRemainingArguments = $true)]
|
|
[string[]]$Args
|
|
)
|
|
|
|
$ErrorActionPreference = "Stop"
|
|
$Repo = "JuliusBrussee/caveman"
|
|
|
|
# Require Node ≥18.
|
|
$node = Get-Command node -ErrorAction SilentlyContinue
|
|
if (-not $node) {
|
|
Write-Error @"
|
|
caveman: Node.js (>=18) required. Install:
|
|
- winget install OpenJS.NodeJS.LTS
|
|
- or download from https://nodejs.org
|
|
"@
|
|
exit 1
|
|
}
|
|
|
|
$nodeMajor = [int](& node -p "process.versions.node.split('.')[0]")
|
|
if ($nodeMajor -lt 18) {
|
|
Write-Error "caveman: Node $nodeMajor too old. Need Node >=18. Upgrade: https://nodejs.org"
|
|
exit 1
|
|
}
|
|
|
|
# If we're inside the repo clone, run the local installer directly.
|
|
$here = Split-Path -Parent $MyInvocation.MyCommand.Path
|
|
$local = Join-Path $here "bin/install.js"
|
|
if (Test-Path $local) {
|
|
& node $local @Args
|
|
exit $LASTEXITCODE
|
|
}
|
|
|
|
# Curl-pipe path: delegate to npx.
|
|
$npx = Get-Command npx -ErrorAction SilentlyContinue
|
|
if (-not $npx) {
|
|
Write-Error "caveman: npx required (ships with Node >=18). Reinstall Node.js."
|
|
exit 1
|
|
}
|
|
|
|
# Do NOT pass `--` here — npm 7+ npx already forwards trailing args to the
|
|
# package, and a literal `--` was tripping bin/install.js's parseArgs as an
|
|
# unknown flag.
|
|
& npx -y "github:$Repo" @Args
|
|
exit $LASTEXITCODE
|