mirror of
https://github.com/block/buzz.git
synced 2026-08-18 06:50:31 +02:00
npub1qyvc0c5kl4gqv2fd97fsk46tu378sqgy35vc83rvgfwne90sel7s0ed67dandTyler Longwell
9787250322
Dawn's blocker: the loader-boundary collision/dedup enforcement was untested — deleting either block left the full suite green. The stale load_applies_id_collision_check only called check_id_collision directly and its comment described the pre-fix architecture. Replaced with a version that drives the REAL load_custom_harnesses against a shadowing goose.json, plus a dedup twin (two files, same id -> len()==1). Both verified to kill the mutants locally. Wren's test-quality gap: the interleaving regressions pinned the warm_harness_registry_locked seam but never executed discovery — a stale-publish mutant of discover_acp_runtimes_from stayed green. Added a cfg(test) pre_publish_test_hook between discovery's scan and its registry publish, and two production-path regressions that land a save/delete through the real discover_acp_runtimes_from call. Verified both red under the stale-publish mutant. Wren's product gap: the delete confirmation could be confirmed before the blast-radius queries settled (pending queries rendered as zero dependents with an enabled destructive button). New deleteConfirmState drives the confirm UI: disabled + 'Checking which agents…' while either query is initial-loading; on query failure deletion stays possible but the copy says the count is unknown instead of claiming zero. Unit-tested for pending/error/settled states. Dawn + Wren both: get_agent_models now routes harness-resolution errors through user_facing_harness_error (model_discovery_error helper), so a dangling harness renders as a sentence, never the raw DANGLING_HARNESS_ID sentinel. Also added Dawn's requested comment at discovery's publish noting which tests pin the seam. File-size ratchets bumped with documented deltas (all test/test-seam growth). Co-authored-by: Tyler Longwell <tlongwell@block.xyz> Signed-off-by: Tyler Longwell <tlongwell@block.xyz>