mirror of
https://github.com/block/buzz.git
synced 2026-08-18 06:50:31 +02:00
## What Phase 2 consumer cutover targeting the `duncan/databricks-model-label-registry` umbrella branch. Wires `crates/**` and `desktop/**` consumers to the generated capability module introduced in Phase 1 (#3821), while keeping old and new paths both live for differential testing. Phase 3 removes the old paths. ## Commits (boundary-separated) ### feat(agent): Phase 2a — wire Rust consumers to generated capability module (`crates/**`, `scripts/**`) - `catalog.rs`: `DATABRICKS_V2_KNOWN_MODELS` re-exported from the generated module — single source of truth. - `llm.rs`: `databricks_v2_route_for_model` delegates to `resolve_model_capabilities("databricks_v2", model)`. Old segment-based classifier preserved as `#[cfg(test)] _old_*` for the differential harness. New `databricks_v2_route_differential_old_vs_new` test confirms 100% agreement on all 20 route vectors. - `config.rs`: new `effort_table_fixture_differential_old_vs_new` test runs `resolve_model_capabilities` over the 36-entry `effortTable.fixture.json` and asserts old/new agree modulo a doc-cited allowlist (4 F1 corrections). - `scripts/run-differential.mjs`: JS differential harness over effortTable fixture + normative corpus + catalog-sample fixture. 85 checks, 0 unexpected divergences (5 allowlisted: 4 F1 corrections + goose-opus-5 anthropic route correction). - `scripts/MODELS_DEV_RECONCILIATION.md`: deferred MINOR from Phase 1 — 8 trailing-double-space line breaks replaced with `<br>`. ### feat(desktop): Phase 2b — cut TS consumers to generated model-capabilities module (`desktop/**`) - `buzzAgentConfig.ts`: adds `getProviderEffortConfigFromManifest(provider, model?)` — thin wrapper over `resolveModelCapabilities()` from `modelCapabilities.ts`. Maps `supportedEfforts → validValues` and `defaultEffort → defaultValue` (null preserved for manual-budget/Inherit). Old `getProviderEffortConfig()` and all hand-tables stay live for the differential harness; Phase 3 retires them. - `formatAgentModelLabel.ts`: registry-label lookup re-pointed from hand-maintained `databricksModelNames.ts` import to generated `DATABRICKS_MODEL_NAMES` exported from `modelCapabilities.ts`. Same Map shape, identical contents, behavior unchanged. ### fix(scripts): add ts-esm-loader and fix allowlist coverage in run-differential (`scripts/**`) - `scripts/ts-esm-loader.mjs`: minimal ESM custom loader that resolves extensionless relative TS imports. Required because Phase 2b's `buzzAgentConfig.ts` imports `modelCapabilities` without `.ts` extension — which Node's `--experimental-strip-types` runner cannot resolve without a hook. - `scripts/run-differential.mjs`: shebang updated to self-bootstrap with the loader; fixes the `totalAllowlisted` counter (was declared but never incremented — always printed `0 allowlisted`). Replaced with per-axis hit tracking: reports exercised slot count (`N/total`) in summary; fails with `STALE_ALLOWLIST` if any declared entry fires zero divergences, preventing stale entries from silently masking future regressions. ## Verification - `cargo test -p buzz-agent --lib`: 426/426 - Corpus: 45/45 · schema-negative: 24/24 · `--check` byte-clean - Differential: 85 checks, 0 unexpected divergences, 6/6 allowlist slots exercised - Desktop: 3847/3847 · typecheck clean · biome clean - Mobile: 1019 pass, 1 skipped — same 5 flaky tests in `mobile/test/features/channels/` that reproduce at the umbrella base; zero mobile files in this branch range - `git diff --check`: clean ## What Remains (Phase 3) Remove old hand-maintained paths: `_old_*` functions in `llm.rs`/`config.rs`, old `getProviderEffortConfig` tables in `buzzAgentConfig.ts`, old `databricksModelNames.ts` import in `formatAgentModelLabel.ts`, old `databricks_model_names.rs` module. --------- Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: npub1g8493u0xfsjrvflg4n08ezd7vec99mnwzlv0qgwpr9d7gvjwhuzqx59rhw <41ea58f1e64c243627e8acde7c89be667052ee6e17d8f021c1195be4324ebf04@buzz.block.builderlab.xyz> Signed-off-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz> Co-authored-by: npub1g8493u0xfsjrvflg4n08ezd7vec99mnwzlv0qgwpr9d7gvjwhuzqx59rhw <41ea58f1e64c243627e8acde7c89be667052ee6e17d8f021c1195be4324ebf04@buzz.block.builderlab.xyz>
97 lines
3.4 KiB
JavaScript
97 lines
3.4 KiB
JavaScript
#!/usr/bin/env node
|
|
/**
|
|
* Normative corpus runner — validates the generated TS interpreter against
|
|
* scripts/normative-corpus.json.
|
|
*
|
|
* This is the JS side of the two-interpreter corpus check. The runner imports
|
|
* resolveModelCapabilities() directly from the generated TypeScript module via
|
|
* Node's --experimental-strip-types flag. The Rust side lives in
|
|
* crates/buzz-agent/src/generated_model_capabilities.rs (shared corpus harness).
|
|
*
|
|
* Usage: node --experimental-strip-types scripts/run-corpus.mjs [--verbose]
|
|
* Exits 0 on all pass, 1 on any failure.
|
|
*/
|
|
|
|
import { readFileSync } from "node:fs";
|
|
import { join, dirname } from "node:path";
|
|
import { fileURLToPath } from "node:url";
|
|
|
|
const __dirname = dirname(fileURLToPath(import.meta.url));
|
|
const repoRoot = join(__dirname, "..");
|
|
const VERBOSE = process.argv.includes("--verbose");
|
|
|
|
// Import the generated TypeScript interpreter directly.
|
|
// Node 22+ --experimental-strip-types strips type annotations at load time; no build step needed.
|
|
const { resolveModelCapabilities } = await import(
|
|
join(repoRoot, "desktop", "src", "features", "agents", "ui", "modelCapabilities.ts")
|
|
);
|
|
|
|
const corpus = JSON.parse(
|
|
readFileSync(join(repoRoot, "scripts", "normative-corpus.json"), "utf8"),
|
|
);
|
|
|
|
// ----- Provider alias canonicalization -----
|
|
// Mirrors production canonicalizeProvider() in desktop/src/features/agents/lib/formatAgentModelLabel.ts.
|
|
// Applied before every generated lookup so alias vectors (e.g. "openai-compat") pass both interpreters.
|
|
const PROVIDER_ALIASES = {
|
|
"databricks-v2": "databricks_v2",
|
|
"openai-compat": "openai",
|
|
};
|
|
|
|
function canonicalizeProvider(provider) {
|
|
const normalized = (provider ?? "").trim().toLowerCase();
|
|
return PROVIDER_ALIASES[normalized] ?? normalized;
|
|
}
|
|
|
|
// ----- Run corpus -----
|
|
|
|
let passed = 0;
|
|
let failed = 0;
|
|
|
|
for (const entry of corpus) {
|
|
// Skip group header entries
|
|
if (entry._group) continue;
|
|
if (!entry.expect) continue;
|
|
|
|
// resolveModelCapabilities returns camelCase keys (registryLabel, thinkingMode, etc.)
|
|
const result = resolveModelCapabilities(canonicalizeProvider(entry.provider), entry.raw_model_id);
|
|
const expect = entry.expect;
|
|
|
|
const failures = [];
|
|
|
|
for (const [key, expectedVal] of Object.entries(expect)) {
|
|
// Corpus uses snake_case; generated TS uses camelCase — convert for lookup.
|
|
const camelKey = key.replace(/_([a-z])/g, (_, c) => c.toUpperCase());
|
|
const actualVal = camelKey in result ? result[camelKey] : result[key];
|
|
|
|
if (Array.isArray(expectedVal)) {
|
|
// Order-sensitive comparison for effort arrays
|
|
const actualArr = Array.isArray(actualVal) ? actualVal : [];
|
|
if (JSON.stringify(actualArr) !== JSON.stringify(expectedVal)) {
|
|
failures.push(
|
|
` ${key}: expected [${expectedVal.join(", ")}] got [${actualArr.join(", ")}]`,
|
|
);
|
|
}
|
|
} else {
|
|
if (actualVal !== expectedVal) {
|
|
failures.push(` ${key}: expected ${JSON.stringify(expectedVal)} got ${JSON.stringify(actualVal)}`);
|
|
}
|
|
}
|
|
}
|
|
|
|
if (failures.length === 0) {
|
|
passed++;
|
|
if (VERBOSE) {
|
|
console.log(` PASS ${entry.id}`);
|
|
}
|
|
} else {
|
|
failed++;
|
|
console.error(` FAIL ${entry.id} (${entry.provider} / "${entry.raw_model_id}")`);
|
|
for (const f of failures) console.error(f);
|
|
if (entry._note) console.error(` note: ${entry._note}`);
|
|
}
|
|
}
|
|
|
|
console.log(`\nCorpus: ${passed} passed, ${failed} failed`);
|
|
process.exit(failed > 0 ? 1 : 0);
|