mirror of https://github.com/block/buzz.git synced 2026-08-18 06:50:31 +02:00

Files

T

npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7andWill Pfleger 78b4e84415 fix(desktop): pass-2 corrections C1-C5 (generation checks, fail-closed migrations, atomic drain, import drain protocol, boot migration strip)

C1: Remove #[allow(dead_code)] from WorkspaceAgentScope owner_pubkey and generation
fields; add validate_scope_generation() production helper; restore Phase B uses
captured scope relay (not live relay_ws_url_with_override); Phase C validates
generation before acquiring store lock and terminates stale-spawn children.

C2: run_scoped_migrations returns Result<(), String> propagating first failure;
ensure_scope_ready withholds _ready on Err; added Step 10 JSON validation gate;
fixed crash-resume test fixture to use valid JSON; added migration-failure test
that verifies no _ready on corrupt input, then repair+retry writes _ready.

C3: (Already committed as 3325363bc.) Transition lock held continuously from
drain through commit.

C4: drain_managed_agent_runtimes_for_import returns Result<Vec<DrainJournalEntry>>;
import_identity acquires managed_agent_runtime_transition lock for live-active path;
drain failure compensates and returns Err before identity persist; persist failure
compensates stopped entries and returns Err; removed commit_active_scope from
identity_storage.rs.

C5: run_boot_migrations_inner stripped of all definition-touching steps (now in
scoped pipeline); backfill_persona_snapshots_at added and called in prepare stage;
legacy retention migration moved to prepare stage; try_regenerate_nest removed from
lib.rs boot (now post-commit in workspace.rs); managed_agent_restore_pending field
and write removed from AppState and lib.rs.

Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>

2026-08-03 02:40:16 -04:00