mirror of
https://github.com/block/buzz.git
synced 2026-08-18 06:50:31 +02:00
kind:30176 team events serialized persona_ids with
skip_serializing_if = Vec::is_empty and instructions with
skip_serializing_if = Option::is_none, making 'old/predates-field client
omitted the field' and 'client explicitly emptied it' byte-identical on
the wire. apply_inbound_team blindly overwrote both fields on every
inbound event, so a single empty publisher propagated to every other
device and wiped team membership/instructions fleet-wide (the Sietch
Tabr incident).
- persona_ids: Vec<String> -> Option<Vec<String>>, mirroring the
agent_pubkeys fix on the unmerged tommy/agents-first-agent-pubkeys-optional
branch (b91ac88d3). None = publisher predates always-publish (unknown,
preserve local); Some(vec![]) = explicit clear. New clients always
publish Some, even when empty.
- instructions: Option<String> -> Option<Option<String>> (double-Option,
via the existing crate::util::double_option helper) for the same
reason, using the tri-state absent/null/value shape: absent = preserve
local, null = explicit clear, string = set.
- apply_inbound_team overwrites local only on Some; None preserves
local. Fresh inserts unwrap_or_default().
persona_ids is wrapped even though the prior-art commit argued the
unwrapped field's omission always means genuinely empty: that reasoning
does not hold on main because skip_serializing_if = Vec::is_empty makes
every shipped client also omit it when empty, so omission is
structurally ambiguous. The Sietch Tabr wipe is the field evidence.
Always-publishing changes the serialized projection, so every team
re-publishes once via retention content-hash mismatch on next save.
Benign — same tradeoff the agent_pubkeys prior art accepted.
Co-authored-by: Will Pfleger <pfleger.will@gmail.com>
Signed-off-by: Will Pfleger <pfleger.will@gmail.com>
Buzz
Desktop chat shell with:
- Tauri + React + TypeScript + Vite
- Tailwind CSS
- shadcn/ui-ready shared components
- Biome (lint/format/check)
- Feature-driven frontend structure
Scripts
pnpm dev- run the web frontendpnpm tauri dev- run the desktop apppnpm build- typecheck and build frontendpnpm typecheck- TypeScript checkspnpm lint- Biome lintpnpm format- Biome format (write)pnpm check- Biome check
Structure
src/shared- reusable app-wide code (ui,lib,styles)src/features- feature modules (vertical slices)src/app- top-level app composition