mirror of
https://github.com/block/buzz.git
synced 2026-08-18 06:50:31 +02:00
## Summary
- add poster-first, tap-to-toggle animated avatars on profile surfaces
while preserving transparent/static behavior elsewhere
- align mobile DM headers, membership actions, and invisible agent
recipient addressing with established desktop semantics
- polish titled sheets and status editing, preserve native iOS sheet
corners, and batch relay reads to improve review-build responsiveness
## Snapshots
<table>
<tr>
<th>Profile avatar</th>
<th>Agent DM header and composer</th>
</tr>
<tr>
<td><img
src="https://raw.githubusercontent.com/block/buzz/e8de7495451dbe1a393ab43c5e204ca7425f2ba5/pr-5401--profile-avatar.png"
width="360" alt="Mobile profile settings with animated avatar
surface"></td>
<td><img
src="https://raw.githubusercontent.com/block/buzz/e8de7495451dbe1a393ab43c5e204ca7425f2ba5/pr-5401--agent-dm.png"
width="360" alt="Agent direct message with masked presence and normal
composer"></td>
</tr>
<tr>
<th>Members sheet</th>
<th>Status editor</th>
</tr>
<tr>
<td><img
src="https://raw.githubusercontent.com/block/buzz/e8de7495451dbe1a393ab43c5e204ca7425f2ba5/pr-5401--members-sheet.png"
width="360" alt="Members bottom sheet with centered title and padded
content"></td>
<td><img
src="https://raw.githubusercontent.com/block/buzz/e8de7495451dbe1a393ab43c5e204ca7425f2ba5/pr-5401--status-sheet.png"
width="360" alt="Status editor bottom sheet with duration and quick
statuses"></td>
</tr>
<tr>
<th colspan="2">Switch Community</th>
</tr>
<tr>
<td colspan="2" align="center"><img
src="https://raw.githubusercontent.com/block/buzz/e8de7495451dbe1a393ab43c5e204ca7425f2ba5/pr-5401--switch-community.png"
width="720" alt="Switch Community bottom sheet with centered title and
aligned Edit action"></td>
</tr>
</table>
## Validation
- `just mobile-check`
- `just mobile-test` (1,283 tests)
- installed and reviewed isolated debug builds on iPhone and Pixel
---------
Signed-off-by: kenny lopez <klopez4212@gmail.com>
Signed-off-by: Princess Donut <b238ea756dee4d98afa5883fc7f1de61eeabe65bf700e3a5a5a80db5e42e2c2b@buzz.block.builderlab.xyz>
Signed-off-by: Kenny Lopez <klopez4212@gmail.com>
Signed-off-by: Wes <wesbillman@users.noreply.github.com>
Co-authored-by: Princess Donut <b238ea756dee4d98afa5883fc7f1de61eeabe65bf700e3a5a5a80db5e42e2c2b@buzz.block.builderlab.xyz>
Co-authored-by: Wes <wesbillman@users.noreply.github.com>
Co-authored-by: Carl <c7ebe626f000404285d3686e1dc74cc07cc60a9754a150041ba132e14bd3e2ec@buzz.block.builderlab.xyz>
359 lines
12 KiB
Dart
359 lines
12 KiB
Dart
import 'package:buzz/shared/widgets/concentric_sheet_surface.dart';
|
|
import 'package:buzz/shared/theme/theme.dart';
|
|
import 'package:buzz/shared/widgets/modal_presentation.dart';
|
|
import 'package:flutter/foundation.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter/rendering.dart';
|
|
import 'package:flutter/services.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
|
|
void main() {
|
|
testWidgets(
|
|
'keeps an opaque Flutter surface when iOS native support is unavailable',
|
|
(tester) async {
|
|
debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
|
|
try {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: AppTheme.light(),
|
|
home: const ConcentricSheetSurface(
|
|
enabled: true,
|
|
color: Colors.red,
|
|
child: SizedBox(height: 80, child: Text('Sheet body')),
|
|
),
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(
|
|
find.byWidgetPredicate(
|
|
(widget) => widget is Material && widget.color == Colors.red,
|
|
),
|
|
findsOneWidget,
|
|
);
|
|
final contentClip = tester.widget<ClipRSuperellipse>(
|
|
find.byKey(const ValueKey('concentric-sheet-content-clip')),
|
|
);
|
|
expect(contentClip.borderRadius, BorderRadius.circular(Radii.dialog));
|
|
} finally {
|
|
debugDefaultTargetPlatformOverride = null;
|
|
}
|
|
},
|
|
);
|
|
|
|
testWidgets(
|
|
'replaces the Flutter fallback when native support is available',
|
|
(tester) async {
|
|
debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
|
|
const surfaceChannel = MethodChannel('buzz/concentric_sheet_surface');
|
|
tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(
|
|
surfaceChannel,
|
|
(call) async => call.method == 'isSupported' ? true : null,
|
|
);
|
|
try {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: AppTheme.light(),
|
|
home: const ConcentricSheetSurface(
|
|
enabled: true,
|
|
color: Colors.red,
|
|
child: SizedBox(height: 80, child: Text('Sheet body')),
|
|
),
|
|
),
|
|
);
|
|
await tester.pump();
|
|
|
|
expect(find.byType(UiKitView), findsOneWidget);
|
|
expect(
|
|
find.byWidgetPredicate(
|
|
(widget) => widget is Material && widget.color == Colors.red,
|
|
),
|
|
findsNothing,
|
|
);
|
|
} finally {
|
|
tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(
|
|
surfaceChannel,
|
|
null,
|
|
);
|
|
debugDefaultTargetPlatformOverride = null;
|
|
}
|
|
},
|
|
);
|
|
|
|
testWidgets('native titled sheets leave the concentric surface unobscured', (
|
|
tester,
|
|
) async {
|
|
debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
|
|
const surfaceChannel = MethodChannel('buzz/concentric_sheet_surface');
|
|
tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(
|
|
surfaceChannel,
|
|
(call) async => call.method == 'isSupported' ? true : null,
|
|
);
|
|
try {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: AppTheme.light(),
|
|
home: Scaffold(
|
|
body: Builder(
|
|
builder: (context) => FilledButton(
|
|
onPressed: () => showBuzzModalBottomSheet<void>(
|
|
context: context,
|
|
title: 'Members',
|
|
builder: (_) => const Text('Sheet body'),
|
|
),
|
|
child: const Text('Open sheet'),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
await tester.tap(find.text('Open sheet'));
|
|
await tester.pumpAndSettle();
|
|
|
|
final nativeSurface = tester.widget<UiKitView>(find.byType(UiKitView));
|
|
expect(
|
|
nativeSurface.creationParams,
|
|
containsPair('color', lightColorScheme.surface.toARGB32()),
|
|
);
|
|
expect(nativeSurface.creationParams, isNot(contains('headerGradient')));
|
|
expect(
|
|
find.byKey(const ValueKey('buzz-sheet-header-gradient')),
|
|
findsNothing,
|
|
);
|
|
expect(
|
|
find.byKey(const ValueKey('buzz-sheet-surface-clip')),
|
|
findsNothing,
|
|
);
|
|
final contentClip = tester.widget<ClipRSuperellipse>(
|
|
find.byKey(const ValueKey('concentric-sheet-content-clip')),
|
|
);
|
|
expect(contentClip.borderRadius, BorderRadius.circular(Radii.dialog * 2));
|
|
expect(contentClip.clipBehavior, Clip.antiAlias);
|
|
expect(find.text('Members'), findsOneWidget);
|
|
} finally {
|
|
tester.binding.defaultBinaryMessenger.setMockMethodCallHandler(
|
|
surfaceChannel,
|
|
null,
|
|
);
|
|
debugDefaultTargetPlatformOverride = null;
|
|
}
|
|
});
|
|
|
|
testWidgets(
|
|
'non-iOS sheets use Flutter drag handle and shared close control',
|
|
(tester) async {
|
|
debugDefaultTargetPlatformOverride = TargetPlatform.android;
|
|
try {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: AppTheme.light(),
|
|
home: Scaffold(
|
|
body: Builder(
|
|
builder: (context) => FilledButton(
|
|
onPressed: () => showBuzzModalBottomSheet<void>(
|
|
context: context,
|
|
title: 'Sheet title',
|
|
showDragHandle: true,
|
|
builder: (_) => const Text('Sheet body'),
|
|
),
|
|
child: const Text('Open sheet'),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
await tester.tap(find.text('Open sheet'));
|
|
await tester.pumpAndSettle();
|
|
|
|
final closeButton = find.byTooltip('Close sheet');
|
|
final title = find.byKey(const ValueKey('buzz-sheet-title'));
|
|
expect(closeButton, findsOneWidget);
|
|
expect(title, findsOneWidget);
|
|
expect(
|
|
find.byKey(const ValueKey('buzz-sheet-surface-clip')),
|
|
findsOneWidget,
|
|
);
|
|
expect(tester.getSize(closeButton), const Size.square(44));
|
|
expect(tester.widget<Text>(title).style?.fontSize, 16);
|
|
expect(
|
|
find.byKey(const ValueKey('buzz-sheet-header-gradient')),
|
|
findsNothing,
|
|
);
|
|
expect(
|
|
tester
|
|
.widget<ColoredBox>(
|
|
find.byKey(const ValueKey('buzz-sheet-surface')),
|
|
)
|
|
.color,
|
|
lightColorScheme.surface,
|
|
);
|
|
expect(
|
|
tester.getTopLeft(find.text('Sheet body')).dy -
|
|
tester
|
|
.getTopLeft(find.byKey(const ValueKey('buzz-sheet-surface')))
|
|
.dy,
|
|
80,
|
|
);
|
|
expect(find.byType(BackdropFilter), findsNothing);
|
|
expect(
|
|
tester.widget<BottomSheet>(find.byType(BottomSheet)).backgroundColor,
|
|
Colors.transparent,
|
|
);
|
|
expect(
|
|
tester.getCenter(title).dx,
|
|
closeTo(tester.getCenter(find.byType(BottomSheet)).dx, 0.01),
|
|
);
|
|
expect(
|
|
tester.getCenter(title).dy,
|
|
closeTo(tester.getCenter(closeButton).dy, 0.01),
|
|
);
|
|
expect(
|
|
tester.getCenter(closeButton).dx,
|
|
greaterThan(tester.getCenter(title).dx),
|
|
);
|
|
final closeGutter = find.ancestor(
|
|
of: closeButton,
|
|
matching: find.byWidgetPredicate(
|
|
(widget) =>
|
|
widget is Padding &&
|
|
widget.padding ==
|
|
const EdgeInsets.only(
|
|
top: Grid.xxs,
|
|
left: Grid.gutter,
|
|
right: Grid.gutter,
|
|
bottom: Grid.xs,
|
|
),
|
|
),
|
|
);
|
|
expect(closeGutter, findsOneWidget);
|
|
final gutterRect = tester.getRect(closeGutter);
|
|
final closeRect = tester.getRect(closeButton);
|
|
expect(closeRect.top - gutterRect.top, Grid.gutter);
|
|
expect(gutterRect.right - closeRect.right, Grid.gutter);
|
|
expect(
|
|
tester.widget<BottomSheet>(find.byType(BottomSheet)).showDragHandle,
|
|
isFalse,
|
|
);
|
|
expect(
|
|
find.byKey(const ValueKey('buzz-sheet-drag-handle')),
|
|
findsOneWidget,
|
|
);
|
|
expect(
|
|
tester.getTopLeft(closeButton).dy -
|
|
tester.getTopLeft(find.byType(BottomSheet)).dy,
|
|
Grid.gutter,
|
|
);
|
|
final dismissHandle = find.bySemanticsLabel('Dismiss').first;
|
|
expect(dismissHandle, findsOneWidget);
|
|
final semantics = tester.getSemantics(dismissHandle);
|
|
expect(semantics.flagsCollection.isButton, isTrue);
|
|
expect(
|
|
semantics.getSemanticsData().hasAction(SemanticsAction.tap),
|
|
isTrue,
|
|
);
|
|
tester.binding.performSemanticsAction(
|
|
SemanticsActionEvent(
|
|
type: SemanticsAction.tap,
|
|
viewId: tester.view.viewId,
|
|
nodeId: semantics.id,
|
|
),
|
|
);
|
|
await tester.pumpAndSettle();
|
|
expect(find.text('Sheet body'), findsNothing);
|
|
} finally {
|
|
debugDefaultTargetPlatformOverride = null;
|
|
}
|
|
},
|
|
);
|
|
|
|
testWidgets('iOS paints the drag handle inside the concentric surface', (
|
|
tester,
|
|
) async {
|
|
debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
|
|
try {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: AppTheme.light(),
|
|
home: Scaffold(
|
|
body: Builder(
|
|
builder: (context) => FilledButton(
|
|
onPressed: () => showBuzzModalBottomSheet<void>(
|
|
context: context,
|
|
showDragHandle: true,
|
|
builder: (_) => const Text('Sheet body'),
|
|
),
|
|
child: const Text('Open sheet'),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
await tester.tap(find.text('Open sheet'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(
|
|
tester.widget<BottomSheet>(find.byType(BottomSheet)).showDragHandle,
|
|
isFalse,
|
|
);
|
|
final internalHandle = find.byKey(
|
|
const ValueKey('buzz-sheet-drag-handle'),
|
|
);
|
|
expect(internalHandle, findsOneWidget);
|
|
expect(tester.getSize(internalHandle), const Size(32, 4));
|
|
final dismissHandle = find.bySemanticsLabel('Dismiss');
|
|
expect(dismissHandle, findsOneWidget);
|
|
final semantics = tester.getSemantics(dismissHandle);
|
|
expect(semantics.flagsCollection.isButton, isTrue);
|
|
expect(
|
|
semantics.getSemanticsData().hasAction(SemanticsAction.tap),
|
|
isTrue,
|
|
);
|
|
expect(find.byTooltip('Close sheet'), findsOneWidget);
|
|
expect(find.text('Sheet body'), findsOneWidget);
|
|
} finally {
|
|
debugDefaultTargetPlatformOverride = null;
|
|
}
|
|
});
|
|
|
|
testWidgets('iOS compact sheets can omit X but retain the inside handle', (
|
|
tester,
|
|
) async {
|
|
debugDefaultTargetPlatformOverride = TargetPlatform.iOS;
|
|
try {
|
|
await tester.pumpWidget(
|
|
MaterialApp(
|
|
theme: AppTheme.light(),
|
|
home: Scaffold(
|
|
body: Builder(
|
|
builder: (context) => FilledButton(
|
|
onPressed: () => showBuzzModalBottomSheet<void>(
|
|
context: context,
|
|
showDragHandle: true,
|
|
showCloseButton: false,
|
|
builder: (_) => const Text('Compact sheet body'),
|
|
),
|
|
child: const Text('Open compact sheet'),
|
|
),
|
|
),
|
|
),
|
|
),
|
|
);
|
|
|
|
await tester.tap(find.text('Open compact sheet'));
|
|
await tester.pumpAndSettle();
|
|
|
|
expect(
|
|
find.byKey(const ValueKey('buzz-sheet-drag-handle')),
|
|
findsOneWidget,
|
|
);
|
|
expect(find.byTooltip('Close sheet'), findsNothing);
|
|
expect(find.text('Compact sheet body'), findsOneWidget);
|
|
} finally {
|
|
debugDefaultTargetPlatformOverride = null;
|
|
}
|
|
});
|
|
}
|