mirror of
https://github.com/block/buzz.git
synced 2026-08-18 06:50:31 +02:00
Will Pfleger
8cb00b37a3
Four issues from Thufir's review: 1. Remove mtime short-circuit — directory mtime doesn't change when files inside subdirectories are edited, so the cache silently suppressed the most common developer action (editing a .persona.md). Always call resolve_pack() for correctness. 2. Defer load_managed_agents() to removal path only — restructured sync_packs_from_dir to take a lazy loader closure. First pass computes all diffs; managed_agents.json is only read if removals are detected. Common case (additions/updates only) never touches the file. 3. Remove double directory scan — eliminated the has_symlinked_packs pre-scan in the wrapper. sync_packs_from_dir handles the no-symlinks case naturally in a single read_dir pass. 4. env_vars always empty for pack personas — removed goose_env_vars sync from UPDATE and ADD paths. Matches import_persona_pack() behavior; GOOSE_PROVIDER/GOOSE_MODEL are projected at launch time.