mirror of
https://github.com/block/buzz.git
synced 2026-08-18 06:50:31 +02:00
**Category:** new-feature **User Impact:** Mobile now keeps each community’s appearance in sync with desktop, including theme, accent, and system-mode preference. **Problem:** Appearance choices were device-local, so the same account could look different between desktop and mobile. Live sync could also stop after the relay closed a subscription. **Solution:** Store each community’s encrypted appearance preference on its relay using the shared desktop wire contract, restore it from a local identity-scoped cache, and apply replacement events live. Closed subscriptions now recover with guarded backoff and fetch the latest preference so no update is lost during the gap. <details> <summary>File changes</summary> **mobile/lib/app.dart** Connects community appearance state to the authenticated app lifecycle. **mobile/lib/features/settings/accent_picker_page.dart** Aligns mobile accent choices and selection behavior with the shared catalog. **mobile/lib/features/settings/settings_page/appearance_section.dart** Clarifies the active appearance and hides accent controls when the Buzz theme owns its neutral accent. **mobile/lib/features/settings/theme_picker_page.dart** Persists catalog theme choices through the community-scoped provider. **mobile/lib/shared/theme/accent_colors.dart** Matches desktop’s accent catalog and wire values. **mobile/lib/shared/theme/buzz_theme.dart** Keeps Buzz visually neutral without discarding the user’s stored accent for other themes. **mobile/lib/shared/theme/community_theme_preference.dart** Defines and validates the versioned desktop-compatible appearance payload. **mobile/lib/shared/theme/community_theme_provider.dart** Coordinates cache-first appearance loading with account and community changes. **mobile/lib/shared/theme/community_theme_sync.dart** Adds encrypted NIP-78 relay persistence, live replacement handling, deterministic ordering, safe seeding, and resilient subscription recovery. **mobile/lib/shared/theme/theme.dart** Exports the community appearance modules. **mobile/test/features/settings/theme_picker_page_test.dart** Covers the updated settings behavior. **mobile/test/shared/crypto/nip44_interop_test.dart** Proves Dart decrypts a desktop-produced nostr-rs NIP-44 v2 preference. **mobile/test/shared/theme/buzz_theme_test.dart** Covers Buzz’s neutral rendering and stored-accent restoration. **mobile/test/shared/theme/community_theme_preference_test.dart** Covers wire parsing, validation, migration, and future-version handling. **mobile/test/shared/theme/community_theme_sync_test.dart** Covers cache/relay lifecycle, replacement ordering, switching races, absence-only seeding, and closed-subscription recovery. </details> ## Reproduction steps 1. Sign into desktop and mobile with the same account and join the same community relay. 2. On desktop, choose a distinctive non-Buzz theme and accent; mobile should update without a local toggle. 3. Restart mobile and confirm it restores the same appearance. 4. Change the mobile theme and accent and confirm desktop follows. 5. Leave mobile idle or backgrounded through a relay reconnect, then change desktop again; mobile should resubscribe and catch up automatically. 6. Switch communities and confirm each community restores only its own appearance. --------- Signed-off-by: Taylor Ho <taylorkmho@gmail.com> Co-authored-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@buzz.block.builderlab.xyz>
124 lines
3.7 KiB
Dart
124 lines
3.7 KiB
Dart
import 'dart:convert';
|
|
|
|
import 'package:buzz/shared/theme/theme.dart';
|
|
import 'package:flutter/material.dart';
|
|
import 'package:flutter_test/flutter_test.dart';
|
|
import 'package:shared_preferences/shared_preferences.dart';
|
|
|
|
void main() {
|
|
test('desktop v1 payload round-trips exactly', () {
|
|
final preference = CommunityThemePreference.fromJson({
|
|
'version': 1,
|
|
'theme': 'github-dark',
|
|
'accent': '#c0a2f1',
|
|
'followSystem': false,
|
|
});
|
|
|
|
expect(preference.mode, ThemeMode.dark);
|
|
expect(
|
|
jsonEncode(preference.toJson()),
|
|
'{"version":1,"theme":"github-dark","accent":"#c0a2f1","followSystem":false}',
|
|
);
|
|
});
|
|
|
|
test('rejects unknown themes, accents, and future versions', () {
|
|
for (final payload in [
|
|
{
|
|
'version': 2,
|
|
'theme': 'buzz',
|
|
'accent': '#3b82f6',
|
|
'followSystem': true,
|
|
},
|
|
{
|
|
'version': 1,
|
|
'theme': 'unknown',
|
|
'accent': '#3b82f6',
|
|
'followSystem': true,
|
|
},
|
|
{
|
|
'version': 1,
|
|
'theme': 'buzz',
|
|
'accent': '#000000',
|
|
'followSystem': true,
|
|
},
|
|
]) {
|
|
expect(
|
|
() => CommunityThemePreference.fromJson(payload),
|
|
throwsFormatException,
|
|
);
|
|
}
|
|
});
|
|
|
|
test('storage is scoped by pubkey and normalized relay URL', () async {
|
|
SharedPreferences.setMockInitialValues({});
|
|
final prefs = await SharedPreferences.getInstance();
|
|
final storage = CommunityThemeStorage(prefs);
|
|
const a = CommunityThemePreference(
|
|
theme: 'buzz',
|
|
accent: '#3b82f6',
|
|
followSystem: true,
|
|
);
|
|
const b = CommunityThemePreference(
|
|
theme: 'dracula',
|
|
accent: '#ef4444',
|
|
followSystem: false,
|
|
);
|
|
|
|
await storage.write('pk', 'WSS://Relay.Example///', a);
|
|
await storage.write('pk', 'wss://other.example', b);
|
|
|
|
expect(storage.read('pk', 'wss://relay.example'), a);
|
|
expect(storage.read('pk', 'wss://other.example/'), b);
|
|
expect(storage.read('other-pk', 'wss://relay.example'), isNull);
|
|
});
|
|
|
|
test('dirty outbox survives restart and clears only exact ack', () async {
|
|
SharedPreferences.setMockInitialValues({});
|
|
final prefs = await SharedPreferences.getInstance();
|
|
final storage = CommunityThemeStorage(prefs);
|
|
const pending = CommunityThemePreference(
|
|
theme: 'dracula',
|
|
accent: '#ef4444',
|
|
followSystem: false,
|
|
);
|
|
const newer = CommunityThemePreference(
|
|
theme: 'houston',
|
|
accent: '#a855f7',
|
|
followSystem: false,
|
|
);
|
|
|
|
await storage.writeOutbox('pk', 'wss://relay.example', pending);
|
|
expect(
|
|
CommunityThemeStorage(prefs).readOutbox('pk', 'wss://relay.example'),
|
|
pending,
|
|
);
|
|
await storage.writeOutbox('pk', 'wss://relay.example', newer);
|
|
await storage.clearOutbox('pk', 'wss://relay.example', pending);
|
|
expect(storage.readOutbox('pk', 'wss://relay.example'), newer);
|
|
await storage.clearOutbox('pk', 'wss://relay.example', newer);
|
|
expect(storage.readOutbox('pk', 'wss://relay.example'), isNull);
|
|
});
|
|
|
|
test('legacy accent indexes migrate without inventing wire values', () async {
|
|
SharedPreferences.setMockInitialValues({
|
|
'buzz_theme_mode': 'dark',
|
|
'buzz_color_scheme': 'dracula',
|
|
'buzz_accent_color': 8,
|
|
});
|
|
final prefs = await SharedPreferences.getInstance();
|
|
final preference = CommunityThemeStorage(prefs).legacyPreference();
|
|
|
|
expect(
|
|
preference,
|
|
const CommunityThemePreference(
|
|
theme: 'dracula',
|
|
accent: 'neutral',
|
|
followSystem: false,
|
|
),
|
|
);
|
|
expect(preference.mode, ThemeMode.dark);
|
|
expect(legacyAccentWireValue(6), '#a855f7');
|
|
expect(legacyAccentWireValue(7), '#6366f1');
|
|
});
|
|
}
|