mirror of
https://github.com/block/buzz.git
synced 2026-08-18 06:50:31 +02:00
Taylor HoandGitHub
d8281b9c93
**Category:** new-feature **User Impact:** Mobile users must confirm with Face ID, biometrics, or their device passcode before sending their Buzz identity to Desktop. **Problem:** A signed-in phone could send its full identity, including the `nsec`, to a desktop without fresh local verification. **Solution:** Require OS device authentication before opening the identity-recovery scanner, retain that authorization only for the active pairing session and short pairing window, and require fresh authentication again if it expires before the identity payload is sent. Normal app opening, identity import, and community removal remain unchanged. ## Screencasts | Enable Face ID | Use Face ID | | --- | --- | |  |  | <details> <summary>File changes</summary> **Android and iOS integration** - `mobile/android/app/build.gradle.kts` declares the AppCompat dependency required by the biometric activity theme. - `mobile/android/app/src/main/kotlin/xyz/block/buzz/mobile/MainActivity.kt` uses the activity type required by the system authentication prompt. - `mobile/android/app/src/main/res/values/styles.xml` and `mobile/android/app/src/main/res/values-night/styles.xml` use the compatible launch theme. - `mobile/ios/Podfile.lock` records the native local-authentication dependency. - `mobile/ios/Runner/Info.plist` explains why Buzz requests Face ID access. **Identity policy and pairing flow** - `mobile/lib/shared/security/sensitive_action_authorizer.dart` wraps OS authentication and maps platform errors to stable app-level outcomes. - `mobile/lib/shared/community/community.dart` and `mobile/lib/shared/community/community_storage.dart` persist the sensitive-action policy. - `mobile/lib/features/invites/invite_join_provider.dart` assigns the explicit policy for invite-created communities. - `mobile/lib/features/pairing/pairing_provider.dart` gates export, binds grants to the active community/session, reauthenticates expired grants, and clears grants on every terminal path. - `mobile/lib/features/pairing/pairing_page.dart` lets users choose biometric protection while importing an identity. - `mobile/lib/features/settings/settings_page.dart` wires pairing into settings. - `mobile/lib/features/settings/settings_page/connection_section.dart` authenticates before opening export recovery and bounds the foreground-resume wait. - `mobile/pubspec.yaml` and `mobile/pubspec.lock` add and lock `local_auth`. **Coverage** - `mobile/test/shared/security/sensitive_action_authorizer_test.dart` covers native result mapping, unsupported devices, and single-flight behavior. - `mobile/test/shared/community/community_test.dart` and `mobile/test/shared/community/community_storage_test.dart` cover policy defaults and persistence. - `mobile/test/features/invites/invite_join_provider_test.dart` covers the invite policy. - `mobile/test/features/pairing/pairing_page_test.dart` covers import protection controls. - `mobile/test/features/pairing/pairing_provider_test.dart` covers export/import authorization, stale/reset/concurrent guards, malformed payload cleanup, and no-export failure paths. - `mobile/test/features/settings/connection_section_test.dart` covers the tap gate, lifecycle resume, and timeout behavior. </details> ## Reproduction steps 1. Pair an identity into the mobile app. 2. Open Settings and choose “Send identity to desktop.” 3. Verify Face ID, biometrics, or the device passcode is required before the recovery scanner opens. 4. Cancel device authentication and verify the scanner does not open and no identity transfer begins. 5. Authenticate, scan a Desktop recovery code, confirm the SAS, and verify the identity transfer completes. ## Validation At `be5620f5f10aa6cc16e86a4f01f102f3d9aeef9b`: - `cd mobile && ../bin/flutter analyze` — no issues - `cd mobile && ../bin/flutter test` — 1,368 tests passed - `cd mobile/android && JAVA_HOME=$(/usr/libexec/java_home -v 21) ./gradlew app:assembleDebug` — debug APK assembled successfully --------- Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
119 lines
4.3 KiB
Plaintext
119 lines
4.3 KiB
Plaintext
PODS:
|
|
- app_badge_plus (1.2.10):
|
|
- Flutter
|
|
- app_links (6.4.1):
|
|
- Flutter
|
|
- camera_avfoundation (0.0.1):
|
|
- Flutter
|
|
- connectivity_plus (0.0.1):
|
|
- Flutter
|
|
- file_selector_ios (0.0.1):
|
|
- Flutter
|
|
- Flutter (1.0.0)
|
|
- flutter_secure_storage_darwin (10.0.0):
|
|
- Flutter
|
|
- FlutterMacOS
|
|
- image_picker_ios (0.0.1):
|
|
- Flutter
|
|
- local_auth_darwin (0.0.1):
|
|
- Flutter
|
|
- FlutterMacOS
|
|
- mobile_scanner (7.0.0):
|
|
- Flutter
|
|
- FlutterMacOS
|
|
- open_filex (0.0.2):
|
|
- Flutter
|
|
- package_info_plus (0.4.5):
|
|
- Flutter
|
|
- photo_manager (3.11.0):
|
|
- Flutter
|
|
- FlutterMacOS
|
|
- share_plus (0.0.1):
|
|
- Flutter
|
|
- shared_preferences_foundation (0.0.1):
|
|
- Flutter
|
|
- FlutterMacOS
|
|
- url_launcher_ios (0.0.1):
|
|
- Flutter
|
|
- video_player_avfoundation (0.0.1):
|
|
- Flutter
|
|
- FlutterMacOS
|
|
|
|
DEPENDENCIES:
|
|
- app_badge_plus (from `.symlinks/plugins/app_badge_plus/ios`)
|
|
- app_links (from `.symlinks/plugins/app_links/ios`)
|
|
- camera_avfoundation (from `.symlinks/plugins/camera_avfoundation/ios`)
|
|
- connectivity_plus (from `.symlinks/plugins/connectivity_plus/ios`)
|
|
- file_selector_ios (from `.symlinks/plugins/file_selector_ios/ios`)
|
|
- Flutter (from `Flutter`)
|
|
- flutter_secure_storage_darwin (from `.symlinks/plugins/flutter_secure_storage_darwin/darwin`)
|
|
- image_picker_ios (from `.symlinks/plugins/image_picker_ios/ios`)
|
|
- local_auth_darwin (from `.symlinks/plugins/local_auth_darwin/darwin`)
|
|
- mobile_scanner (from `.symlinks/plugins/mobile_scanner/darwin`)
|
|
- open_filex (from `.symlinks/plugins/open_filex/ios`)
|
|
- package_info_plus (from `.symlinks/plugins/package_info_plus/ios`)
|
|
- photo_manager (from `.symlinks/plugins/photo_manager/darwin`)
|
|
- share_plus (from `.symlinks/plugins/share_plus/ios`)
|
|
- shared_preferences_foundation (from `.symlinks/plugins/shared_preferences_foundation/darwin`)
|
|
- url_launcher_ios (from `.symlinks/plugins/url_launcher_ios/ios`)
|
|
- video_player_avfoundation (from `.symlinks/plugins/video_player_avfoundation/darwin`)
|
|
|
|
EXTERNAL SOURCES:
|
|
app_badge_plus:
|
|
:path: ".symlinks/plugins/app_badge_plus/ios"
|
|
app_links:
|
|
:path: ".symlinks/plugins/app_links/ios"
|
|
camera_avfoundation:
|
|
:path: ".symlinks/plugins/camera_avfoundation/ios"
|
|
connectivity_plus:
|
|
:path: ".symlinks/plugins/connectivity_plus/ios"
|
|
file_selector_ios:
|
|
:path: ".symlinks/plugins/file_selector_ios/ios"
|
|
Flutter:
|
|
:path: Flutter
|
|
flutter_secure_storage_darwin:
|
|
:path: ".symlinks/plugins/flutter_secure_storage_darwin/darwin"
|
|
image_picker_ios:
|
|
:path: ".symlinks/plugins/image_picker_ios/ios"
|
|
local_auth_darwin:
|
|
:path: ".symlinks/plugins/local_auth_darwin/darwin"
|
|
mobile_scanner:
|
|
:path: ".symlinks/plugins/mobile_scanner/darwin"
|
|
open_filex:
|
|
:path: ".symlinks/plugins/open_filex/ios"
|
|
package_info_plus:
|
|
:path: ".symlinks/plugins/package_info_plus/ios"
|
|
photo_manager:
|
|
:path: ".symlinks/plugins/photo_manager/darwin"
|
|
share_plus:
|
|
:path: ".symlinks/plugins/share_plus/ios"
|
|
shared_preferences_foundation:
|
|
:path: ".symlinks/plugins/shared_preferences_foundation/darwin"
|
|
url_launcher_ios:
|
|
:path: ".symlinks/plugins/url_launcher_ios/ios"
|
|
video_player_avfoundation:
|
|
:path: ".symlinks/plugins/video_player_avfoundation/darwin"
|
|
|
|
SPEC CHECKSUMS:
|
|
app_badge_plus: 09939f19a075cc742cc155d8ed85e6d8601f0104
|
|
app_links: 3dbc685f76b1693c66a6d9dd1e9ab6f73d97dc0a
|
|
camera_avfoundation: 968a9a5323c79a99c166ad9d7866bfd2047b5a9b
|
|
connectivity_plus: cb623214f4e1f6ef8fe7403d580fdad517d2f7dd
|
|
file_selector_ios: ec57ec07954363dd730b642e765e58f199bb621a
|
|
Flutter: cabc95a1d2626b1b06e7179b784ebcf0c0cde467
|
|
flutter_secure_storage_darwin: acdb3f316ed05a3e68f856e0353b133eec373a23
|
|
image_picker_ios: e0ece4aa2a75771a7de3fa735d26d90817041326
|
|
local_auth_darwin: c3ee6cce0a8d56be34c8ccb66ba31f7f180aaebb
|
|
mobile_scanner: 9157936403f5a0644ca3779a38ff8404c5434a93
|
|
open_filex: 432f3cd11432da3e39f47fcc0df2b1603854eff1
|
|
package_info_plus: af8e2ca6888548050f16fa2f1938db7b5a5df499
|
|
photo_manager: 6ab48c2ce7ec21aa06d59e6cc049f0b6d9ba7f94
|
|
share_plus: 50da8cb520a8f0f65671c6c6a99b3617ed10a58a
|
|
shared_preferences_foundation: 7036424c3d8ec98dfe75ff1667cb0cd531ec82bb
|
|
url_launcher_ios: 7a95fa5b60cc718a708b8f2966718e93db0cef1b
|
|
video_player_avfoundation: dd410b52df6d2466a42d28550e33e4146928280a
|
|
|
|
PODFILE CHECKSUM: bd29822c3d5baf6b44b726f00ea3293a19339ef2
|
|
|
|
COCOAPODS: 1.16.2
|