Files
buzz/mobile/test/features/activity/compose_drafts_provider_test.dart
9d36778c37 feat(mobile): refactor Activity behavior and ui (#2889)
**Category:** improvement
**User Impact:** Mobile users can scan Activity as a focused
conversation inbox and open the exact unread message or thread
represented by each item.

## Context

Mobile's Activity tab had not kept pace with Desktop: it presented
isolated event headlines, advertised categories that were often empty,
and opened a channel without clearly landing on the selected item.

This PR brings the Mobile surface toward the conversation-oriented
direction explored in Clay Delk's Desktop [Inbox refactor PR
#2045](https://github.com/block/buzz/pull/2045), while adapting it to
Mobile rather than copying the Desktop split-pane implementation. The
related product/UX discussion is captured in the originating [Buzz
thread](buzz://message?channel=a9bbc0e5-d25d-4740-849c-93c34bb578a4&id=a7d9a4d33dcd8c6bf0dc67d81c328892b9e38dedaa8548920224ef388301b6ab).

## UX decisions in this PR

- **Conversation-oriented, not event-oriented:** related updates
collapse into one row per thread/DM conversation, represented by the
latest update and ordered by latest activity. Separate top-level
conversations in the same channel remain separate rows.
- **Resume at the oldest unread:** tapping a grouped row opens the
represented canonical message/thread/DM at its oldest unread item,
rather than merely opening the channel at an arbitrary position.
- **Desktop-aligned row hierarchy:** rows lead with a full avatar and
sender, followed by contextual location/type metadata, unread dot +
time, and a two-line preview. A **New** boundary separates unread and
read content.
- **Mobile-native navigation:** Mobile keeps a single-column `Activity →
canonical conversation → Back` flow. It does not introduce Desktop's
persistent detail pane.
- **Compact filtering:** the old horizontal chip rail becomes a compact
filter menu so the source set fits a phone viewport without horizontal
scanning. Filters are All, Mentions, Threads, Needs Action, Activity,
Agents, Reminders, and Drafts.
- **Focused source semantics:** All covers personally relevant work—DMs,
mentions, thread replies, needs-action events, owned-agent activity, due
reminders, and active drafts—rather than becoming a generic stream of
every channel message. Mobile's standalone Activity source is currently
limited to DM traffic because it does not have Desktop's aggregated
channel-activity feed.
- **Shared read behavior:** rows project canonical
channel/thread/message markers, support unread-only and mark-all-read,
and use local overrides only where canonical markers cannot represent an
item.
- **Reminders and drafts are real data:** reminders use the same
encrypted NIP-ER events as Desktop. Drafts persist device-local composer
state, restore on return, survive failed sends, and clear after
successful sends.
- **Explain navigation failures:** an unavailable destination produces
an explanatory message rather than silently doing nothing or falling
back to an unrelated channel position.

## Implementation summary

- Adds a Mobile inbox model for conversation grouping, category
priority, contextual labels, sorting, filtering, and oldest-unread
targets.
- Expands relay-backed sources for mentions, approvals, owned-agent
lifecycle events, and DM traffic.
- Adds fail-closed NIP-ER reminder decryption and device-local
compose-draft persistence.
- Redesigns Activity rows, boundaries, filters, unread controls, and
empty/loading states.
- Routes rows through Mobile's existing canonical channel/thread screens
with precise target IDs.
- Adds model, provider, widget, reminder, read-state, draft-lifecycle,
and deep-link coverage.

## Reproduction steps

1. Run Mobile and open **Activity**.
2. Confirm full avatars, sender-first rows, context labels, unread
indicators, timestamps, two-line previews, and the compact filter
control.
3. Open the filter menu and verify All, Mentions, Threads, Needs Action,
Activity, Agents, Reminders, and Drafts.
4. Tap a grouped thread row and confirm the canonical conversation opens
at its oldest unread message.
5. Mark rows read/unread, enable unread-only mode, and use
mark-all-read; confirm state agrees with the channel/thread destination.
6. Type without sending in a channel or thread, leave, and confirm the
draft appears in Activity and restores in the composer.

## Screenshots

| Before — merge-base `dd222a509` | After — PR head `52ad40aee` |
|---|---|
| <img width="1206" height="2622" alt="image"
src="https://github.com/user-attachments/assets/ae961b08-bf8a-4bd5-b487-f6321ae8d85b"
/> | <img width="1206" height="2622" alt="image"
src="https://github.com/user-attachments/assets/bcbe7ab0-552a-417c-9e85-7a85eb4592ee"
/> |

Recaptured on the same authenticated iPhone 17 simulator, account,
theme, and Activity view, at this PR's current merge-base (`dd222a509`)
and head (`52ad40aee`). Both frames were taken within a few minutes on
the same live feed, so the visible conversation set overlaps closely
(the recent Ned/Bart/Tommy items appear in both). The compared change is
the row *structure*: Before leads with an `@ Mention` headline over a
small inline avatar and a horizontal chip rail; After leads with a full
avatar, a compact `labelMedium` sender label, contextual "Mentioned in"
metadata, and a filter menu. The sender username now renders at the same
compact scale the old `@ Mention` label used.

## Verification

- Current rebased head: `5bd87f4f4` on `origin/main` at `dd222a509`;
GitHub reports the PR mergeable.
- `flutter analyze` — clean at `5bd87f4f4`.
- Full Mobile suite — 698 passed, 1 skipped, 4 failed; all four failures
reproduce identically on clean `origin/main` (`channels_page_test`
create-channel sheet and three `compose_bar_test` agent-mention cases).
- The prior PR-specific `home_page_test` failures were fixed by
providing the Activity local-state dependency in that harness.
- Independent code and simulator UI review — approved.
- Post-rebase GitHub checks are running.

---------

Signed-off-by: Taylor Ho <taylorkmho@gmail.com>
Signed-off-by: npub14vtk7pvazqrq9639qu7e560wnqtl0d53ca4gjuvq6jzf3k2el23qqlwa7f <ab176f059d100602ea25073d9a69ee9817f7b691c76a897180d48498d959faa2@buzz.block.builderlab.xyz>
Co-authored-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@buzz.block.builderlab.xyz>
Co-authored-by: npub14vtk7pvazqrq9639qu7e560wnqtl0d53ca4gjuvq6jzf3k2el23qqlwa7f <ab176f059d100602ea25073d9a69ee9817f7b691c76a897180d48498d959faa2@buzz.block.builderlab.xyz>
2026-07-27 16:55:24 +00:00

191 lines
6.6 KiB
Dart

import 'package:buzz/features/activity/compose_drafts_provider.dart';
import 'package:buzz/shared/relay/relay.dart';
import 'package:buzz/shared/theme/theme_provider.dart';
import 'package:flutter_test/flutter_test.dart';
import 'package:hooks_riverpod/hooks_riverpod.dart';
import 'package:shared_preferences/shared_preferences.dart';
class _FixedRelayConfigNotifier extends RelayConfigNotifier {
final RelayConfig _config;
_FixedRelayConfigNotifier(this._config);
@override
RelayConfig build() => _config;
}
void main() {
TestWidgetsFlutterBinding.ensureInitialized();
Future<ProviderContainer> containerWithPrefs({
String relayUrl = 'https://relay-a.example',
String? pubkey = 'pk_a',
}) async {
final prefs = await SharedPreferences.getInstance();
final container = ProviderContainer(
overrides: [
savedPrefsProvider.overrideWithValue(prefs),
relayConfigProvider.overrideWith(
() => _FixedRelayConfigNotifier(RelayConfig(baseUrl: relayUrl)),
),
myPubkeyProvider.overrideWithValue(pubkey),
],
);
addTearDown(container.dispose);
return container;
}
test('composeDraftKey separates channel and thread composers', () {
expect(composeDraftKey('ch1'), 'ch1');
expect(composeDraftKey('ch1', threadHeadId: 't1'), 'ch1:t1');
});
test('save adds a draft and textFor returns it', () async {
SharedPreferences.setMockInitialValues({});
final container = await containerWithPrefs();
final notifier = container.read(composeDraftsProvider.notifier);
notifier.save(key: 'ch1', channelId: 'ch1', text: 'hello there');
final drafts = container.read(composeDraftsProvider);
expect(drafts, hasLength(1));
expect(drafts.single.text, 'hello there');
expect(notifier.textFor('ch1'), 'hello there');
});
test('empty text removes the draft', () async {
SharedPreferences.setMockInitialValues({});
final container = await containerWithPrefs();
final notifier = container.read(composeDraftsProvider.notifier);
notifier.save(key: 'ch1', channelId: 'ch1', text: 'hello');
notifier.save(key: 'ch1', channelId: 'ch1', text: ' ');
expect(container.read(composeDraftsProvider), isEmpty);
});
test('drafts persist across container restarts', () async {
SharedPreferences.setMockInitialValues({});
final first = await containerWithPrefs();
first
.read(composeDraftsProvider.notifier)
.save(key: 'ch1:t1', channelId: 'ch1', threadHeadId: 't1', text: 'wip');
final second = await containerWithPrefs();
final restored = second.read(composeDraftsProvider);
expect(restored, hasLength(1));
expect(restored.single.channelId, 'ch1');
expect(restored.single.threadHeadId, 't1');
expect(restored.single.text, 'wip');
});
test('remove deletes by key', () async {
SharedPreferences.setMockInitialValues({});
final container = await containerWithPrefs();
final notifier = container.read(composeDraftsProvider.notifier);
notifier.save(key: 'ch1', channelId: 'ch1', text: 'hello');
notifier.remove('ch1');
expect(container.read(composeDraftsProvider), isEmpty);
});
test('malformed persisted json is ignored', () async {
SharedPreferences.setMockInitialValues({
'compose_drafts_v1:https://relay-a.example:pk_a': '{not valid',
});
final container = await containerWithPrefs();
expect(container.read(composeDraftsProvider), isEmpty);
});
test('drafts are isolated per community', () async {
SharedPreferences.setMockInitialValues({});
final communityA = await containerWithPrefs(
relayUrl: 'https://relay-a.example',
);
communityA
.read(composeDraftsProvider.notifier)
.save(key: 'ch1', channelId: 'ch1', text: 'secret from A');
// Same channel id in another community must not see A's draft.
final communityB = await containerWithPrefs(
relayUrl: 'https://relay-b.example',
);
expect(communityB.read(composeDraftsProvider), isEmpty);
expect(
communityB.read(composeDraftsProvider.notifier).textFor('ch1'),
isNull,
);
// A's own store is untouched.
final communityAAgain = await containerWithPrefs(
relayUrl: 'https://relay-a.example',
);
expect(
communityAAgain.read(composeDraftsProvider.notifier).textFor('ch1'),
'secret from A',
);
});
test('drafts are isolated per account pubkey', () async {
SharedPreferences.setMockInitialValues({});
final accountA = await containerWithPrefs(pubkey: 'pk_a');
accountA
.read(composeDraftsProvider.notifier)
.save(key: 'ch1', channelId: 'ch1', text: 'account A draft');
// Same relay, different account: a colliding channel id must not
// restore the other account's draft.
final accountB = await containerWithPrefs(pubkey: 'pk_b');
expect(accountB.read(composeDraftsProvider), isEmpty);
expect(
accountB.read(composeDraftsProvider.notifier).textFor('ch1'),
isNull,
);
});
test('in-place identity change rebuilds onto the new store', () async {
SharedPreferences.setMockInitialValues({});
final prefs = await SharedPreferences.getInstance();
final container = ProviderContainer(
overrides: [
savedPrefsProvider.overrideWithValue(prefs),
// Real derivation path: myPubkeyProvider derives from the config's
// nsec, so an in-place config change simulates an account/community
// switch without restarting the container.
relayConfigProvider.overrideWith(
() => _FixedRelayConfigNotifier(
const RelayConfig(baseUrl: 'https://relay-a.example'),
),
),
],
);
addTearDown(container.dispose);
// Seed a draft for the initial identity (nsec-less config → 'anon').
container
.read(composeDraftsProvider.notifier)
.save(key: 'ch1', channelId: 'ch1', text: 'first identity draft');
expect(container.read(composeDraftsProvider), hasLength(1));
// Switch community in place: the drafts provider must rebuild against
// the new identity's (empty) store, not keep the old state.
container
.read(relayConfigProvider.notifier)
.update(baseUrl: 'https://relay-b.example');
expect(container.read(composeDraftsProvider), isEmpty);
expect(
container.read(composeDraftsProvider.notifier).textFor('ch1'),
isNull,
);
// Switching back restores the original identity's draft.
container
.read(relayConfigProvider.notifier)
.update(baseUrl: 'https://relay-a.example');
expect(
container.read(composeDraftsProvider.notifier).textFor('ch1'),
'first identity draft',
);
});
}