mirror of
https://github.com/block/buzz.git
synced 2026-08-18 06:50:31 +02:00
**Category:** new-feature **User Impact:** Mobile users can copy permalinks, revisit, follow, and manage messages through a clearer long-press menu that matches desktop capabilities. **Problem:** The mobile message menu exposed only a small subset of desktop actions, and important workflows such as copying a permalink or scheduling a reminder were unavailable or hard to discover. **Solution:** Bring applicable desktop actions to mobile using native patterns, promote Reply, Copy link, and Remind me above the fold, and group the remaining actions by intent in a scrollable sheet. **Intentional behavior changes (per review):** - The quick-reaction row goes from 6 emojis to 4 (👀 and 🙏 dropped) to make room for larger 52px tap targets alongside the `+` picker, which still offers the full set. - **Copy link — not a native share sheet — is the permalink path.** An earlier revision shipped a `share_plus` Share message row; it was removed in review since Copy link covers the job and custom-scheme `buzz://` URIs are handled inconsistently by share targets. Native share can return as a follow-up with an https fallback. - Mark unread is message-scoped and session-local: it forces just that message unread (surfacing its channel as unread), and message-level Mark read can never clear a channel-level unread set from the channel tile. <details> <summary>File changes</summary> **mobile/lib/features/channels/channels_provider.dart** Feeds followed thread roots into unread and notification evaluation so following a thread has meaningful behavior. **mobile/lib/features/channels/message_actions.dart** Reworks the long-press sheet with promoted fast actions, message links, reminders, read state, thread following, and clearer action grouping while preserving existing guards. Quick-reaction circles share one extracted widget. **mobile/lib/features/channels/read_state/message_read_state.dart** Centralizes message-level unread evaluation across channel, message, and thread markers; channel-level forced unread deliberately does not leak into message state. **mobile/lib/features/channels/read_state/read_state_provider.dart** Forced-unread flags are per-context (channel id or `msg:` key) mapped to their channel, so message- and channel-level unread choices round-trip independently. **mobile/lib/features/channels/thread_follows/thread_follows_provider.dart** Exposes per-identity thread follow state to the message menu and notification pipeline. **mobile/lib/features/channels/thread_follows/thread_follows_storage.dart** Persists a bounded, validated set of followed thread roots on the device. **mobile/lib/shared/reminders/remind_me_later_sheet.dart** Adds reminder presets and a native custom date/time flow for deferring a message. Lives under `shared/` so the channels feature never imports another feature module. Cancelling the custom picker keeps the preset sheet open; submission failures show stable copy and log the underlying error. **mobile/lib/shared/reminders/reminder_service.dart** Creates desktop-compatible, self-encrypted kind-30300 reminder events. **mobile/lib/shared/reminders/reminder_time_presets.dart** Defines reminder choices that match the desktop experience. **mobile/lib/shared/deeplink/deep_link.dart** Builds canonical Buzz message links, including thread context when present. **mobile/lib/shared/relay/nostr_models.dart** Adds the reminder event kind to the shared Nostr model constants. **mobile/lib/shared/widgets/sheet_divider.dart** Shared bottom-sheet section divider used by the message actions and reminder sheets. **mobile/test/features/channels/message_actions_test.dart** Covers action visibility and guards, promoted actions, read/unread round-tripping (including channel- vs message-level force isolation), thread follows, and canonical links. **mobile/test/features/channels/read_state/message_read_state_test.dart** Covers unread precedence for channel, message, and thread contexts. **mobile/test/features/channels/thread_follows/thread_follows_storage_test.dart** Covers follow persistence, identity separation, validation, and storage bounds. **mobile/test/shared/reminders/reminder_service_test.dart** Covers reminder payloads, tags, crypto round-tripping, and preset behavior. **mobile/test/features/channels/read_state/read_state_provider_test.dart** Drives the production ReadStateNotifier/ReadStateManager (no fake bookkeeping) through message unread → read → unread round-trips, explicit channel-level Mark read clearing forced messages, and automatic channel-open reads preserving them. **mobile/test/shared/reminders/remind_me_later_sheet_test.dart** Covers custom-picker cancel keeping the sheet open, stable failure copy without the raw error, and the happy preset path. **mobile/test/shared/deeplink/deep_link_test.dart** Covers canonical top-level and threaded message-link generation. </details> ## Reproduction steps 1. Run the mobile app with a signed-in identity and open a channel containing regular messages and threads. 2. Long-press a message and confirm reactions plus Reply, Copy link, and Remind me appear as fast actions above the fold. 3. Use Copy link; confirm the resulting `buzz://message` link opens the correct channel and thread context. 4. Toggle Mark unread/Mark read and Follow thread/Unfollow thread, reopening the sheet to confirm each state changes correctly. Force a channel unread from the channel tile, then mark a message read — the channel stays unread. 5. Choose a reminder preset and a custom date/time; confirm the reminder is created and appears in the desktop reminder experience. Cancel the custom date picker and confirm the reminder sheet stays open. 6. Long-press a system message and a message you cannot manage; confirm utility and destructive actions remain appropriately hidden. ## Screenshots / demos <img width="1206" height="2622" alt="image" src="https://github.com/user-attachments/assets/81096cd6-329b-408f-bcff-712e23b268a4" /> --------- Signed-off-by: Taylor Ho <taylorkmho@gmail.com> Co-authored-by: npub1223z34hd7vtwc6qj4s7flsxkj644nlre2nthu7lrrmkumhu3xddsrx9r6w <52a228d6edf316ec6812ac3c9fc0d696ab59fc7954d77e7be31eedcddf91335b@buzz.block.builderlab.xyz>
71 lines
2.2 KiB
Dart
71 lines
2.2 KiB
Dart
/// Reminder time presets shared by the "Remind me later" sheet.
|
|
///
|
|
/// Mirrors `desktop/src/features/reminders/lib/timePresets.ts` — same labels,
|
|
/// same "always strictly in the future" guarantee.
|
|
library;
|
|
|
|
class ReminderTimePreset {
|
|
final String label;
|
|
final int Function() getTimestamp;
|
|
|
|
const ReminderTimePreset({required this.label, required this.getTimestamp});
|
|
}
|
|
|
|
int _nowSeconds() => DateTime.now().millisecondsSinceEpoch ~/ 1000;
|
|
|
|
/// Next occurrence of [dayOffset] days from now at 9am local time. If that
|
|
/// instant is already past, roll to the following day so the result is
|
|
/// always in the future.
|
|
int nextDayAt9am(int dayOffset, {DateTime? now}) {
|
|
final current = now ?? DateTime.now();
|
|
var target = DateTime(
|
|
current.year,
|
|
current.month,
|
|
current.day + dayOffset,
|
|
9,
|
|
);
|
|
if (!target.isAfter(current)) {
|
|
target = DateTime(target.year, target.month, target.day + 1, 9);
|
|
}
|
|
return target.millisecondsSinceEpoch ~/ 1000;
|
|
}
|
|
|
|
/// Days until next Monday (1-7), matching the desktop preset semantics.
|
|
int daysUntilNextMonday(DateTime now) {
|
|
final days = (DateTime.monday - now.weekday) % 7;
|
|
return days == 0 ? 7 : days;
|
|
}
|
|
|
|
final List<ReminderTimePreset> reminderTimePresets = [
|
|
ReminderTimePreset(
|
|
label: 'In 30 minutes',
|
|
getTimestamp: () => _nowSeconds() + 30 * 60,
|
|
),
|
|
ReminderTimePreset(
|
|
label: 'In 1 hour',
|
|
getTimestamp: () => _nowSeconds() + 60 * 60,
|
|
),
|
|
ReminderTimePreset(
|
|
label: 'In 3 hours',
|
|
getTimestamp: () => _nowSeconds() + 3 * 60 * 60,
|
|
),
|
|
ReminderTimePreset(
|
|
label: 'Tomorrow at 9am',
|
|
getTimestamp: () => nextDayAt9am(1),
|
|
),
|
|
ReminderTimePreset(
|
|
label: 'Next Monday at 9am',
|
|
getTimestamp: () => nextDayAt9am(daysUntilNextMonday(DateTime.now())),
|
|
),
|
|
];
|
|
|
|
/// Combine a picked date and time into a future Unix timestamp (seconds), or
|
|
/// null when the instant is not strictly in the future — the shared guard for
|
|
/// the custom picker so a past time never fires immediately.
|
|
int? combineCustomDateTime(DateTime date, int hour, int minute) {
|
|
final target = DateTime(date.year, date.month, date.day, hour, minute);
|
|
final timestamp = target.millisecondsSinceEpoch ~/ 1000;
|
|
if (timestamp <= _nowSeconds()) return null;
|
|
return timestamp;
|
|
}
|