mirror of
https://github.com/block/buzz.git
synced 2026-08-18 06:50:31 +02:00
## What Implements Phases 2 and 4a of the Usage v2 plan (plan events `d0268cd0`/`0e95b035`), extending the archive backend to emit, transport, archive, and aggregate both cache categories and billing identity fail-closed. ### P2 — emission, transport, archive **Tri-state accumulators** (`Unseen`/`Exact`/`Unknown`) for cache-read and cache-write in `buzz-agent` turn and session state. Absent field = Unknown (never zero) through the full pipeline. No `unwrap_or(0)` on the cache path. Both cache folds are gated on usage-bearing responses (same gate as the total-state and identity folds) — a response with no usage at all must not poison either accumulator. **Overflow-aware input token parsing and accumulation** — closed end-to-end from parse through wire to ACP: - `sum_usage()` returns `SumUsageResult` (`Exact(u64)` | `Overflow`) — checked arithmetic, never clamps. `anthropic_input_tokens()` returns `Option<SumUsageResult>` since it sums three fields (`input_tokens + cache_read_input_tokens + cache_creation_input_tokens`) that can collectively overflow. Single-field callers (`prompt_tokens`, `completion_tokens`, etc.) convert via `.into_exact()` — their single-field sums cannot overflow. - `LlmResponse.input_tokens_overflowed: bool` propagates the parse-layer signal into the run loop. When set, `input_tokens` is `None` (clamped value discarded), the context-gate baseline (`last_request_input_tokens`) is frozen at its prior reading, and `turn_input_tokens` is poisoned to `TurnIOState::Poisoned` before any emission — including mid-turn `emit_usage_update` calls. A dedicated enum on `LlmResponse.input_tokens` would ripple into ~20 existing test assertions on `r.input_tokens == Some(...)`; the bool flag confines the change to the two call sites that check it. - `TurnIOState` (`Unseen`/`Exact`/`Poisoned`) for input and output: per-round fold uses `checked_add`; overflow poisons permanently at turn and session level, no healing. Absence does not poison (pass-2-cleared contract unchanged). Wire emission omits `accumulatedInputTokens`/`accumulatedOutputTokens` when poisoned — never null, never `u64::MAX`. ACP treats absent = publisher-poisoned: `delta_reliable: false`, null turn fields, null cumulative for that category; session cumulative stays unknown for all subsequent turns once poisoned. **Conditional wire emission** for `accumulatedCachedInputTokens` and new `accumulatedCacheWriteTokens`: fields are omitted when the cumulative is Unseen or Unknown. ACP `_goose/unstable/session/update` contract documented next to the payload with tests for all absence/zero variants. **`PricingIdentity` stamping (publisher-side)**: - `pricing_authority()`: canonical parsed-URL endpoint comparison against the official allowlist — HTTPS only, exact allowlisted host (lookalike-safe), default port (omitted or explicit :443), required API base path, rejects userinfo/query/fragment/path-prefix lookalikes. - Model: the actually-requested `request_model` after mesh/auto resolution (not `effective_model_str`). - Turn discipline: identity retained only while ALL usage in the current turn carries one identical proven identity; any mismatch, unproven-usage-bearing response, or unpaired cumulative snapshot poisons to absent; a later matching notification does not heal a mixed turn. **ACP `UsageTracker` identity fold**: per-in-flight-turn tri-state identity accumulator replacing last-update-wins. Any absent identity on a token-advancing notification or exact mismatch poisons to absent; poison survives later updates; reset in `begin_turn()`/`take()`; reset also when a request fails (baseline cleared so preflight gate cannot stay frozen sub-threshold on retries). **M3 migration**: adds `turn_cache_write_tokens`, `cumulative_cache_write_tokens`, `pricing_authority`, `pricing_model`, `pricing_cache_class` to `agent_metric_index`. Additive, idempotent, guarded per-column by marker. M2 migration also guarded per-column (turn and cumulative cache-read columns checked and added independently; marker commits only after both are present). Fresh-DB schema includes all columns. **First-turn baselines**: `seed_zero_baseline` seeds `last_input: Some(0)`, `last_output: Some(0)`, `last_cached_input: Some(0)`, `last_cache_write: Some(0)`, and `last_total: Some(0)` — all have the known-zero-at-spawn argument. Absent fields from incoming snapshots still produce unknown (tri-state unchanged). Sessions buzz-acp did not spawn (no seed) remain fail-closed on turn one. **`ReportedUsage` TS mirror**: `cacheReadTokens`, `cacheWriteTokens`, `freshInputTokens` added to `tauriArchive.ts` as `UsageField` members, field-for-field with the Rust struct. ### P4a — aggregation layer **Extended S-1 ladder** to cache-read and cache-write via the same `ladder_token` path as the existing token fields. **`freshInputTokens` derivation**: checked arithmetic, fail-closed — absent cache fields produce Unknown (not zero), overflow and `cacheRead+cacheWrite > input` both produce `incomplete: true`. Aggregated as a `UsageField`. **D6 comparator**: `sort_value()` = provider total when known, else `input+output` when both known, else `None` (unknown-last). Replaces the prior total-only comparator for both agent-level and model-level sort. Ships a pinned test vector that the TS render layer (P5) must match. ## Test coverage - `buzz-agent`: 440 lib + 15 integration (golden_transcripts) — includes 13 new `cache_total_state_tests`; 14 new `turn_io_state_tests`; 3 new `sum_usage_*` tests (exact single-field, exact two-field, overflow signals correctly); 3 new `parse_anthropic_*` tests (overflow flag set + value cleared, normal sum no flag, absent usage no flag); end-to-end golden transcript drives real subprocess with Anthropic-shaped `input_tokens: u64::MAX, cache_read: 1` response and asserts `accumulatedInputTokens` absent from the emitted `usage_update` — no logic duplication; 3 wire pin tests; 4 `fold_pricing_identity_*` tests; `pricing_authority()` explicit-:443 acceptance - `buzz-acp`: 700 tests (691 lib + 9 integration) — 4 new usage tests (absent input → unreliable+null; absent output → unreliable+null; goose-shaped both present unchanged; poison mid-session); 3 ACP behavior tests; 7 pool lifecycle tests - Desktop (Rust): 2259+ tests — 14 new P4a pinned tests; 2 M3 round-trip tests; 1 serde key-shape test; 2 M2 partial-schema migration tests; first-turn cache round-trip test ## Related PRs - P1 NIP-AM spec: [#4632](https://github.com/block/buzz/pull/4632) - P3 pricing table: [#4629](https://github.com/block/buzz/pull/4629) - UI (P5): [#4001](https://github.com/block/buzz/pull/4001) --------- Signed-off-by: Will Pfleger <pfleger.will@gmail.com> Signed-off-by: Duncan <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz> Co-authored-by: npub1mn7jgtj4w2pd0g0zeuhxsa6jy6p0rewxz4kujt98my82ahfmp72sxjexk7 <dcfd242e557282d7a1e2cf2e6877522682f1e5c6156dc92ca7d90eaedd3b0f95@buzz.block.builderlab.xyz>
1053 lines
34 KiB
Rust
1053 lines
34 KiB
Rust
use std::collections::VecDeque;
|
|
use std::process::Stdio;
|
|
use std::sync::Arc;
|
|
use std::time::Duration;
|
|
|
|
use serde_json::{json, Value};
|
|
use tokio::io::{AsyncBufReadExt, AsyncReadExt, AsyncWriteExt, BufReader};
|
|
use tokio::net::TcpListener;
|
|
use tokio::sync::Mutex;
|
|
|
|
struct Harness {
|
|
child: tokio::process::Child,
|
|
stdin: tokio::process::ChildStdin,
|
|
stdout: BufReader<tokio::process::ChildStdout>,
|
|
next_id: i64,
|
|
}
|
|
|
|
impl Harness {
|
|
async fn spawn(extra: &[(&str, &str)]) -> Self {
|
|
let bin = env!("CARGO_BIN_EXE_buzz-agent");
|
|
let mut cmd = tokio::process::Command::new(bin);
|
|
cmd.env("BUZZ_AGENT_PROVIDER", "openai")
|
|
.env("OPENAI_COMPAT_API_KEY", "test")
|
|
.env("OPENAI_COMPAT_MODEL", "fake-model")
|
|
.env("BUZZ_AGENT_LLM_TIMEOUT_SECS", "5")
|
|
.env("BUZZ_AGENT_TOOL_TIMEOUT_SECS", "5")
|
|
.env("BUZZ_AGENT_MAX_ROUNDS", "4")
|
|
.stdin(Stdio::piped())
|
|
.stdout(Stdio::piped())
|
|
.stderr(Stdio::null())
|
|
.kill_on_drop(true);
|
|
for (k, v) in extra {
|
|
cmd.env(k, v);
|
|
}
|
|
let mut child = cmd.spawn().expect("spawn buzz-agent");
|
|
let stdin = child.stdin.take().unwrap();
|
|
let stdout = BufReader::new(child.stdout.take().unwrap());
|
|
Self {
|
|
child,
|
|
stdin,
|
|
stdout,
|
|
next_id: 1,
|
|
}
|
|
}
|
|
|
|
async fn send(&mut self, method: &str, params: Value) -> i64 {
|
|
let id = self.next_id;
|
|
self.next_id += 1;
|
|
self.write_json(json!({
|
|
"jsonrpc": "2.0", "id": id, "method": method, "params": params
|
|
}))
|
|
.await;
|
|
id
|
|
}
|
|
|
|
async fn notify(&mut self, method: &str, params: Value) {
|
|
self.write_json(json!({
|
|
"jsonrpc": "2.0", "method": method, "params": params
|
|
}))
|
|
.await;
|
|
}
|
|
|
|
async fn write_json(&mut self, msg: Value) {
|
|
let mut s = serde_json::to_string(&msg).unwrap();
|
|
s.push('\n');
|
|
self.stdin.write_all(s.as_bytes()).await.unwrap();
|
|
self.stdin.flush().await.unwrap();
|
|
}
|
|
|
|
async fn write_raw(&mut self, raw: &[u8]) {
|
|
let _ = self.stdin.write_all(raw).await;
|
|
let _ = self.stdin.flush().await;
|
|
}
|
|
|
|
async fn recv(&mut self) -> Value {
|
|
let mut line = String::new();
|
|
let n = tokio::time::timeout(Duration::from_secs(10), self.stdout.read_line(&mut line))
|
|
.await
|
|
.expect("recv timeout")
|
|
.expect("read line");
|
|
assert!(n > 0, "agent EOF");
|
|
serde_json::from_str(&line).expect("non-JSON line")
|
|
}
|
|
|
|
async fn recv_for_id(&mut self, id: i64) -> Value {
|
|
loop {
|
|
let v = self.recv().await;
|
|
if v["id"] == json!(id) {
|
|
return v;
|
|
}
|
|
}
|
|
}
|
|
|
|
async fn recv_until<F: FnMut(&Value) -> bool>(&mut self, mut pred: F) -> Value {
|
|
loop {
|
|
let v = self.recv().await;
|
|
if pred(&v) {
|
|
return v;
|
|
}
|
|
}
|
|
}
|
|
|
|
async fn shutdown(mut self) {
|
|
drop(self.stdin);
|
|
let _ = tokio::time::timeout(Duration::from_secs(2), self.child.wait()).await;
|
|
let _ = self.child.start_kill();
|
|
}
|
|
}
|
|
|
|
async fn spawn_fake_llm(responses: Vec<Value>) -> String {
|
|
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
|
|
let url = format!("http://{}", listener.local_addr().unwrap());
|
|
let queue = Arc::new(Mutex::new(VecDeque::from(responses)));
|
|
tokio::spawn(async move {
|
|
loop {
|
|
let (mut sock, _) = match listener.accept().await {
|
|
Ok(p) => p,
|
|
Err(_) => return,
|
|
};
|
|
let queue = queue.clone();
|
|
tokio::spawn(async move {
|
|
let mut buf = Vec::new();
|
|
let mut tmp = [0u8; 4096];
|
|
while !buf.windows(4).any(|w| w == b"\r\n\r\n") {
|
|
match sock.read(&mut tmp).await {
|
|
Ok(0) | Err(_) => return,
|
|
Ok(n) => buf.extend_from_slice(&tmp[..n]),
|
|
}
|
|
if buf.len() > 1_000_000 {
|
|
return;
|
|
}
|
|
}
|
|
let body = queue
|
|
.lock()
|
|
.await
|
|
.pop_front()
|
|
.unwrap_or_else(|| json!({ "error": "no canned response" }));
|
|
let body_s = serde_json::to_string(&body).unwrap();
|
|
let resp = format!(
|
|
"HTTP/1.1 200 OK\r\nContent-Length: {}\r\nConnection: close\r\n\r\n{}",
|
|
body_s.len(),
|
|
body_s,
|
|
);
|
|
let _ = sock.write_all(resp.as_bytes()).await;
|
|
let _ = sock.shutdown().await;
|
|
});
|
|
}
|
|
});
|
|
url
|
|
}
|
|
|
|
fn openai_text(content: &str) -> Value {
|
|
json!({
|
|
"id": "cc-1", "object": "chat.completion", "model": "fake-model",
|
|
"choices": [{
|
|
"index": 0,
|
|
"message": { "role": "assistant", "content": content },
|
|
"finish_reason": "stop",
|
|
}],
|
|
})
|
|
}
|
|
|
|
fn openai_tool_call(id: &str, name: &str, args: Value) -> Value {
|
|
json!({
|
|
"id": "cc-2", "object": "chat.completion", "model": "fake-model",
|
|
"choices": [{
|
|
"index": 0,
|
|
"message": {
|
|
"role": "assistant", "content": null,
|
|
"tool_calls": [{
|
|
"id": id, "type": "function",
|
|
"function": { "name": name, "arguments": args.to_string() },
|
|
}],
|
|
},
|
|
"finish_reason": "tool_calls",
|
|
}],
|
|
})
|
|
}
|
|
|
|
async fn handshake(h: &mut Harness) -> String {
|
|
let init_id = h
|
|
.send(
|
|
"initialize",
|
|
json!({ "protocolVersion": 2, "clientCapabilities": {} }),
|
|
)
|
|
.await;
|
|
let init = h.recv_for_id(init_id).await;
|
|
assert_eq!(init["result"]["protocolVersion"], 2);
|
|
assert_eq!(init["result"]["agentInfo"]["name"], "buzz-agent");
|
|
assert_eq!(
|
|
init["result"]["agentCapabilities"]["promptCapabilities"]["image"],
|
|
false
|
|
);
|
|
|
|
let new_id = h
|
|
.send("session/new", json!({ "cwd": "/tmp", "mcpServers": [] }))
|
|
.await;
|
|
let new = h.recv_for_id(new_id).await;
|
|
let sid = new["result"]["sessionId"].as_str().unwrap().to_owned();
|
|
assert!(sid.starts_with("ses_"));
|
|
sid
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_text_only_response() {
|
|
let url = spawn_fake_llm(vec![openai_text("hello back")]).await;
|
|
let mut h = Harness::spawn(&[("OPENAI_COMPAT_BASE_URL", &url)]).await;
|
|
|
|
let sid = handshake(&mut h).await;
|
|
let p = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({
|
|
"sessionId": sid,
|
|
"prompt": [{ "type": "text", "text": "hi" }],
|
|
}),
|
|
)
|
|
.await;
|
|
let result = h.recv_for_id(p).await;
|
|
assert_eq!(result["result"]["stopReason"], "end_turn");
|
|
assert!(result.get("error").is_none());
|
|
|
|
h.shutdown().await;
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_full_tool_call_transcript() {
|
|
let url = spawn_fake_llm(vec![
|
|
openai_tool_call("call_xyz", "fake__do_thing", json!({ "foo": "bar" })),
|
|
openai_text("done"),
|
|
])
|
|
.await;
|
|
let mut h = Harness::spawn(&[("OPENAI_COMPAT_BASE_URL", &url)]).await;
|
|
|
|
let sid = handshake(&mut h).await;
|
|
let p = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({
|
|
"sessionId": sid,
|
|
"prompt": [{ "type": "text", "text": "use the tool" }],
|
|
}),
|
|
)
|
|
.await;
|
|
|
|
let failed = h
|
|
.recv_until(|v| {
|
|
v.get("method") == Some(&json!("session/update"))
|
|
&& v["params"]["update"]["sessionUpdate"] == "tool_call_update"
|
|
&& v["params"]["update"]["status"] == "failed"
|
|
})
|
|
.await;
|
|
assert_eq!(failed["params"]["sessionId"], sid);
|
|
assert_eq!(failed["params"]["update"]["toolCallId"], "call_xyz");
|
|
assert_eq!(
|
|
failed["params"]["update"]["rawOutput"]["error"],
|
|
"unknown tool: fake__do_thing"
|
|
);
|
|
|
|
let final_resp = h.recv_for_id(p).await;
|
|
assert_eq!(final_resp["result"]["stopReason"], "end_turn");
|
|
|
|
h.shutdown().await;
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_permission_denied_continues() {
|
|
let url = spawn_fake_llm(vec![openai_text("ok with no tool")]).await;
|
|
let mut h = Harness::spawn(&[("OPENAI_COMPAT_BASE_URL", &url)]).await;
|
|
|
|
let sid = handshake(&mut h).await;
|
|
let p = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({
|
|
"sessionId": sid,
|
|
"prompt": [{ "type": "text", "text": "hi" }],
|
|
}),
|
|
)
|
|
.await;
|
|
let final_resp = h.recv_for_id(p).await;
|
|
assert_eq!(final_resp["result"]["stopReason"], "end_turn");
|
|
|
|
h.shutdown().await;
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_initialize_version_check() {
|
|
let url = spawn_fake_llm(vec![]).await;
|
|
let mut h = Harness::spawn(&[("OPENAI_COMPAT_BASE_URL", &url)]).await;
|
|
|
|
let id = h
|
|
.send(
|
|
"initialize",
|
|
json!({ "protocolVersion": 99, "clientCapabilities": {} }),
|
|
)
|
|
.await;
|
|
let resp = h.recv_for_id(id).await;
|
|
assert_eq!(resp["result"]["protocolVersion"], 2);
|
|
|
|
let id2 = h
|
|
.send(
|
|
"initialize",
|
|
json!({ "protocolVersion": 1, "clientCapabilities": {} }),
|
|
)
|
|
.await;
|
|
let ok = h.recv_for_id(id2).await;
|
|
assert_eq!(ok["result"]["protocolVersion"], 1);
|
|
|
|
h.shutdown().await;
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_session_new_rejects_relative_cwd() {
|
|
let url = spawn_fake_llm(vec![]).await;
|
|
let mut h = Harness::spawn(&[("OPENAI_COMPAT_BASE_URL", &url)]).await;
|
|
|
|
let _ = h
|
|
.send(
|
|
"initialize",
|
|
json!({ "protocolVersion": 1, "clientCapabilities": {} }),
|
|
)
|
|
.await;
|
|
let _ = h.recv().await;
|
|
|
|
let id = h
|
|
.send(
|
|
"session/new",
|
|
json!({ "cwd": "relative/path", "mcpServers": [] }),
|
|
)
|
|
.await;
|
|
let resp = h.recv_for_id(id).await;
|
|
assert_eq!(resp["error"]["code"], -32602);
|
|
assert!(resp["error"]["message"]
|
|
.as_str()
|
|
.unwrap()
|
|
.contains("cwd must be an absolute path"));
|
|
|
|
let id_empty = h
|
|
.send("session/new", json!({ "cwd": "", "mcpServers": [] }))
|
|
.await;
|
|
let resp = h.recv_for_id(id_empty).await;
|
|
assert_eq!(resp["error"]["code"], -32602);
|
|
|
|
h.shutdown().await;
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_malformed_json_rpc() {
|
|
let url = spawn_fake_llm(vec![]).await;
|
|
let mut h = Harness::spawn(&[("OPENAI_COMPAT_BASE_URL", &url)]).await;
|
|
|
|
h.write_raw(b"this is not json\n").await;
|
|
let v = h.recv().await;
|
|
assert_eq!(v["error"]["code"], -32700);
|
|
assert_eq!(v["id"], Value::Null);
|
|
|
|
h.write_json(json!({ "jsonrpc": "1.0", "method": "initialize", "id": 1 }))
|
|
.await;
|
|
let v = h.recv().await;
|
|
assert_eq!(v["error"]["code"], -32600);
|
|
|
|
h.write_json(json!({ "jsonrpc": "2.0" })).await;
|
|
let v = h.recv().await;
|
|
assert_eq!(v["error"]["code"], -32600);
|
|
|
|
let init_id = h
|
|
.send(
|
|
"initialize",
|
|
json!({ "protocolVersion": 1, "clientCapabilities": {} }),
|
|
)
|
|
.await;
|
|
let ok = h.recv_for_id(init_id).await;
|
|
assert_eq!(ok["result"]["protocolVersion"], 1);
|
|
|
|
let bad_id = h.send("nonsense/method", json!({})).await;
|
|
let v = h.recv_for_id(bad_id).await;
|
|
assert_eq!(v["error"]["code"], -32601);
|
|
|
|
h.shutdown().await;
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_unsupported_content_block() {
|
|
let url = spawn_fake_llm(vec![openai_text("ok")]).await;
|
|
let mut h = Harness::spawn(&[("OPENAI_COMPAT_BASE_URL", &url)]).await;
|
|
|
|
let sid = handshake(&mut h).await;
|
|
let p = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({
|
|
"sessionId": sid,
|
|
"prompt": [{ "type": "image", "data": "..." }],
|
|
}),
|
|
)
|
|
.await;
|
|
let resp = h.recv_for_id(p).await;
|
|
assert_eq!(resp["error"]["code"], -32602);
|
|
assert!(resp["error"]["message"]
|
|
.as_str()
|
|
.unwrap()
|
|
.contains("unsupported content block"));
|
|
|
|
h.shutdown().await;
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_concurrent_prompt_rejected() {
|
|
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
|
|
let url = format!("http://{}", listener.local_addr().unwrap());
|
|
tokio::spawn(async move {
|
|
let (mut sock, _) = listener.accept().await.unwrap();
|
|
let mut buf = Vec::new();
|
|
let mut tmp = [0u8; 4096];
|
|
while !buf.windows(4).any(|w| w == b"\r\n\r\n") {
|
|
let n = sock.read(&mut tmp).await.unwrap_or(0);
|
|
if n == 0 {
|
|
return;
|
|
}
|
|
buf.extend_from_slice(&tmp[..n]);
|
|
}
|
|
tokio::time::sleep(Duration::from_millis(500)).await;
|
|
let body = openai_text("done").to_string();
|
|
let resp = format!(
|
|
"HTTP/1.1 200 OK\r\nContent-Length: {}\r\nConnection: close\r\n\r\n{}",
|
|
body.len(),
|
|
body
|
|
);
|
|
let _ = sock.write_all(resp.as_bytes()).await;
|
|
let _ = sock.shutdown().await;
|
|
});
|
|
|
|
let mut h = Harness::spawn(&[("OPENAI_COMPAT_BASE_URL", &url)]).await;
|
|
let sid = handshake(&mut h).await;
|
|
|
|
let p1 = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({ "sessionId": sid, "prompt": [{"type":"text","text":"go"}] }),
|
|
)
|
|
.await;
|
|
tokio::time::sleep(Duration::from_millis(50)).await;
|
|
let p2 = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({ "sessionId": sid, "prompt": [{"type":"text","text":"again"}] }),
|
|
)
|
|
.await;
|
|
|
|
let mut p1_ok = false;
|
|
let mut p2_err = false;
|
|
for _ in 0..10 {
|
|
let v = h.recv().await;
|
|
if v["id"] == json!(p1) {
|
|
assert_eq!(v["result"]["stopReason"], "end_turn");
|
|
p1_ok = true;
|
|
} else if v["id"] == json!(p2) {
|
|
assert_eq!(v["error"]["code"], -32602);
|
|
p2_err = true;
|
|
}
|
|
if p1_ok && p2_err {
|
|
break;
|
|
}
|
|
}
|
|
assert!(p1_ok && p2_err, "expected p1=ok, p2=busy");
|
|
h.shutdown().await;
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_oversized_line_kills_agent() {
|
|
let url = spawn_fake_llm(vec![]).await;
|
|
let bin = env!("CARGO_BIN_EXE_buzz-agent");
|
|
let mut cmd = tokio::process::Command::new(bin);
|
|
cmd.env("BUZZ_AGENT_PROVIDER", "openai")
|
|
.env("OPENAI_COMPAT_API_KEY", "test")
|
|
.env("OPENAI_COMPAT_MODEL", "fake-model")
|
|
.env("OPENAI_COMPAT_BASE_URL", &url)
|
|
.env("BUZZ_AGENT_MAX_LINE_BYTES", "256")
|
|
.stdin(Stdio::piped())
|
|
.stdout(Stdio::piped())
|
|
.stderr(Stdio::null())
|
|
.kill_on_drop(true);
|
|
let mut child = cmd.spawn().unwrap();
|
|
let mut stdin = child.stdin.take().unwrap();
|
|
let big = "x".repeat(1024);
|
|
let _ = stdin.write_all(big.as_bytes()).await;
|
|
let _ = stdin.write_all(b"\n").await;
|
|
drop(stdin);
|
|
let _ = tokio::time::timeout(Duration::from_secs(5), child.wait())
|
|
.await
|
|
.expect("agent did not exit on oversized line");
|
|
}
|
|
|
|
/// Build an Anthropic Messages API response with an optional `thinking` block
|
|
/// followed by a `text` block. The `thinking` field is omitted when `None`.
|
|
fn anthropic_thinking_response(thinking: Option<&str>, text: &str) -> Value {
|
|
let mut content: Vec<Value> = Vec::new();
|
|
if let Some(t) = thinking {
|
|
content.push(json!({ "type": "thinking", "thinking": t }));
|
|
}
|
|
content.push(json!({ "type": "text", "text": text }));
|
|
json!({
|
|
"id": "msg_1",
|
|
"type": "message",
|
|
"role": "assistant",
|
|
"model": "claude-fake",
|
|
"stop_reason": "end_turn",
|
|
"content": content,
|
|
"usage": { "input_tokens": 10, "output_tokens": 5 },
|
|
})
|
|
}
|
|
|
|
/// Build an OpenAI Responses API response with a `reasoning` output item
|
|
/// (containing a single `summary_text` entry) followed by a message item.
|
|
fn responses_reasoning_response(reasoning: &str, text: &str) -> Value {
|
|
json!({
|
|
"id": "resp_1",
|
|
"status": "completed",
|
|
"output": [
|
|
{
|
|
"type": "reasoning",
|
|
"id": "rs_1",
|
|
"summary": [{ "type": "summary_text", "text": reasoning }],
|
|
},
|
|
{
|
|
"type": "message",
|
|
"id": "msg_1",
|
|
"content": [{ "type": "output_text", "text": text }],
|
|
},
|
|
],
|
|
"usage": { "input_tokens": 10 },
|
|
})
|
|
}
|
|
|
|
/// Drain all `session/update` notifications until the `session/prompt` reply
|
|
/// arrives for `prompt_id`, collecting notification payloads in order.
|
|
async fn collect_updates_until_done(h: &mut Harness, prompt_id: i64) -> Vec<Value> {
|
|
let mut updates = Vec::new();
|
|
loop {
|
|
let v = h.recv().await;
|
|
if v.get("id") == Some(&json!(prompt_id)) {
|
|
return updates;
|
|
}
|
|
if v.get("method") == Some(&json!("session/update")) {
|
|
if let Some(u) = v["params"].get("update") {
|
|
updates.push(u.clone());
|
|
}
|
|
}
|
|
}
|
|
}
|
|
|
|
/// Asserts that `agent_thought_chunk` appears in `updates` BEFORE
|
|
/// `agent_message_chunk`, and that both are present.
|
|
fn assert_thought_before_message(updates: &[Value]) {
|
|
let thought_pos = updates
|
|
.iter()
|
|
.position(|u| u["sessionUpdate"] == "agent_thought_chunk");
|
|
let message_pos = updates
|
|
.iter()
|
|
.position(|u| u["sessionUpdate"] == "agent_message_chunk");
|
|
assert!(
|
|
thought_pos.is_some(),
|
|
"expected agent_thought_chunk in updates: {updates:?}"
|
|
);
|
|
assert!(
|
|
message_pos.is_some(),
|
|
"expected agent_message_chunk in updates: {updates:?}"
|
|
);
|
|
assert!(
|
|
thought_pos.unwrap() < message_pos.unwrap(),
|
|
"agent_thought_chunk must precede agent_message_chunk, got updates: {updates:?}"
|
|
);
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_thought_chunk_emitted_before_message_chunk_anthropic() {
|
|
// Anthropic extended-thinking: the response contains a `thinking` block
|
|
// followed by a `text` block. We expect agent_thought_chunk to be emitted
|
|
// before agent_message_chunk on the wire.
|
|
let url = spawn_fake_llm(vec![anthropic_thinking_response(
|
|
Some("Let me reason about this carefully."),
|
|
"Here is my answer.",
|
|
)])
|
|
.await;
|
|
let mut h = Harness::spawn(&[
|
|
("BUZZ_AGENT_PROVIDER", "anthropic"),
|
|
("ANTHROPIC_API_KEY", "test"),
|
|
("ANTHROPIC_MODEL", "claude-fake"),
|
|
("ANTHROPIC_BASE_URL", &url),
|
|
("OPENAI_COMPAT_BASE_URL", ""),
|
|
])
|
|
.await;
|
|
|
|
let sid = handshake(&mut h).await;
|
|
let p = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({
|
|
"sessionId": sid,
|
|
"prompt": [{ "type": "text", "text": "think hard" }],
|
|
}),
|
|
)
|
|
.await;
|
|
|
|
let updates = collect_updates_until_done(&mut h, p).await;
|
|
assert_thought_before_message(&updates);
|
|
|
|
let thought = updates
|
|
.iter()
|
|
.find(|u| u["sessionUpdate"] == "agent_thought_chunk")
|
|
.unwrap();
|
|
assert_eq!(
|
|
thought["content"]["text"],
|
|
"Let me reason about this carefully."
|
|
);
|
|
|
|
let message = updates
|
|
.iter()
|
|
.find(|u| u["sessionUpdate"] == "agent_message_chunk")
|
|
.unwrap();
|
|
assert_eq!(message["content"]["text"], "Here is my answer.");
|
|
|
|
h.shutdown().await;
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_thought_chunk_emitted_before_message_chunk_responses_api() {
|
|
// OpenAI Responses API: reasoning item followed by message item.
|
|
// Setting OPENAI_COMPAT_API=responses forces the Responses API parse path.
|
|
let url = spawn_fake_llm(vec![responses_reasoning_response(
|
|
"Thinking step by step.",
|
|
"Final answer.",
|
|
)])
|
|
.await;
|
|
let mut h = Harness::spawn(&[
|
|
("BUZZ_AGENT_PROVIDER", "openai"),
|
|
("OPENAI_COMPAT_API_KEY", "test"),
|
|
("OPENAI_COMPAT_MODEL", "fake-model"),
|
|
("OPENAI_COMPAT_API", "responses"),
|
|
("OPENAI_COMPAT_BASE_URL", &url),
|
|
])
|
|
.await;
|
|
|
|
let sid = handshake(&mut h).await;
|
|
let p = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({
|
|
"sessionId": sid,
|
|
"prompt": [{ "type": "text", "text": "reason it out" }],
|
|
}),
|
|
)
|
|
.await;
|
|
|
|
let updates = collect_updates_until_done(&mut h, p).await;
|
|
assert_thought_before_message(&updates);
|
|
|
|
let thought = updates
|
|
.iter()
|
|
.find(|u| u["sessionUpdate"] == "agent_thought_chunk")
|
|
.unwrap();
|
|
assert_eq!(thought["content"]["text"], "Thinking step by step.");
|
|
|
|
let message = updates
|
|
.iter()
|
|
.find(|u| u["sessionUpdate"] == "agent_message_chunk")
|
|
.unwrap();
|
|
assert_eq!(message["content"]["text"], "Final answer.");
|
|
|
|
h.shutdown().await;
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_thought_chunk_emitted_before_message_chunk_chat_completions_reasoning_content() {
|
|
// OpenAI chat/completions path with DeepSeek-style `reasoning_content` field
|
|
// on the message object. OPENAI_COMPAT_API defaults to Auto, which routes
|
|
// non-openai.com hosts to chat/completions — this is the live path for
|
|
// self-hosted reasoning models (DeepSeek, vLLM, etc.).
|
|
let response = json!({
|
|
"id": "cc-r1", "object": "chat.completion", "model": "fake-model",
|
|
"choices": [{
|
|
"index": 0,
|
|
"message": {
|
|
"role": "assistant",
|
|
"content": "Here is the answer.",
|
|
"reasoning_content": "Let me think through this step by step.",
|
|
},
|
|
"finish_reason": "stop",
|
|
}],
|
|
});
|
|
let url = spawn_fake_llm(vec![response]).await;
|
|
let mut h = Harness::spawn(&[("OPENAI_COMPAT_BASE_URL", &url)]).await;
|
|
|
|
let sid = handshake(&mut h).await;
|
|
let p = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({
|
|
"sessionId": sid,
|
|
"prompt": [{ "type": "text", "text": "solve it" }],
|
|
}),
|
|
)
|
|
.await;
|
|
|
|
let updates = collect_updates_until_done(&mut h, p).await;
|
|
assert_thought_before_message(&updates);
|
|
|
|
let thought = updates
|
|
.iter()
|
|
.find(|u| u["sessionUpdate"] == "agent_thought_chunk")
|
|
.unwrap();
|
|
assert_eq!(
|
|
thought["content"]["text"],
|
|
"Let me think through this step by step."
|
|
);
|
|
|
|
let message = updates
|
|
.iter()
|
|
.find(|u| u["sessionUpdate"] == "agent_message_chunk")
|
|
.unwrap();
|
|
assert_eq!(message["content"]["text"], "Here is the answer.");
|
|
|
|
h.shutdown().await;
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_no_reasoning_no_thought_chunk() {
|
|
// Plain text response with no reasoning content — no agent_thought_chunk
|
|
// should appear on the wire. This guards against empty thought emissions.
|
|
let url = spawn_fake_llm(vec![openai_text("just text, no thinking")]).await;
|
|
let mut h = Harness::spawn(&[("OPENAI_COMPAT_BASE_URL", &url)]).await;
|
|
|
|
let sid = handshake(&mut h).await;
|
|
let p = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({
|
|
"sessionId": sid,
|
|
"prompt": [{ "type": "text", "text": "hi" }],
|
|
}),
|
|
)
|
|
.await;
|
|
|
|
let updates = collect_updates_until_done(&mut h, p).await;
|
|
|
|
let has_thought = updates
|
|
.iter()
|
|
.any(|u| u["sessionUpdate"] == "agent_thought_chunk");
|
|
assert!(
|
|
!has_thought,
|
|
"expected no agent_thought_chunk for a plain text response, got: {updates:?}"
|
|
);
|
|
|
|
let has_message = updates
|
|
.iter()
|
|
.any(|u| u["sessionUpdate"] == "agent_message_chunk");
|
|
assert!(has_message, "expected agent_message_chunk in updates");
|
|
|
|
h.shutdown().await;
|
|
}
|
|
|
|
/// An Anthropic Messages API response whose inclusive input sum overflows u64.
|
|
/// `input_tokens: u64::MAX` + `cache_read_input_tokens: 1` → overflow.
|
|
/// buzz-agent must emit a `usage_update` notification with `accumulatedInputTokens`
|
|
/// **absent** (never null, never u64::MAX) and `accumulatedOutputTokens` present.
|
|
fn anthropic_input_overflow_response() -> Value {
|
|
json!({
|
|
"id": "msg_overflow",
|
|
"type": "message",
|
|
"role": "assistant",
|
|
"model": "claude-fake",
|
|
"stop_reason": "end_turn",
|
|
"content": [{ "type": "text", "text": "overflow" }],
|
|
"usage": {
|
|
"input_tokens": u64::MAX,
|
|
"cache_read_input_tokens": 1,
|
|
"output_tokens": 7,
|
|
},
|
|
})
|
|
}
|
|
|
|
/// Collect every frame that arrives before the frame matching `pred`, then
|
|
/// return (frames_before, matching_frame). Used to inspect notifications
|
|
/// emitted before a specific response.
|
|
async fn drain_until<F>(h: &mut Harness, mut pred: F) -> (Vec<Value>, Value)
|
|
where
|
|
F: FnMut(&Value) -> bool,
|
|
{
|
|
let mut before = Vec::new();
|
|
loop {
|
|
let v = h.recv().await;
|
|
if pred(&v) {
|
|
return (before, v);
|
|
}
|
|
before.push(v);
|
|
}
|
|
}
|
|
|
|
/// When the Anthropic parser produces an input-sum overflow, buzz-agent must
|
|
/// omit `accumulatedInputTokens` from the `_goose/unstable/session/update`
|
|
/// `usage_update` notification — never null, never u64::MAX — while still
|
|
/// emitting `accumulatedOutputTokens` normally.
|
|
///
|
|
/// This is an end-to-end regression test: the canned response flows through
|
|
/// parse_anthropic → run loop → wire emission via the real production code
|
|
/// with no logic duplication.
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_anthropic_input_overflow_omits_accumulated_input_tokens() {
|
|
let url = spawn_fake_llm(vec![anthropic_input_overflow_response()]).await;
|
|
let mut h = Harness::spawn(&[
|
|
("BUZZ_AGENT_PROVIDER", "anthropic"),
|
|
("ANTHROPIC_API_KEY", "test"),
|
|
("ANTHROPIC_MODEL", "claude-fake"),
|
|
("ANTHROPIC_BASE_URL", &url),
|
|
("OPENAI_COMPAT_BASE_URL", ""),
|
|
])
|
|
.await;
|
|
|
|
let sid = handshake(&mut h).await;
|
|
let p = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({
|
|
"sessionId": sid,
|
|
"prompt": [{ "type": "text", "text": "overflow test" }],
|
|
}),
|
|
)
|
|
.await;
|
|
|
|
let (frames, final_resp) = drain_until(&mut h, |v| v.get("id") == Some(&json!(p))).await;
|
|
assert_eq!(
|
|
final_resp["result"]["stopReason"], "end_turn",
|
|
"turn must complete normally despite input overflow"
|
|
);
|
|
|
|
// Find the usage_update notification emitted before the response.
|
|
let usage = frames
|
|
.iter()
|
|
.find(|v| {
|
|
v.get("method") == Some(&json!("_goose/unstable/session/update"))
|
|
&& v["params"]["update"]["sessionUpdate"] == "usage_update"
|
|
})
|
|
.unwrap_or_else(|| {
|
|
panic!(
|
|
"expected _goose/unstable/session/update usage_update before response; frames: {frames:#?}"
|
|
)
|
|
});
|
|
|
|
let update = &usage["params"]["update"];
|
|
|
|
// Core regression: input overflow → accumulatedInputTokens ABSENT.
|
|
// A present value (even u64::MAX) would mean the saturated clamped sum
|
|
// leaked through the parse layer as an exact reading.
|
|
assert!(
|
|
update.get("accumulatedInputTokens").is_none(),
|
|
"accumulatedInputTokens must be absent when input sum overflows; got: {:?}",
|
|
update.get("accumulatedInputTokens")
|
|
);
|
|
|
|
// Output tokens are unaffected by the input overflow and must still emit.
|
|
assert_eq!(
|
|
update["accumulatedOutputTokens"],
|
|
json!(7u64),
|
|
"accumulatedOutputTokens must be present and exact despite input overflow"
|
|
);
|
|
|
|
h.shutdown().await;
|
|
}
|
|
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_cancel_notification_no_reply() {
|
|
let listener = TcpListener::bind("127.0.0.1:0").await.unwrap();
|
|
let url = format!("http://{}", listener.local_addr().unwrap());
|
|
tokio::spawn(async move {
|
|
let (mut sock, _) = listener.accept().await.unwrap();
|
|
let mut buf = Vec::new();
|
|
let mut tmp = [0u8; 4096];
|
|
while !buf.windows(4).any(|w| w == b"\r\n\r\n") {
|
|
let n = sock.read(&mut tmp).await.unwrap_or(0);
|
|
if n == 0 {
|
|
return;
|
|
}
|
|
buf.extend_from_slice(&tmp[..n]);
|
|
}
|
|
tokio::time::sleep(Duration::from_millis(800)).await;
|
|
let body = openai_text("done").to_string();
|
|
let resp = format!(
|
|
"HTTP/1.1 200 OK\r\nContent-Length: {}\r\nConnection: close\r\n\r\n{}",
|
|
body.len(),
|
|
body
|
|
);
|
|
let _ = sock.write_all(resp.as_bytes()).await;
|
|
let _ = sock.shutdown().await;
|
|
});
|
|
|
|
let mut h = Harness::spawn(&[("OPENAI_COMPAT_BASE_URL", &url)]).await;
|
|
let sid = handshake(&mut h).await;
|
|
|
|
let p = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({ "sessionId": sid, "prompt": [{"type":"text","text":"go"}] }),
|
|
)
|
|
.await;
|
|
tokio::time::sleep(Duration::from_millis(50)).await;
|
|
h.notify("session/cancel", json!({ "sessionId": sid }))
|
|
.await;
|
|
|
|
let final_resp = h.recv_for_id(p).await;
|
|
let stop = final_resp["result"]["stopReason"].as_str().unwrap_or("");
|
|
assert!(
|
|
stop == "cancelled" || stop == "end_turn",
|
|
"unexpected stopReason {stop}"
|
|
);
|
|
|
|
h.shutdown().await;
|
|
}
|
|
|
|
/// ACP v2 ContentChunk compliance: both `agent_thought_chunk` and
|
|
/// `agent_message_chunk` must carry `messageId` and `content` when the
|
|
/// client negotiates protocol version 2.
|
|
///
|
|
/// ACP v2 requires `ContentChunk.messageId` (required in v2 schema at
|
|
/// agentclientprotocol/agent-client-protocol schema/v2/schema.json @d13d1baa).
|
|
/// ACP v1 allows the field, so adding it is backwards-safe.
|
|
///
|
|
/// Additional invariants verified here:
|
|
/// - The thought and assistant message IDs are **distinct** (two logical messages).
|
|
/// - IDs do **not** recur across two consecutive `session/prompt` calls in the same
|
|
/// ACP session (`run_id` is fresh per prompt, so no cross-turn collision).
|
|
#[tokio::test(flavor = "multi_thread", worker_threads = 2)]
|
|
async fn test_acp_v2_chunks_carry_message_id() {
|
|
// OpenAI Responses API: reasoning item + text item. Both emitted chunks
|
|
// must have messageId + content on a v2 connection.
|
|
// Two responses so we can send two session/prompt calls and verify no ID reuse.
|
|
let url = spawn_fake_llm(vec![
|
|
responses_reasoning_response("Thinking about it.", "Here is my response."),
|
|
responses_reasoning_response("Thinking again.", "Second response."),
|
|
])
|
|
.await;
|
|
let mut h = Harness::spawn(&[
|
|
("BUZZ_AGENT_PROVIDER", "openai"),
|
|
("OPENAI_COMPAT_API_KEY", "test"),
|
|
("OPENAI_COMPAT_MODEL", "fake-model"),
|
|
("OPENAI_COMPAT_API", "responses"),
|
|
("OPENAI_COMPAT_BASE_URL", &url),
|
|
])
|
|
.await;
|
|
|
|
let sid = handshake(&mut h).await; // negotiates protocolVersion: 2
|
|
|
|
// ── First prompt ──────────────────────────────────────────────────────────
|
|
let p1 = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({
|
|
"sessionId": sid,
|
|
"prompt": [{ "type": "text", "text": "think and respond" }],
|
|
}),
|
|
)
|
|
.await;
|
|
let updates1 = collect_updates_until_done(&mut h, p1).await;
|
|
|
|
let thought1 = updates1
|
|
.iter()
|
|
.find(|u| u["sessionUpdate"] == "agent_thought_chunk")
|
|
.expect("agent_thought_chunk must be emitted on prompt 1");
|
|
let message1 = updates1
|
|
.iter()
|
|
.find(|u| u["sessionUpdate"] == "agent_message_chunk")
|
|
.expect("agent_message_chunk must be emitted on prompt 1");
|
|
|
|
// ACP v2 ContentChunk compliance: messageId must be present and non-empty.
|
|
let thought_id1 = thought1["messageId"]
|
|
.as_str()
|
|
.expect("agent_thought_chunk must carry messageId (ACP v2 required field)");
|
|
assert!(
|
|
!thought_id1.is_empty(),
|
|
"agent_thought_chunk messageId must not be empty"
|
|
);
|
|
|
|
let message_id1 = message1["messageId"]
|
|
.as_str()
|
|
.expect("agent_message_chunk must carry messageId (ACP v2 required field)");
|
|
assert!(
|
|
!message_id1.is_empty(),
|
|
"agent_message_chunk messageId must not be empty"
|
|
);
|
|
|
|
// Thought and assistant message are two distinct logical messages — their IDs must differ.
|
|
assert_ne!(
|
|
thought_id1, message_id1,
|
|
"agent_thought_chunk and agent_message_chunk are distinct logical messages; their messageIds must differ"
|
|
);
|
|
|
|
// content must be present and correct.
|
|
assert_eq!(
|
|
thought1["content"]["text"], "Thinking about it.",
|
|
"thought content mismatch"
|
|
);
|
|
assert_eq!(
|
|
message1["content"]["text"], "Here is my response.",
|
|
"message content mismatch"
|
|
);
|
|
|
|
// ── Second prompt (same ACP session) ─────────────────────────────────────
|
|
let p2 = h
|
|
.send(
|
|
"session/prompt",
|
|
json!({
|
|
"sessionId": sid,
|
|
"prompt": [{ "type": "text", "text": "think again" }],
|
|
}),
|
|
)
|
|
.await;
|
|
let updates2 = collect_updates_until_done(&mut h, p2).await;
|
|
|
|
let thought2 = updates2
|
|
.iter()
|
|
.find(|u| u["sessionUpdate"] == "agent_thought_chunk")
|
|
.expect("agent_thought_chunk must be emitted on prompt 2");
|
|
let message2 = updates2
|
|
.iter()
|
|
.find(|u| u["sessionUpdate"] == "agent_message_chunk")
|
|
.expect("agent_message_chunk must be emitted on prompt 2");
|
|
|
|
let thought_id2 = thought2["messageId"]
|
|
.as_str()
|
|
.expect("agent_thought_chunk must carry messageId on prompt 2");
|
|
let message_id2 = message2["messageId"]
|
|
.as_str()
|
|
.expect("agent_message_chunk must carry messageId on prompt 2");
|
|
|
|
// IDs from prompt 2 must be distinct from each other.
|
|
assert_ne!(
|
|
thought_id2, message_id2,
|
|
"prompt 2: thought and message IDs must differ"
|
|
);
|
|
|
|
// IDs must NOT recur across prompts — ACP requires session-unique messageIds.
|
|
assert_ne!(
|
|
thought_id1, thought_id2,
|
|
"thought messageId must not recur across session/prompt calls (run_id must differ)"
|
|
);
|
|
assert_ne!(
|
|
message_id1, message_id2,
|
|
"message messageId must not recur across session/prompt calls (run_id must differ)"
|
|
);
|
|
|
|
h.shutdown().await;
|
|
}
|