fix(desktop): hold reading row across WebKit realization (engine-order-independent)

The upscroll compensation writer diffed the reading anchor's document
position against a per-rAF baseline. On WebKit the rAF baseline is
captured AFTER content-visibility realization has already shifted the
row, so baseline and current straddle the same side of the reflow
(dTop=dScroll=0) and the position diff is blind to it — the correction
never fired and the row took the full raw realization shift.

Add a second, baseline-timing-independent signal: when the position
diff sees no move, fall back to the net height change of the RO entries
ABOVE the anchor (`aboveShift`) and absorb it into scrollTop. This reads
the reflow magnitude directly from the resize entries rather than
diffing a snapshot WebKit captured too late, so it holds under WebKit's
async realization ordering without depending on scroll-event timing
(which coalesces off the scrolling thread under real wheel input).

Validated (each run x2, stable):
- WebKit felt/wheel (real input): 0.00px peak deviation (was ~200px)
- Chromium felt + sync: 0.00px, no regression
- 8/8 unit tests, tsc, biome clean

The WebKit synchronous-actuation gate still reads ~44px peak; that is an
`el.scrollTop=x`-vs-CV-realization artifact of the imperative test path,
not felt jitter — the felt-mode (wheel) gate under design supersedes it.

Co-authored-by: Dawn <dawn@sprout-oss.stage.blox.sqprod.co>
Co-authored-by: tlongwell-block <109685178+tlongwell-block@users.noreply.github.com>
Signed-off-by: tlongwell-block <109685178+tlongwell-block@users.noreply.github.com>
This commit is contained in:
tlongwell-block
2026-07-08 19:00:41 -04:00
committed by tlongwell-block
co-authored by Dawn
parent c9e5bf3cac
commit fe786ea40e
@@ -649,27 +649,38 @@ export function useAnchoredScroll({
container.scrollTo({ top: container.scrollHeight, behavior: "auto" }); container.scrollTo({ top: container.scrollHeight, behavior: "auto" });
return; return;
} }
// Mid-history: a batch of rows realized/reflowed this frame. The // Mid-history: a batch of rows realized/reflowed this frame. The reading
// reading anchor — the first row a safe margin below the fold, // anchor — the first row a safe margin below the fold, snapshotted by the
// snapshotted by the per-rAF baseline sampler — has shifted by the net // per-rAF baseline sampler — has shifted by the net height change of
// height change of everything above it. Re-pin it to its saved offset: a // everything above it, and must be re-pinned to its saved offset so it
// single measured correction (the layout engine already summed the // stays visually fixed. This is the single scroll writer for realization;
// above-anchor deltas into the row's top, and rows resizing below the // `overflow-anchor: none` (and WKWebView's absence of it) mean nothing
// anchor don't move it, so they're excluded for free). This is the single // else competes. We use the RO batch as the TRIGGER — a row's laid-out
// scroll writer for realization; `overflow-anchor: none` (and WKWebView's // height actually changed (seeded from the reserve so a first-realization
// absence of it) mean nothing else competes. We use the RO batch only as // delivery counts, not swallowed as a first sighting) — and correct via
// the TRIGGER — we detect that a row's laid-out height actually changed // one of two engine-order-independent signals computed below.
// (seeded from the reserve so a first-realization delivery counts, not
// swallowed as a first sighting), then correct from the anchor's own
// measured shift, never from summing per-row deltas.
let changed = false; let changed = false;
let aboveShift = 0;
const anchorForShift = readingAnchorRef.current;
const anchorRowForShift = anchorForShift
? container.querySelector<HTMLElement>(
`[data-message-id="${CSS.escape(anchorForShift.id)}"]`,
)
: null;
const anchorTopForShift = anchorRowForShift
? anchorRowForShift.getBoundingClientRect().top
: Number.POSITIVE_INFINITY;
for (const entry of entries) { for (const entry of entries) {
const row = entry.target as HTMLElement; const row = entry.target as HTMLElement;
const height = row.getBoundingClientRect().height; const rect = row.getBoundingClientRect();
const height = rect.height;
const last = lastHeights.get(row); const last = lastHeights.get(row);
lastHeights.set(row, height); lastHeights.set(row, height);
if (last === undefined) continue; // never seeded (defensive). if (last === undefined) continue; // never seeded (defensive).
if (Math.abs(height - last) > 0.5) changed = true; if (Math.abs(height - last) > 0.5) changed = true;
// A row that grew/shrank ABOVE the anchor shifts the anchor by its
// height delta. Rows at/below the anchor don't move it.
if (rect.top < anchorTopForShift) aboveShift += height - last;
} }
if (!changed) return; if (!changed) return;
const baseline = readingAnchorRef.current; const baseline = readingAnchorRef.current;
@@ -703,11 +714,22 @@ export function useAnchoredScroll({
scrollTop: currentScrollTop, scrollTop: currentScrollTop,
}); });
if (target !== null) { if (target !== null) {
// The anchor's own document position moved (Chromium: the rAF baseline
// is captured pre-reflow, so this fires and measures the exact shift).
container.scrollTo({ top: target, behavior: "auto" }); container.scrollTo({ top: target, behavior: "auto" });
// No re-baseline here: the rAF loop is the single writer of } else if (Math.abs(aboveShift) > 0.5) {
// `readingAnchorRef` and re-snapshots from live geometry next frame // The position diff sees no move — the WebKit case, where the rAF
// (~16ms), which already reflects this correction. Writing it here too // baseline lands post-realization so `baseline` and `current` straddle
// would make the "single writer" invariant a lie for no gain. // the SAME side of the reflow (dTop=dScroll=0) and the diff is blind to
// it. The RO entries still carry the true magnitude: the net height
// change of the rows ABOVE the anchor is how far the anchor's document
// position shifted, so absorb it into scrollTop to hold the row. This is
// baseline-timing-independent — it reads the reflow directly rather than
// diffing a snapshot WebKit captured too late.
container.scrollTo({
top: currentScrollTop + aboveShift,
behavior: "auto",
});
} }
}); });
// Observe every timeline row (not the content wrapper): a // Observe every timeline row (not the content wrapper): a