From dcd558910d988636086c9134c014dde51194fd54 Mon Sep 17 00:00:00 2001 From: Taylor Ho Date: Mon, 8 Jun 2026 10:49:06 -0700 Subject: [PATCH] =?UTF-8?q?fix:=20promote=20Huddles=20back=20to=20stable?= =?UTF-8?q?=20=E2=80=94=20remove=20all=20gating?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Remove huddles entry from features.json (stable = no manifest entry) - Unwrap FeatureGate wrappers in AppShell.tsx and ChannelMembersBar.tsx - Remove unused FeatureGate imports - Remove huddles screenshot test and view-huddles.png - Remove huddles toggle from 'all on' test (now 4 features) 12/12 E2E tests passing. Signed-off-by: Taylor Ho --- desktop/src/app/AppShell.tsx | 5 +---- .../channels/ui/ChannelMembersBar.tsx | 5 ++--- desktop/tests/e2e/screenshot-feature-flags.ts | 13 ------------- .../settings-experiments-all-on.png | Bin 40906 -> 40802 bytes .../tests/e2e/screenshots/view-huddles.png | Bin 62447 -> 0 bytes features.json | 7 ------- 6 files changed, 3 insertions(+), 27 deletions(-) delete mode 100644 desktop/tests/e2e/screenshots/view-huddles.png diff --git a/desktop/src/app/AppShell.tsx b/desktop/src/app/AppShell.tsx index b9321d565..7b58a9fcc 100644 --- a/desktop/src/app/AppShell.tsx +++ b/desktop/src/app/AppShell.tsx @@ -54,7 +54,6 @@ import { type SettingsSection, } from "@/features/settings/ui/SettingsPanels"; import { HuddleBar, HuddleProvider } from "@/features/huddle"; -import { FeatureGate } from "@/shared/features"; import { useMeshRelayOrchestrator } from "@/features/mesh-compute/hooks/useMeshRelayOrchestrator"; import { AppSidebar } from "@/features/sidebar/ui/AppSidebar"; import { useChannelMutes } from "@/features/sidebar/lib/useChannelMutes"; @@ -888,9 +887,7 @@ export function AppShell() { }} /> - - - + diff --git a/desktop/src/features/channels/ui/ChannelMembersBar.tsx b/desktop/src/features/channels/ui/ChannelMembersBar.tsx index 6008b4c91..7e128ea49 100644 --- a/desktop/src/features/channels/ui/ChannelMembersBar.tsx +++ b/desktop/src/features/channels/ui/ChannelMembersBar.tsx @@ -3,7 +3,6 @@ import * as React from "react"; import { useQueryClient } from "@tanstack/react-query"; import { useHuddle } from "@/features/huddle"; import { HuddleIndicator } from "@/features/huddle/components/HuddleIndicator"; -import { FeatureGate } from "@/shared/features"; import { useAvailableAcpRuntimes, useBackendProvidersQuery, @@ -145,7 +144,7 @@ export function ChannelMembersBar({ {memberCount} - {huddleIndicator} + {huddleIndicator} - {huddleIndicator} + {huddleIndicator}