feat(mobile): Pulse polish — flat feed, compose page, shared filter chips, like + accent fixes (#796)

Signed-off-by: Wes <wesbillman@users.noreply.github.com> Co-authored-by: Brain <21994759fc7a6fa6b965551d35cfd7897d262f2495467f2d78694ddcfa6a5c7e@sprout-oss.stage.blox.sqprod.co>
2026-08-18 06:50:31 +02:00 · 2026-05-29 14:33:45 -07:00
parent 10f37e4cab
commit b820420909
18 changed files with 796 additions and 602 deletions
@@ -0,0 +1,111 @@
+import 'package:flutter/material.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:hooks_riverpod/hooks_riverpod.dart';
+import 'package:sprout_mobile/features/profile/user_cache_provider.dart';
+import 'package:sprout_mobile/features/profile/user_profile.dart';
+import 'package:sprout_mobile/features/pulse/compose_note_page.dart';
+import 'package:sprout_mobile/features/pulse/pulse_models.dart';
+import 'package:sprout_mobile/shared/theme/theme.dart';
+
+class _FakeUserCacheNotifier extends UserCacheNotifier {
+  final Map<String, UserProfile> _users;
+  _FakeUserCacheNotifier(this._users);
+
+  @override
+  Map<String, UserProfile> build() => _users;
+}
+
+void main() {
+  final replyNote = UserNote(
+    id: 'note1',
+    pubkey: 'alice_pk',
+    createdAt: DateTime.now().millisecondsSinceEpoch ~/ 1000 - 120,
+    content: 'The original note being replied to',
+    tags: const [],
+  );
+
+  Widget buildTestable(Widget home) {
+    return ProviderScope(
+      overrides: [
+        userCacheProvider.overrideWith(
+          () => _FakeUserCacheNotifier({
+            'alice_pk': const UserProfile(
+              pubkey: 'alice_pk',
+              displayName: 'Alice',
+            ),
+          }),
+        ),
+      ],
+      child: MaterialApp(theme: AppTheme.light(), home: home),
+    );
+  }
+
+  testWidgets('reply mode shows a rich preview of the replied-to note', (
+    tester,
+  ) async {
+    await tester.pumpWidget(buildTestable(ComposeNotePage(replyTo: replyNote)));
+    await tester.pump();
+
+    expect(find.text('Replying to Alice'), findsOneWidget);
+    expect(find.text('Alice'), findsOneWidget); // author name in the row
+    expect(find.textContaining('original note being replied to'), findsWidgets);
+    expect(find.text('Reply'), findsOneWidget); // action button label
+  });
+
+  testWidgets('new-note mode shows no reply preview', (tester) async {
+    await tester.pumpWidget(buildTestable(const ComposeNotePage()));
+    await tester.pump();
+
+    expect(find.textContaining('Replying to'), findsNothing);
+    expect(find.text('Post'), findsOneWidget);
+  });
+
+  testWidgets('reply preview stays compact for a short note', (tester) async {
+    await tester.pumpWidget(buildTestable(ComposeNotePage(replyTo: replyNote)));
+    await tester.pump();
+
+    // The preview content sits just above the divider; for a one-line note
+    // the gap between the content text and the divider must be small (this
+    // guards the earlier "preview row way too tall" regression).
+    final contentBottom = tester
+        .getRect(find.text('The original note being replied to'))
+        .bottom;
+    final divider = find.byType(Divider);
+    expect(divider, findsOneWidget);
+    final dividerTop = tester.getRect(divider).top;
+    expect(
+      dividerTop - contentBottom,
+      lessThan(24),
+      reason: 'reply preview should hug its content, not reserve tall space',
+    );
+  });
+
+  testWidgets('reply preview with an image note clips to a bounded height', (
+    tester,
+  ) async {
+    final imageNote = UserNote(
+      id: 'note2',
+      pubkey: 'alice_pk',
+      createdAt: DateTime.now().millisecondsSinceEpoch ~/ 1000 - 60,
+      content: '#sprout\n![image](https://example.com/big.png)',
+      tags: const [
+        [
+          'imeta',
+          'url https://example.com/big.png',
+          'm image/png',
+          'dim 800x1600',
+        ],
+      ],
+    );
+    await tester.pumpWidget(buildTestable(ComposeNotePage(replyTo: imageNote)));
+    await tester.pump();
+
+    // Renders the rich content (not the raw "![image](...)" markdown).
+    expect(find.textContaining('![image]'), findsNothing);
+    // The whole reply context stays bounded: divider sits within a screen of
+    // the "Replying to" label (guards a tall image blowing up the page).
+    final labelTop = tester.getRect(find.text('Replying to Alice')).top;
+    final dividerTop = tester.getRect(find.byType(Divider)).top;
+    expect(dividerTop - labelTop, lessThan(220));
+  });
+}
@@ -0,0 +1,39 @@
+import 'package:flutter/material.dart';
+import 'package:flutter_test/flutter_test.dart';
+import 'package:sprout_mobile/shared/theme/theme.dart';
+import 'package:sprout_mobile/shared/widgets/filter_chip_bar.dart';
+
+void main() {
+  testWidgets('selected chip resolves the accent (scheme.primary) as fill', (
+    tester,
+  ) async {
+    final accented = applyAccent(darkColorScheme, 0); // Blue accent
+    final accent = accented.primary;
+
+    await tester.pumpWidget(
+      MaterialApp(
+        theme: AppTheme.dark(colorScheme: accented),
+        home: Scaffold(
+          body: FilterChipBar<int>(
+            selected: 0,
+            onSelected: (_) {},
+            items: const [
+              FilterChipItem(id: 0, label: 'Everyone'),
+              FilterChipItem(id: 1, label: 'Following'),
+            ],
+          ),
+        ),
+      ),
+    );
+    await tester.pumpAndSettle();
+
+    // The chip's container color comes from ChipThemeData.color resolved for
+    // the selected state. Resolve it the same way the chip does and assert
+    // it's the accent.
+    final chipTheme = ChipTheme.of(
+      tester.element(find.widgetWithText(RawChip, 'Everyone')),
+    );
+    final resolved = chipTheme.color?.resolve({WidgetState.selected});
+    expect(resolved, accent);
+  });
+}