From b3aed32a8882c3b8acc680f0ea50ccdd1c649fd9 Mon Sep 17 00:00:00 2001 From: Matt Toohey Date: Tue, 14 Jul 2026 14:03:34 +1000 Subject: [PATCH] refactor(desktop): shorten bundled-adapter Doctor copy to "Bundled with Buzz." MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit The Doctor runtime row's status line for a bundled adapter read "ACP bridge bundled with Buzz." — the protocol jargon adds nothing in a row that already names the runtime, and the sentence only needs to say where the tool comes from. Shorten it to "Bundled with Buzz." (keeping the trailing period to match the sibling "Available via ..." line). Updated in step: the DoctorSettingsPanel comment quoting the line, the 09-bundled-adapter e2e assertion and its doc comment, and the AcpRuntimeCatalogEntry::adapter_bundled doc comment that cites the UI copy. No other test or fixture asserts the old string; the node-runtime check's backend-sourced messages keep their ACP wording per the row-detail/page-framing split from the de-jargon pass. Verification: - tsc --noEmit: clean; biome check on both touched TS files: clean - cargo fmt --check (desktop/src-tauri): clean (doc-comment-only change) - playwright doctor-states.spec.ts: 9 passed, including 09-bundled-adapter against the new copy Co-Authored-By: Claude Fable 5 Signed-off-by: Matt Toohey --- desktop/src-tauri/src/managed_agents/types.rs | 4 ++-- desktop/src/features/settings/ui/DoctorSettingsPanel.tsx | 4 ++-- desktop/tests/e2e/doctor-states.spec.ts | 4 ++-- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/desktop/src-tauri/src/managed_agents/types.rs b/desktop/src-tauri/src/managed_agents/types.rs index 29a24f0ca..45333a2a8 100644 --- a/desktop/src-tauri/src/managed_agents/types.rs +++ b/desktop/src-tauri/src/managed_agents/types.rs @@ -571,8 +571,8 @@ pub struct AcpRuntimeCatalogEntry { pub command: Option, pub binary_path: Option, /// true when `binary_path` is the pinned bridge bundled with the app - /// rather than a user install. The Doctor UI says "ACP bridge bundled - /// with Buzz" instead of rendering the resource-dir path. + /// rather than a user install. The Doctor UI says "Bundled with Buzz" + /// instead of rendering the resource-dir path. pub adapter_bundled: bool, pub default_args: Vec, pub mcp_command: Option, diff --git a/desktop/src/features/settings/ui/DoctorSettingsPanel.tsx b/desktop/src/features/settings/ui/DoctorSettingsPanel.tsx index 0d705d568..2649b4520 100644 --- a/desktop/src/features/settings/ui/DoctorSettingsPanel.tsx +++ b/desktop/src/features/settings/ui/DoctorSettingsPanel.tsx @@ -202,7 +202,7 @@ function RuntimeRow({ <>

{runtime.adapterBundled - ? "ACP bridge bundled with Buzz." + ? "Bundled with Buzz." : `Available via ${describeResolvedCommand(runtime.command, runtime.binaryPath)}.`}

{runtime.defaultArgs.length > 0 ? ( @@ -214,7 +214,7 @@ function RuntimeRow({

) : null} {/* The bundled bridge's resource-dir path is noise — the - "ACP bridge bundled with Buzz." line above covers it. The + "Bundled with Buzz." line above covers it. The user-CLI path row is retired with the cli_missing gate: the bundled bridges vendor their own CLI, so no runtime reports a separate CLI path anymore. */} diff --git a/desktop/tests/e2e/doctor-states.spec.ts b/desktop/tests/e2e/doctor-states.spec.ts index 20e56977d..272b844ad 100644 --- a/desktop/tests/e2e/doctor-states.spec.ts +++ b/desktop/tests/e2e/doctor-states.spec.ts @@ -451,7 +451,7 @@ test.describe("Doctor panel state screenshots", () => { /** * 09 — available runtime whose adapter is the bridge bundled with the app: - * the row says "ACP bridge bundled with Buzz" instead of rendering the + * the row says "Bundled with Buzz" instead of rendering the * resource-dir path, and no CLI path renders — the bundled bridge vendors * its own CLI, so the user-CLI row retired with the cli_missing gate. */ @@ -476,7 +476,7 @@ test.describe("Doctor panel state screenshots", () => { const row = page.getByTestId("doctor-runtime-claude"); await expect(row).toBeVisible({ timeout: 10_000 }); - await expect(row).toContainText("ACP bridge bundled with Buzz."); + await expect(row).toContainText("Bundled with Buzz."); await expect(row).not.toContainText("CLI:"); await expect(row).not.toContainText(bundledPath); await expect(row).not.toContainText("installed on PATH");