From 846891b89790c190896e0aaa6d6cbe2060f95a90 Mon Sep 17 00:00:00 2001 From: klopez4212 Date: Mon, 29 Jun 2026 17:55:26 +0100 Subject: [PATCH] Fix rebased task channel checks --- desktop/scripts/check-file-sizes.mjs | 5 +++-- desktop/src/features/messages/ui/useAnchoredScroll.ts | 2 ++ 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/desktop/scripts/check-file-sizes.mjs b/desktop/scripts/check-file-sizes.mjs index 7d8d2ba23..694bf8d3e 100644 --- a/desktop/scripts/check-file-sizes.mjs +++ b/desktop/scripts/check-file-sizes.mjs @@ -145,9 +145,10 @@ const overrides = new Map([ // surface for now. ["src/features/channels/ui/ChannelPane.tsx", 1415], // continued-agent-conversations: channel task-tab state, deep-link task - // routing, and side-panel suppression sit at the channel orchestration seam. + // routing, side-panel suppression, and task-link route target plumbing sit at + // the channel orchestration seam. // latest main rebase threads additional header routing through this seam. - ["src/features/channels/ui/ChannelScreen.tsx", 1040], + ["src/features/channels/ui/ChannelScreen.tsx", 1080], // continued-agent-conversations: composer notice banner for read-only agent // conversations. ["src/features/messages/ui/MessageComposer.tsx", 1010], diff --git a/desktop/src/features/messages/ui/useAnchoredScroll.ts b/desktop/src/features/messages/ui/useAnchoredScroll.ts index eaf3d0ede..e65bead5b 100644 --- a/desktop/src/features/messages/ui/useAnchoredScroll.ts +++ b/desktop/src/features/messages/ui/useAnchoredScroll.ts @@ -189,6 +189,7 @@ export function useAnchoredScroll({ // jumping to bottom or to the target message for the new view. // biome-ignore lint/correctness/useExhaustiveDependencies: resetKey is intentionally the sole trigger — it includes channel identity plus route-specific layout state. React.useLayoutEffect(() => { + void scrollScopeKey; anchorRef.current = { kind: "at-bottom" }; setIsAtBottom(true); setNewMessageCount(0); @@ -459,6 +460,7 @@ export function useAnchoredScroll({ // --------------------------------------------------------------------------- // biome-ignore lint/correctness/useExhaustiveDependencies: resetKey is a deliberate re-subscription trigger — the effect body reads only the stable refs, but on route identity changes the keyed scroll container remounts and contentRef.current becomes a fresh node, so the observer must disconnect from the previous route's detached node and re-observe the live one. React.useEffect(() => { + void scrollScopeKey; const content = contentRef.current; if (!content || typeof ResizeObserver === "undefined") return; const observer = new ResizeObserver(() => {