From 60c247e20e65bb635a30df2fabc593bf9065d5cc Mon Sep 17 00:00:00 2001 From: Hayt <41ea58f1e64c243627e8acde7c89be667052ee6e17d8f021c1195be4324ebf04@buzz.block.builderlab.xyz> Date: Sat, 8 Aug 2026 17:59:53 -0400 Subject: [PATCH] test(e2e): align permission outcome assertion with label-based rendering MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Test 03 asserted /Approved.*allow_once/ — the old format that rendered the raw ACP kind string. describePermissionOutcome now returns the harness-provided label (or verb-only fallback); the legacy non-ask path has no label map, so the rendered text is 'Approved'. Production code is untouched; this test file is the only change. Co-authored-by: Will Pfleger Signed-off-by: Will Pfleger --- desktop/tests/e2e/observer-feed-screenshots.spec.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/desktop/tests/e2e/observer-feed-screenshots.spec.ts b/desktop/tests/e2e/observer-feed-screenshots.spec.ts index 44ff609c9..3f50e60e4 100644 --- a/desktop/tests/e2e/observer-feed-screenshots.spec.ts +++ b/desktop/tests/e2e/observer-feed-screenshots.spec.ts @@ -275,8 +275,10 @@ test.describe("observer feed screenshots", () => { }, ]); - // The permission row should show the "Approved (allow_once)" outcome. - await expect(feedPanel.getByText(/Approved.*allow_once/)).toBeVisible({ + // The permission row shows the harness-provided option label ("Allow once"), + // not the raw ACP kind. The legacy non-ask path has no label map, so it + // falls back to the verb-only form: "Approved". + await expect(feedPanel.getByText("Approved")).toBeVisible({ timeout: 5_000, }); await settleAnimations(feedPanel);