From 6096318861abddb0a956b31f2221022ec7c7518c Mon Sep 17 00:00:00 2001 From: Taylor Ho Date: Fri, 5 Jun 2026 06:43:50 -1000 Subject: [PATCH] =?UTF-8?q?refactor:=20remove=20feature=20flags=20migratio?= =?UTF-8?q?n=20=E2=80=94=20experimental=20features=20are=20opt-in=20only?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Signed-off-by: Taylor Ho --- desktop/src/main.tsx | 2 -- desktop/src/shared/features/index.ts | 7 +---- desktop/src/shared/features/store.ts | 38 ---------------------------- 3 files changed, 1 insertion(+), 46 deletions(-) diff --git a/desktop/src/main.tsx b/desktop/src/main.tsx index 7dec4df9f..67d8290b0 100644 --- a/desktop/src/main.tsx +++ b/desktop/src/main.tsx @@ -2,7 +2,6 @@ import React from "react"; import ReactDOM from "react-dom/client"; import { App } from "@/app/App"; import "@/shared/styles/globals.css"; -import { runMigrationIfNeeded } from "@/shared/features"; import { UpdaterProvider } from "@/features/settings/hooks/UpdaterProvider"; import { WorkspacesProvider } from "@/features/workspaces/useWorkspaces"; import { ThemeProvider } from "@/shared/theme/ThemeProvider"; @@ -46,7 +45,6 @@ async function installE2eBridgeIfConfigured() { async function bootstrap() { await installE2eBridgeIfConfigured(); - runMigrationIfNeeded(); renderApp(); } diff --git a/desktop/src/shared/features/index.ts b/desktop/src/shared/features/index.ts index f45ebc2ce..b155cf260 100644 --- a/desktop/src/shared/features/index.ts +++ b/desktop/src/shared/features/index.ts @@ -1,11 +1,6 @@ export { FeatureGate } from "./FeatureGate"; export { allFeatures, desktopFeatures, getFeature } from "./manifest"; -export { - getOverrides, - setOverride, - clearOverride, - runMigrationIfNeeded, -} from "./store"; +export { getOverrides, setOverride, clearOverride } from "./store"; export type { FeatureDefinition, FeaturesManifest, diff --git a/desktop/src/shared/features/store.ts b/desktop/src/shared/features/store.ts index 7f8f52441..eda2a04d9 100644 --- a/desktop/src/shared/features/store.ts +++ b/desktop/src/shared/features/store.ts @@ -4,51 +4,13 @@ * localStorage keys (versioned to match manifest): * sprout-feature-overrides-v1 — JSON object of { [featureId]: boolean } * sprout-dev-features-v1 — "true" | "false" (global dev toggle) - * sprout-features-migrated-v1 — "true" if migration has run */ -import { desktopFeatures } from "./manifest"; - const OVERRIDES_KEY = "sprout-feature-overrides-v1"; const DEV_TOGGLE_KEY = "sprout-dev-features-v1"; -const MIGRATED_KEY = "sprout-features-migrated-v1"; export type FeatureOverrides = Record; -/** - * One-time migration: for existing users, seed experimental features as - * enabled so they don't lose functionality on upgrade. New installs get - * the clean opt-in experience (overrides stay empty). - * - * Existing user detection: presence of any prior Sprout localStorage key - * (theme or workspaces) proves this isn't a fresh install. - */ -export function runMigrationIfNeeded(): void { - try { - if (window.localStorage.getItem(MIGRATED_KEY) === "true") return; - - const isExistingUser = - window.localStorage.getItem("sprout-theme") !== null || - window.localStorage.getItem("sprout-workspaces") !== null; - - if (isExistingUser) { - // Seed all desktop experimental features as enabled - const seed: FeatureOverrides = {}; - for (const f of desktopFeatures) { - if (f.tier === "experimental") { - seed[f.id] = true; - } - } - window.localStorage.setItem(OVERRIDES_KEY, JSON.stringify(seed)); - } - // New installs: leave overrides empty — experimental features are opt-in - - window.localStorage.setItem(MIGRATED_KEY, "true"); - } catch { - // localStorage unavailable — no-op - } -} - /** Read all user overrides from localStorage */ export function getOverrides(): FeatureOverrides { try {