From 5677e4ca050bcfe2aef16b89f7abe326e45d0b0d Mon Sep 17 00:00:00 2001 From: Taylor Ho Date: Wed, 5 Aug 2026 18:46:29 -0700 Subject: [PATCH] test(desktop): match attachment button label (#4993) MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit **Category:** fix **User Impact:** Pull requests can once again pass the Desktop smoke test suite. **Problem:** The inbox attachment-edit smoke test still looked for the composer's former “Attach image” label after the shared action was renamed to “Attach file,” causing shard 3 and the aggregate Desktop CI job to fail on every PR. **Solution:** Update the stale accessible-name selector to match the current composer control while preserving the test's media-tag coverage.
File changes **desktop/tests/e2e/inbox-edit.spec.ts** Updates the attachment button selector to use the current accessible label so the existing attachment-edit regression test reaches the behavior it is meant to verify.
## Reproduction steps 1. Build the Desktop E2E application with `pnpm -C desktop build:e2e`. 2. Run `cd desktop && pnpm exec playwright test --project=smoke tests/e2e/inbox-edit.spec.ts -g "editing an immediate attachment reply preserves its media tags"`. 3. Confirm the test locates the “Attach file” control and passes. Signed-off-by: Taylor Ho --- desktop/tests/e2e/inbox-edit.spec.ts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/desktop/tests/e2e/inbox-edit.spec.ts b/desktop/tests/e2e/inbox-edit.spec.ts index e78576d89..a962056fa 100644 --- a/desktop/tests/e2e/inbox-edit.spec.ts +++ b/desktop/tests/e2e/inbox-edit.spec.ts @@ -230,7 +230,7 @@ test("editing an immediate attachment reply preserves its media tags", async ({ const detail = page.getByTestId("home-inbox-detail"); await expect(detail).toContainText("Inbox thread root."); - await detail.getByRole("button", { name: "Attach image" }).click(); + await detail.getByRole("button", { name: "Attach file" }).click(); await expect(detail.getByTestId("message-composer")).toContainText( ATTACHMENT_FILENAME, );