From 4696cc4cd620f7c46dce85da34bd625527d9f493 Mon Sep 17 00:00:00 2001 From: Will Pfleger Date: Fri, 22 May 2026 18:44:06 -0400 Subject: [PATCH] fix(desktop): correct ACP provider install semantics for Goose and Codex MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Goose has native ACP support (no separate adapter), so the install script belongs in cli_install_commands, not adapter_install_commands. Also sets underlying_cli to "goose" since the CLI binary exists. Codex ACP adapter is available on npm as @zed-industries/codex-acp — enable auto-install and point docs link to the actual adapter repo instead of the main Codex repo. --- desktop/src-tauri/src/managed_agents/discovery.rs | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/desktop/src-tauri/src/managed_agents/discovery.rs b/desktop/src-tauri/src/managed_agents/discovery.rs index 6f50a2a84..bd3c2ba6c 100644 --- a/desktop/src-tauri/src/managed_agents/discovery.rs +++ b/desktop/src-tauri/src/managed_agents/discovery.rs @@ -66,9 +66,9 @@ const KNOWN_ACP_PROVIDERS: &[KnownAcpProvider] = &[ avatar_url: GOOSE_AVATAR_URL, mcp_command: None, mcp_hooks: false, - underlying_cli: None, - cli_install_commands: &[], - adapter_install_commands: &["curl -fsSL https://github.com/block-open-source/goose/releases/download/stable/download_cli.sh | CONFIGURE=false bash"], + underlying_cli: Some("goose"), + cli_install_commands: &["curl -fsSL https://github.com/block-open-source/goose/releases/download/stable/download_cli.sh | CONFIGURE=false bash"], + adapter_install_commands: &[], install_instructions_url: "https://block.github.io/goose/", install_hint: "Install Goose via the official install script.", }, @@ -96,9 +96,9 @@ const KNOWN_ACP_PROVIDERS: &[KnownAcpProvider] = &[ mcp_hooks: false, underlying_cli: Some("codex"), cli_install_commands: &[], - adapter_install_commands: &[], - install_instructions_url: "https://github.com/openai/codex", - install_hint: "The codex-acp adapter must be built from source. See the GitHub repo.", + adapter_install_commands: &["npm install -g @zed-industries/codex-acp"], + install_instructions_url: "https://github.com/zed-industries/codex-acp", + install_hint: "Install the Codex ACP adapter via npm.", }, KnownAcpProvider { id: "sprout-agent",