From 39a7aa90159241e71ce5cea4c23166a74fab2748 Mon Sep 17 00:00:00 2001 From: Will Pfleger Date: Fri, 22 May 2026 16:54:14 -0400 Subject: [PATCH] fix(desktop): update E2E test helper to use consolidated acpProvidersCatalog field The onboarding E2E test passed `{ acpProviders: [] }` to the mock bridge, but the bridge handler was renamed to read `acpProvidersCatalog` during consolidation. The stale field name was silently ignored, causing the default catalog (with available providers) to be returned instead of an empty list. --- desktop/tests/e2e/onboarding.spec.ts | 2 +- desktop/tests/helpers/bridge.ts | 10 +--------- 2 files changed, 2 insertions(+), 10 deletions(-) diff --git a/desktop/tests/e2e/onboarding.spec.ts b/desktop/tests/e2e/onboarding.spec.ts index 0d2b61f3f..71d5adf4e 100644 --- a/desktop/tests/e2e/onboarding.spec.ts +++ b/desktop/tests/e2e/onboarding.spec.ts @@ -197,7 +197,7 @@ test("page 2 falls back to Doctor guidance when ACP tools are not installed", as await installMockBridge( page, { - acpProviders: [], + acpProvidersCatalog: [], }, { skipOnboardingSeed: true }, ); diff --git a/desktop/tests/helpers/bridge.ts b/desktop/tests/helpers/bridge.ts index 5bb4d8487..e318b9dc8 100644 --- a/desktop/tests/helpers/bridge.ts +++ b/desktop/tests/helpers/bridge.ts @@ -35,14 +35,6 @@ export const TEST_IDENTITIES = { type BridgeMode = "mock" | "relay"; -type MockAcpProvider = { - id: string; - label: string; - command: string; - binaryPath: string; - defaultArgs: string[]; -}; - type MockCommandAvailability = { available?: boolean; command?: string; @@ -50,7 +42,7 @@ type MockCommandAvailability = { }; type MockBridgeOptions = { - acpProviders?: MockAcpProvider[]; + acpProvidersCatalog?: Record[]; managedAgentPrereqs?: { acp?: MockCommandAvailability; mcp?: MockCommandAvailability;