From 17622ce256b7381fa5d39e2026fe84d25c1ba3e1 Mon Sep 17 00:00:00 2001
From: klopez4212 <klopez4212@gmail.com>
Date: Sat, 20 Jun 2026 11:21:13 +0100
Subject: [PATCH] Restore persona env var editing

---
 desktop/src/features/agents/ui/PersonaDialog.tsx | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/desktop/src/features/agents/ui/PersonaDialog.tsx b/desktop/src/features/agents/ui/PersonaDialog.tsx
index f93067f1f..09f93c23e 100644
--- a/desktop/src/features/agents/ui/PersonaDialog.tsx
+++ b/desktop/src/features/agents/ui/PersonaDialog.tsx
@@ -25,6 +25,7 @@ import {
   SelectValue,
 } from "@/shared/ui/select";
 import { Textarea } from "@/shared/ui/textarea";
+import { EnvVarsEditor, type EnvVarsValue } from "./EnvVarsEditor";
 import {
   getImportButtonLabel,
   getImportButtonTone,
@@ -148,6 +149,7 @@ export function PersonaDialog({
   const [systemPrompt, setSystemPrompt] = React.useState("");
   const [runtime, setRuntime] = React.useState("");
   const [model, setModel] = React.useState("");
+  const [envVars, setEnvVars] = React.useState<EnvVarsValue>({});
   const [isImportingUpdate, setIsImportingUpdate] = React.useState(false);
   const [importErrorMessage, setImportErrorMessage] = React.useState<
     string | null
@@ -170,6 +172,7 @@ export function PersonaDialog({
     setSystemPrompt(initialValues.systemPrompt);
     setRuntime(initialValues.runtime ?? "");
     setModel(initialValues.model ?? "");
+    setEnvVars("envVars" in initialValues ? (initialValues.envVars ?? {}) : {});
     setImportErrorMessage(null);
     setIsImportingUpdate(false);
   }, [initialValues, open]);
@@ -289,6 +292,7 @@ export function PersonaDialog({
       setSystemPrompt("");
       setRuntime("");
       setModel("");
+      setEnvVars({});
       setImportErrorMessage(null);
       setIsImportingUpdate(false);
       setIsWindowFileDragOver(false);
@@ -315,8 +319,6 @@ export function PersonaDialog({
         : initialValues.provider;
     const preservedNamePool =
       "namePool" in initialValues ? initialValues.namePool : undefined;
-    const preservedEnvVars =
-      "envVars" in initialValues ? initialValues.envVars : undefined;
     const baseInput = {
       displayName: displayName.trim(),
       avatarUrl: avatarUrl.trim() || undefined,
@@ -325,7 +327,7 @@ export function PersonaDialog({
       model: model.trim() || undefined,
       provider: preservedProvider ?? undefined,
       namePool: preservedNamePool,
-      envVars: preservedEnvVars,
+      envVars,
     };
 
     if ("id" in initialValues) {
@@ -634,6 +636,12 @@ export function PersonaDialog({
               </div>
             </div>
 
+            <EnvVarsEditor
+              disabled={isPending}
+              onChange={setEnvVars}
+              value={envVars}
+            />
+
             {error ? (
               <p className="text-sm text-destructive">{error.message}</p>
             ) : null}