External/bichon
1
0
Fork 0
mirror of https://github.com/rustmailer/bichon.git synced 2026-08-03 07:48:34 +02:00
Code Issues Packages Projects Releases Wiki Activity

fix(api): Rename query parameter id to message_id for clarity

Browse Source 
Rename the `id` query parameter to `message_id` in three message API
endpoints for better API clarity and consistency:

- GET /api/v1/message-content/:account_id
- GET /api/v1/download-message/:account_id
- GET /api/v1/download-attachment/:account_id

This is a breaking change for API clients that use these endpoints.

🤖 Generated with [Claude Code](https://claude.ai/code)

Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>
This commit is contained in:
Michel-Marie MAUDET
2025-12-14 08:02:02 +01:00
co-authored by Claude Opus 4.5
parent c05a8944ef
commit 934e81c5f9
1 changed files with 9 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/modules/rest/api/message.rs
+9 -9
View File
@@ -135,12 +135,12 @@ impl MessageApi {
async fn fetch_message_content( async fn fetch_message_content(
&self, &self,
account_id: Path<u64>, account_id: Path<u64>,
id: Query<u64>, message_id: Query<u64>,
context: ClientContext, context: ClientContext,
) -> ApiResult<Json<FullMessageContent>> { ) -> ApiResult<Json<FullMessageContent>> {
let account_id = account_id.0; let account_id = account_id.0;
context.require_account_access(account_id)?; context.require_account_access(account_id)?;
Ok(Json(retrieve_email_content(account_id, id.0).await?)) Ok(Json(retrieve_email_content(account_id, message_id.0).await?))
} }
/// Fetches the full content of a specific email for the given account. /// Fetches the full content of a specific email for the given account.
@@ -152,18 +152,18 @@ impl MessageApi {
async fn download_message( async fn download_message(
&self, &self,
account_id: Path<u64>, account_id: Path<u64>,
id: Query<u64>, message_id: Query<u64>,
context: ClientContext, context: ClientContext,
) -> ApiResult<Attachment<Body>> { ) -> ApiResult<Attachment<Body>> {
let account_id = account_id.0; let account_id = account_id.0;
AccountModel::check_account_exists(account_id).await?; AccountModel::check_account_exists(account_id).await?;
context.require_account_access(account_id)?; context.require_account_access(account_id)?;
let id = id.0; let message_id = message_id.0;
let reader = EML_INDEX_MANAGER.get_reader(account_id, id).await?; let reader = EML_INDEX_MANAGER.get_reader(account_id, message_id).await?;
let body = Body::from_async_read(reader); let body = Body::from_async_read(reader);
let attachment = Attachment::new(body) let attachment = Attachment::new(body)
.attachment_type(AttachmentType::Attachment) .attachment_type(AttachmentType::Attachment)
.filename(format!("{id}.eml")); .filename(format!("{message_id}.eml"));
Ok(attachment) Ok(attachment)
} }
@@ -176,17 +176,17 @@ impl MessageApi {
async fn download_attachment( async fn download_attachment(
&self, &self,
account_id: Path<u64>, account_id: Path<u64>,
id: Query<u64>, message_id: Query<u64>,
name: Query<String>, name: Query<String>,
context: ClientContext, context: ClientContext,
) -> ApiResult<Attachment<Body>> { ) -> ApiResult<Attachment<Body>> {
let account_id = account_id.0; let account_id = account_id.0;
AccountModel::check_account_exists(account_id).await?; AccountModel::check_account_exists(account_id).await?;
context.require_account_access(account_id)?; context.require_account_access(account_id)?;
let email_id = id.0; let message_id = message_id.0;
let name = name.0.trim(); let name = name.0.trim();
let reader = EML_INDEX_MANAGER let reader = EML_INDEX_MANAGER
.get_attachment(account_id, email_id, name) .get_attachment(account_id, message_id, name)
.await?; .await?;
let body = Body::from_async_read(reader); let body = Body::from_async_read(reader);
let attachment = Attachment::new(body) let attachment = Attachment::new(body)