feat(account): Prioritize dedicated name field for IMAP authentication username #28

Refactor account authentication logic to prioritize the `name` field over the `email` field during the IMAP connection phase.

- The `name` field now serves as the primary IMAP login credential and is no longer treated purely as an optional, descriptive field.
- If the `name` field is empty or unset, the system will fall back to using the full `email` address for authentication.
- This change supports IMAP providers that require a username different from the full email address (e.g., employee ID, specific account name).

Cargo.lock

@@ -424,7 +424,7 @@ dependencies = [
 
 [[package]]
 name = "bichon"
-version = "0.1.1"
+version = "0.1.2"
 dependencies = [
  "ahash",
  "async-imap",

Cargo.toml

@@ -1,6 +1,6 @@
 [package]
 name = "bichon"
-version = "0.1.1"
+version = "0.1.2"
 edition = "2021"
 
 [[bin]]

src/modules/imap/manager.rs

@@ -67,6 +67,7 @@ impl ImapConnectionManager {
     ) -> BichonResult<Session<Box<dyn SessionStream>>> {
         assert_eq!(account.account_type, AccountType::IMAP);
         let imap = account.imap.as_ref().unwrap();
+        let username = account.name.clone().unwrap_or(account.email.clone());
         match &imap.auth.auth_type {
             AuthType::Password => {
                 let password = &imap.auth.password.clone().ok_or_else(|| {
@@ -77,7 +78,7 @@ impl ImapConnectionManager {
                 })?;
 
                 let password = decrypt!(&password)?;
-                client.login(&account.email, &password).await
+                client.login(&username, &password).await
             }
             AuthType::OAuth2 => {
                 let record = OAuth2AccessToken::get(self.account_id).await?;
@@ -89,7 +90,7 @@ impl ImapConnectionManager {
                     )
                 })?;
                 client
-                    .authenticate(OAuth2::new(account.email.clone(), access_token))
+                    .authenticate(OAuth2::new(username, access_token))
                     .await
             }
         }

web/src/features/accounts/components/nosync-dialog.tsx

@@ -190,7 +190,7 @@ export function NoSyncAccountDialog({ currentRow, open, onOpenChange }: Props) {
                   </FormItem>
                 )}
               />
-              <FormField
+              {/* <FormField
                 control={form.control}
                 name="name"
                 render={({ field }) => (
@@ -205,7 +205,7 @@ export function NoSyncAccountDialog({ currentRow, open, onOpenChange }: Props) {
                     <FormMessage />
                   </FormItem>
                 )}
-              />
+              /> */}
               <FormField
                 control={form.control}
                 name='enabled'

web/src/features/accounts/components/step1.tsx

@@ -77,7 +77,7 @@ export default function Step1({ isEdit }: StepProps) {
                             <FormControl>
                                 <Input placeholder={t('accounts.namePlaceholder')} {...field} />
                             </FormControl>
-                            <FormDescription>{t('accounts.optional')}</FormDescription>
+                            <FormDescription>{t('accounts.nameDescription')}</FormDescription>
                             <FormMessage />
                         </FormItem>
                     )}

web/src/locales/ar.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "مثال: john.doe@example.com",
         "namePlaceholder": "مثال: john.doe",
         "optional": "اختياري",
+        "nameDescription": "اسم مستخدم اتصال IMAP. اترك هذا الحقل فارغًا إذا كنت تستخدم عنوان بريدك الإلكتروني الكامل كاسم مستخدم للاتصال.",
         "emailCannotBeModified": "لا يمكن تعديل عنوان حساب البريد الإلكتروني أثناء التحرير.",
         "addAccount": "إضافة حساب",
         "updateAccount": "تحديث الحساب",

web/src/locales/da.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "f.eks. hans.hansen@eksempel.dk",
         "namePlaceholder": "f.eks. Hans Hansen",
         "optional": "Valgfri",
+        "nameDescription": "IMAP-forbindelsesbrugernavn. Lad dette felt være tomt, hvis du bruger din fulde e-mailadresse som forbindelsesbrugernavn.",
         "emailCannotBeModified": "Kontoens e-mailadresse kan ikke ændres under redigering.",
         "addAccount": "Tilføj konto",
         "updateAccount": "Opdater konto",

web/src/locales/de.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "z.B. max.mustermann@beispiel.de",
         "namePlaceholder": "z.B. Max Mustermann",
         "optional": "Optional",
+        "nameDescription": "IMAP-Verbindungsbenutzername. Lassen Sie dieses Feld leer, wenn Sie Ihre vollständige E-Mail-Adresse als Verbindungsbenutzernamen verwenden.",
         "emailCannotBeModified": "Die E-Mail-Adresse des Kontos kann während der Bearbeitung nicht geändert werden.",
         "addAccount": "Konto hinzufügen",
         "updateAccount": "Konto aktualisieren",

web/src/locales/en.json

@@ -163,6 +163,7 @@
     "emailPlaceholder": "e.g john.doe@example.com",
     "namePlaceholder": "e.g john.doe",
     "optional": "Optional",
+    "nameDescription": "IMAP Connection Username. Leave this field blank if you use your full email address as the connection username.",
     "emailCannotBeModified": "The email account address cannot be modified when editing.",
     "addAccount": "Add Account",
     "updateAccount": "Update Account",

web/src/locales/es.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "ej. juan.perez@ejemplo.com",
         "namePlaceholder": "ej. Juan Pérez",
         "optional": "Opcional",
+        "nameDescription": "Nombre de usuario de conexión IMAP. Deje este campo en blanco si utiliza su dirección de correo electrónico completa como nombre de usuario de conexión.",
         "emailCannotBeModified": "La dirección de correo electrónico de la cuenta no se puede modificar durante la edición.",
         "addAccount": "Añadir cuenta",
         "updateAccount": "Actualizar cuenta",

web/src/locales/fi.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "esim. matti.meikäläinen@esimerkki.fi",
         "namePlaceholder": "esim. matti.meikäläinen",
         "optional": "Valinnainen",
+        "nameDescription": "IMAP-yhteyden käyttäjänimi. Jätä tämä kenttä tyhjäksi, jos käytät koko sähköpostiosoitettasi yhteyden käyttäjänimenä.",
         "emailCannotBeModified": "Tilin sähköpostiosoitetta ei voi muokata muokkauksen aikana.",
         "addAccount": "Lisää tili",
         "updateAccount": "Päivitä tili",

web/src/locales/fr.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "ex. jean.dupont@exemple.com",
         "namePlaceholder": "ex. jean.dupont",
         "optional": "Facultatif",
+        "nameDescription": "Nom d'utilisateur de connexion IMAP. Laissez ce champ vide si vous utilisez votre adresse e-mail complète comme nom d'utilisateur de connexion.",
         "emailCannotBeModified": "L'adresse e-mail du compte ne peut pas être modifiée lors de l'édition.",
         "addAccount": "Ajouter un Compte",
         "updateAccount": "Mettre à jour le Compte",

web/src/locales/it.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "es. john.doe@esempio.com",
         "namePlaceholder": "es. john.doe",
         "optional": "Opzionale",
+        "nameDescription": "Nome utente di connessione IMAP. Lasciare vuoto questo campo se si utilizza l'indirizzo email completo come nome utente di connessione.",
         "emailCannotBeModified": "L'indirizzo email dell'account non può essere modificato durante la modifica.",
         "addAccount": "Aggiungi Account",
         "updateAccount": "Aggiorna Account",

web/src/locales/jp.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "例: john.doe@example.com",
         "namePlaceholder": "例: john.doe",
         "optional": "オプション",
+        "nameDescription": "IMAP接続のユーザー名。接続ユーザー名として完全なメールアドレスを使用する場合は、このフィールドを空欄にしてください。",
         "emailCannotBeModified": "編集時にはメールアカウントアドレスは変更できません。",
         "addAccount": "アカウントを追加",
         "updateAccount": "アカウントを更新",

web/src/locales/ko.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "예: john.doe@example.com",
         "namePlaceholder": "예: john.doe",
         "optional": "선택 사항",
+        "nameDescription": "IMAP 연결 사용자 이름. 전체 이메일 주소를 연결 사용자 이름으로 사용하는 경우, 이 필드를 비워 두십시오.",
         "emailCannotBeModified": "편집 시 계정 이메일 주소는 수정할 수 없습니다.",
         "addAccount": "계정 추가",
         "updateAccount": "계정 업데이트",

web/src/locales/nl.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "bv. john.doe@voorbeeld.com",
         "namePlaceholder": "bv. john.doe",
         "optional": "Optioneel",
+        "nameDescription": "IMAP-verbindingsgebruikersnaam. Laat dit veld leeg als u uw volledige e-mailadres als verbindingsgebruikersnaam gebruikt.",
         "emailCannotBeModified": "Het e-mailadres van het account kan niet worden gewijzigd tijdens het bewerken.",
         "addAccount": "Account Toevoegen",
         "updateAccount": "Account Bijwerken",

web/src/locales/no.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "f.eks. ola.nordmann@eksempel.no",
         "namePlaceholder": "f.eks. ola.nordmann",
         "optional": "Valgfritt",
+        "nameDescription": "IMAP-tilkoblingsbrukernavn. La dette feltet stå tomt hvis du bruker hele e-postadressen din som tilkoblingsbrukernavn.",
         "emailCannotBeModified": "E-postadressen til kontoen kan ikke endres under redigering.",
         "addAccount": "Legg til konto",
         "updateAccount": "Oppdater konto",

web/src/locales/pt.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "Ex: john.doe@example.com",
         "namePlaceholder": "Ex: john.doe",
         "optional": "Opcional",
+        "nameDescription": "Nome de usuário de conexão IMAP. Deixe este campo em branco se você usar seu endereço de e-mail completo como nome de usuário de conexão.",
         "emailCannotBeModified": "O endereço de email da conta não pode ser modificado ao editar.",
         "addAccount": "Adicionar Conta",
         "updateAccount": "Atualizar Conta",

web/src/locales/ru.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "например, john.doe@example.com",
         "namePlaceholder": "например, john.doe",
         "optional": "Необязательно",
+        "nameDescription": "Имя пользователя для IMAP-подключения. Оставьте это поле пустым, если вы используете свой полный адрес электронной почты в качестве имени пользователя для подключения.",
         "emailCannotBeModified": "Адрес электронной почты нельзя изменить при редактировании.",
         "addAccount": "Добавить аккаунт",
         "updateAccount": "Обновить аккаунт",

web/src/locales/sv.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "t.ex. sven.svensson@exempel.se",
         "namePlaceholder": "t.ex. sven.svensson",
         "optional": "Valfritt",
+        "nameDescription": "IMAP-anslutningsanvändarnamn. Lämna detta fält tomt om du använder din fullständiga e-postadress som anslutningsanvändarnamn.",
         "emailCannotBeModified": "Kontots e-postadress kan inte ändras vid redigering.",
         "addAccount": "Lägg till konto",
         "updateAccount": "Uppdatera konto",

web/src/locales/zh-tw.json

@@ -163,6 +163,7 @@
         "emailPlaceholder": "例如：john.doe@example.com",
         "namePlaceholder": "例如：john.doe",
         "optional": "選填",
+        "nameDescription": "IMAP 連線使用者名稱。如果您使用完整的電子郵件地址作為連線使用者名稱，請將此欄位留空。",
         "emailCannotBeModified": "編輯時無法修改電子郵件帳號地址。",
         "addAccount": "新增帳號",
         "updateAccount": "更新帳號",

web/src/locales/zh.json

@@ -163,6 +163,7 @@
     "emailPlaceholder": "例如：john.doe@example.com",
     "namePlaceholder": "例如：john.doe",
     "optional": "可选",
+    "nameDescription": "IMAP 连接用户名。如果您使用完整的电子邮件地址作为连接用户名，请将此字段留空。",
     "emailCannotBeModified": "编辑时无法修改邮箱账户地址。",
     "addAccount": "添加账户",
     "updateAccount": "更新账户",