mirror of
https://github.com/runbear-io/beardrive.git
synced 2026-08-25 08:08:08 +02:00
* feat(templates): start a project from a structure, not an empty folder A new project was an empty folder with a .bdriveignore in it, so every agent session invented its own layout and the folder rotted into a pile. Both surfaces now offer the same three starting points — from a template, from scratch, from an existing folder (which is just a non-empty folder, and is never restructured). internal/templates holds the shipped set as literal go:embed'ed files: `docs` (docs/, decisions/) and `para` (projects/, areas/, resources/, archives/). cmd/bdrive is one binary for the CLI and the hub, so both read the identical set — no gallery, no drift. The AGENTS.md in each is the deliverable: where a new note goes, when something is archived, what a good filename looks like. Every directory holds a real file, because BearDrive syncs paths and an empty directory would never reach a teammate. The hub seeds at creation through the existing Upload+Commit path, journaled under its own device, and records the choice on the project record — so a user who picked PARA in a browser sees PARA in the browser, and a later init cannot seed a second copy. `bdrive init --template <name>` goes through the same endpoint, with a local-seed fallback for a hub too old to know the field, and seeds in place when re-run in an already-initialized folder (the agent's post-init path). Seeding never overwrites an existing path, which is what makes a double-seed a no-op rather than a divergence. Refusals cost nothing: an unknown name and --template with --only are both rejected before any network call or write. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * test(cli): joining a project that already has a template is refused by name The one acceptance case with no test behind it: connecting to an existing project with --template must say what the project was actually created from, and must not write the other skeleton on the way out. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * fix(templates): name the docs template in plain English, not an acronym "Plain docs + ADRs" was the recommended, first, preselected-adjacent option in a picker that non-engineers see — and it's the label people accept without reading further, so half of it not parsing is the worst place for jargon. The title also disagreed with its own blurb: "ADRs" over "docs/, decisions/", two words for the same folder one line apart. Now "Docs + decision records", which says the same thing to everyone and matches the folder names. The term itself moves into decisions/0001-record-decisions.md, where the reader is already inside the structure and the file can teach it in passing. One line in the registry drives both the web dialog and the CLI menu; the rest is prose echoing it. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(templates): add the LLM wiki template The third starting point from the issue title, unblocked: the spec parked it because shipping an approximation under someone's name needed a source, and there is now one — Karpathy's LLM Wiki gist. Worth noting the issue's own one-line description of it ("few large, append-heavy topic pages") does not match the source, which is the opposite: many interlinked pages, where a single ingest touches 10-15 of them. The pattern is three layers and three operations, not a folder shape. sources/ is yours and immutable; wiki/ is the agent's and it owns every page; AGENTS.md is the schema layer — which is exactly the file this template system already treats as the deliverable, so the fit is direct. index.md and log.md ship as the two navigation files the pattern turns on. Three of the things the gist tells you to go set up, BearDrive already is: version history and collaboration (per-file history, bdrive log), an Obsidian- style reader for [[wikilinks]] (the hub viewer), and a surface for the lint pass (the dashboard is literally reads x staleness). Two rules in the AGENTS.md are load-bearing and deliberate. A page write that has not updated the index is an incomplete write — a stale index is worse than a missing page, because it is read first and believed. And with no sources yet, build nothing: the structure grows out of the material rather than ahead of it. Shipped second, not first: docs stays the recommendation because a default is the option chosen by people not reading closely, and this pattern degrades badly when half-followed. Promoting it later is one line in the registry. The shipped-template test now checks the "what happens when something stops being true" question through a set of alternatives — PARA archives, a wiki supersedes and revises — since the vocabulary honestly differs by structure. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(web): "I already have a folder" as a starting point The third way to start from the spec — adopt what you already have — had no presence in the browser. Templates and "empty" were the only visible answers, so someone with a folder of notes either hesitated or picked a template and got four directories merged into their material. The constraint that shapes it: the browser cannot reach your disk, so this cannot change what is created. It creates the same empty project "Empty project" does; what it changes is the next screen. Create therefore stays enabled — disabling it would leave the dialog a dead end AND produce no project id, which is the one thing the paste prompt actually needs. Landing on the project home with the intent, three things differ: the guide says "in the folder you already have", a note states plainly that connecting never moves, renames or overwrites anything, and the paste prompt tells the agent a folder already exists. That last one is the part that isn't cosmetic — without it an agent reads an empty project and proposes creating shared/, the one recommendation that is wrong here. It still asks which folder: that is the runbook's hard gate and nothing here weakens it. The intent rides in the URL (?connect=existing) rather than onto the project record, the same way ?v= pins a file version. It belongs to whoever is connecting right now — a teammate who connects next week has their own answer and would be told the wrong thing by a persisted flag. Five rows made the dialog tall enough to push Create off a short viewport, so .modal scrolls internally. A hairline divider between the seeding and non-seeding rows was tried and removed: --border is 7% white, which at 1px in a gap renders as literally nothing. The gap is the cue that reads. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> * feat(web): with no projects, open the create dialog and give the page a way in A signed-in account with no projects landed on a page whose only path forward was pasting a prompt into a coding agent. Now the create dialog opens itself — with nothing to browse there is nothing else on that page to do — and the page behind it leads with "Start a project" and a button, so closing the dialog is not a dead end. The dialog moves up to HubApp because three things ask for it now: the sidebar's +, the empty state's button, and the auto-open. ProjectNav keeps only an onNew callback; one owner beats three copies of the create handler. Two guards on the auto-open. It fires once per mount, keyed off a ref rather than the empty state, or closing it would immediately reopen it. And it never fires on a read-only hub, which refuses creation server-side with a 403 — opening a dialog that cannot succeed is worse than the page it covers. The agent paste-prompt stays, demoted to "Or let your agent do it": it is still the right path for someone who wants the folder connected in the same breath, and it is the only path on a hub where this account cannot create. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 5 (1M context) <noreply@anthropic.com>
179 lines
5.4 KiB
Go
179 lines
5.4 KiB
Go
package webapp
|
|
|
|
import (
|
|
"encoding/json"
|
|
"net/http"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/runbear-io/beardrive/internal/templates"
|
|
)
|
|
|
|
// Creating with a template seeds the files through the hub's own write path,
|
|
// so a browser-created project arrives structured and every device just
|
|
// pulls it.
|
|
func TestProjectCreateWithTemplate(t *testing.T) {
|
|
srv, _, _ := newHub(t, true, nil)
|
|
h := srv.Handler()
|
|
|
|
rec := do(t, h, "POST", "/api/projects", map[string]string{"name": "brain", "template": "para"})
|
|
if rec.Code != 200 {
|
|
t.Fatalf("create: %d %s", rec.Code, rec.Body)
|
|
}
|
|
var out struct {
|
|
Project Project `json:"project"`
|
|
Created bool `json:"created"`
|
|
}
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &out); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if !out.Created || out.Project.Template != "para" {
|
|
t.Fatalf("create response = %+v, want created with template para", out)
|
|
}
|
|
|
|
// The record carries it, so a later init can't seed a second copy.
|
|
rec = do(t, h, "GET", "/api/projects/"+out.Project.ID, nil)
|
|
var got Project
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &got); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if got.Template != "para" {
|
|
t.Fatalf("GET /api/projects/{id} template = %q, want para", got.Template)
|
|
}
|
|
|
|
// Every template path is in the tree, journaled under the hub's device.
|
|
tpl, err := templates.Get("para")
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
rec = do(t, h, "GET", "/api/p/"+out.Project.ID+"/history", nil)
|
|
if rec.Code != 200 {
|
|
t.Fatalf("history: %d %s", rec.Code, rec.Body)
|
|
}
|
|
var hist struct {
|
|
Entries []struct {
|
|
Path string `json:"path"`
|
|
Device DeviceInfo `json:"device"`
|
|
} `json:"entries"`
|
|
}
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &hist); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
seen := map[string]string{}
|
|
for _, e := range hist.Entries {
|
|
seen[e.Path] = e.Device.ID
|
|
}
|
|
if len(hist.Entries) != len(tpl.Files) {
|
|
t.Fatalf("history has %d entries, want one per template file (%d): %v",
|
|
len(hist.Entries), len(tpl.Files), seen)
|
|
}
|
|
for _, f := range tpl.Files {
|
|
if seen[f.Path] == "" {
|
|
t.Fatalf("%s missing from the project: %v", f.Path, seen)
|
|
}
|
|
if seen[f.Path] != webDevice.ID {
|
|
t.Fatalf("%s attributed to %q, want the hub's own device %q", f.Path, seen[f.Path], webDevice.ID)
|
|
}
|
|
}
|
|
if !treePaths(t, h, out.Project.ID)["AGENTS.md"] {
|
|
t.Fatal("the seeded AGENTS.md is not in the file tree")
|
|
}
|
|
}
|
|
|
|
// An unknown template must be caught before anything is created.
|
|
func TestProjectCreateUnknownTemplate(t *testing.T) {
|
|
srv, _, _ := newHub(t, true, nil)
|
|
h := srv.Handler()
|
|
before := len(srv.Projects.List())
|
|
|
|
rec := do(t, h, "POST", "/api/projects", map[string]string{"name": "nope", "template": "karpathy-wiki"})
|
|
if rec.Code != 400 {
|
|
t.Fatalf("unknown template: %d %s, want 400", rec.Code, rec.Body)
|
|
}
|
|
if !strings.Contains(rec.Body.String(), "docs") || !strings.Contains(rec.Body.String(), "para") {
|
|
t.Fatalf("the 400 should name the valid set: %s", rec.Body)
|
|
}
|
|
if now := len(srv.Projects.List()); now != before {
|
|
t.Fatalf("a rejected template still created a project (%d → %d)", before, now)
|
|
}
|
|
}
|
|
|
|
// No template key at all is exactly today's behavior: an empty project.
|
|
func TestProjectCreateWithoutTemplateStaysEmpty(t *testing.T) {
|
|
srv, _, _ := newHub(t, true, nil)
|
|
h := srv.Handler()
|
|
|
|
rec := do(t, h, "POST", "/api/projects", map[string]string{"name": "plain"})
|
|
if rec.Code != 200 {
|
|
t.Fatalf("create: %d %s", rec.Code, rec.Body)
|
|
}
|
|
var out struct {
|
|
Project Project `json:"project"`
|
|
}
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &out); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if out.Project.Template != "" {
|
|
t.Fatalf("template = %q on a plain create", out.Project.Template)
|
|
}
|
|
if paths := treePaths(t, h, out.Project.ID); len(paths) != 0 {
|
|
t.Fatalf("a plain create is not empty any more: %v", paths)
|
|
}
|
|
}
|
|
|
|
// A read-only hub refuses creation before it can seed anything — the
|
|
// existing Upload.Enabled guard, unchanged.
|
|
func TestProjectCreateWithTemplateReadOnly(t *testing.T) {
|
|
srv, _, _ := newHub(t, false, nil)
|
|
rec := do(t, srv.Handler(), "POST", "/api/projects", map[string]string{"name": "ro", "template": "docs"})
|
|
if rec.Code != 403 {
|
|
t.Fatalf("read-only hub: %d %s, want 403", rec.Code, rec.Body)
|
|
}
|
|
}
|
|
|
|
// The dialog's options come from the server, so a hub shipping another
|
|
// template needs no frontend change.
|
|
func TestConfigListsTemplates(t *testing.T) {
|
|
srv, _, _ := newHub(t, true, nil)
|
|
rec := do(t, srv.Handler(), "GET", "/api/config", nil)
|
|
var cfg struct {
|
|
Templates []struct{ Name, Title, Blurb string } `json:"templates"`
|
|
}
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &cfg); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(cfg.Templates) != len(templates.List()) || cfg.Templates[0].Name != "docs" {
|
|
t.Fatalf("/api/config templates = %+v", cfg.Templates)
|
|
}
|
|
for _, tpl := range cfg.Templates {
|
|
if tpl.Title == "" || tpl.Blurb == "" {
|
|
t.Fatalf("template %q has nothing to render: %+v", tpl.Name, tpl)
|
|
}
|
|
}
|
|
}
|
|
|
|
// treePaths is the set of file paths a project's tree lists.
|
|
func treePaths(t *testing.T, h http.Handler, id string) map[string]bool {
|
|
t.Helper()
|
|
rec := do(t, h, "GET", "/api/p/"+id+"/tree", nil)
|
|
if rec.Code != 200 {
|
|
t.Fatalf("tree: %d %s", rec.Code, rec.Body)
|
|
}
|
|
var root Node
|
|
if err := json.Unmarshal(rec.Body.Bytes(), &root); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
out := map[string]bool{}
|
|
var walk func(*Node)
|
|
walk = func(n *Node) {
|
|
if !n.Dir && n.Path != "" {
|
|
out[n.Path] = true
|
|
}
|
|
for _, c := range n.Children {
|
|
walk(c)
|
|
}
|
|
}
|
|
walk(&root)
|
|
return out
|
|
}
|