mirror of
https://github.com/runbear-io/beardrive.git
synced 2026-08-25 08:08:08 +02:00
6628718f1d
* fix(cli): agent hooks never sync folders this device didn't opt into The turn hooks decided "this folder is managed" from the mere presence of .bdrive/config.json — a file designed to travel with the folder. Two holes: - A config.json arriving via git clone / copied dir made one hook firing silently mint a device identity, register the mount, create a volume store, journal the whole folder, and inject the hub-link formula — on a device that never ran init or login. - `bdrive stop` only killed the daemon: the next agent turn's `bdrive sync --hook` resumed a full sync cycle and kept injecting links, and `stop --forget` was undone within one turn by registry self-heal. Fix: one gate (`syncBlocked`) in the paths all hooks route through — sync/sync --hook/read-log now require the mount to already be enrolled in this device's mounts.json (read without ResolveMount's enrolling self-heal) and not paused. Hook mode exits silently; plain `bdrive sync` errors with a `bdrive init` pointer. New per-device paused marker in the volume dir: set by `bdrive stop`, cleared by `bdrive init` (startSync). Only init enrolls or resumes; folder moves still self-heal since enrollment is keyed by mount id, not path. Docs updated (README, SKILL.md, docs cli reference, CHANGELOG). Tests: hook/read-log no-op + no-enrollment on unenrolled and paused mounts, plain-sync refusals, stop→pause→forget regression, paused marker contract. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: architecture-diagram PRs must show before/after excerpts of changed classes The "Architecture changes" PR section now names exactly what changed and shows Before and After mermaid excerpts scoped to the affected classes and their immediate relationships — never the full diagram (Before = merge base). Convention updated in CLAUDE.md, architecture/README.md, and the pre-PR hook's reminder text. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: add cli-sync architecture diagram; widen diagram convention to the CLI architecture/cli-sync.md draws the CLI and sync engine (cmd/bdrive + internal/{syncer,store,journal,config,daemon,agenthooks}): the Session cycle over Store/journal/remote, and the command layer with the new syncBlocked opt-in gate, paused marker, and enrollment ownership. The pre-PR hook and CLAUDE.md now watch these packages too, so CLI-side structural changes trigger the before/after-excerpt convention the same way server changes do. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: full-coverage architecture diagrams — overview, frontend, agentskills Every application package is now drawn somewhere: overview.md (system diagram — package map, device↔hub↔storage flow, agent surfaces, and the private cloud/ repo as an external seam consumer), webapp-frontend.md (the hub SPA's modules: App/HubApp/VolumeApp/Browser, the in-repo nav/router, api layer, hooks, components), and agentskills added to cli-sync.md. The pre-PR hook now watches all of cmd/, internal Go code, and frontend/src (generated static/ excluded); CLAUDE.md and architecture/README.md state the coverage rule: every code change lands in exactly one detail diagram's scope, web/docs and cloud/ deliberately excluded. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: PR bodies start with a TL;DR — max 5 informal one-liners Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
36 lines
1.5 KiB
Bash
Executable File
36 lines
1.5 KiB
Bash
Executable File
#!/bin/sh
|
|
# PreToolUse(Bash) hook: block `gh pr create` when server code changed but
|
|
# architecture/ didn't. Heuristic only — a pure bug fix changes no
|
|
# structure; override by appending `# skip-diagram-check` to the command.
|
|
input=$(cat)
|
|
cmd=$(printf '%s' "$input" | python3 -c 'import json,sys; print(json.load(sys.stdin).get("tool_input",{}).get("command",""))' 2>/dev/null)
|
|
case "$cmd" in
|
|
*"gh pr create"*) ;;
|
|
*) exit 0 ;;
|
|
esac
|
|
case "$cmd" in
|
|
*skip-diagram-check*) exit 0 ;;
|
|
esac
|
|
base=$(git merge-base origin/main HEAD 2>/dev/null || git merge-base main HEAD 2>/dev/null) || exit 0
|
|
# Every application package is drawn in architecture/ (see its README);
|
|
# frontend static/ is generated output, excluded via the src-only pathspec.
|
|
code=$(git diff --name-only "$base" HEAD -- 'cmd/' 'internal/*.go' \
|
|
'internal/webapp/frontend/src/')
|
|
diag=$(git diff --name-only "$base" HEAD -- architecture/)
|
|
if [ -n "$code" ] && [ -z "$diag" ]; then
|
|
cat >&2 <<EOF
|
|
This branch changes code covered by architecture/ diagrams but architecture/ is untouched:
|
|
$code
|
|
|
|
Before creating the PR: if any of these change types or relationships drawn
|
|
in architecture/, update the affected diagram, commit it, and add an
|
|
"Architecture changes" section to the PR body: say what changed, then show
|
|
Before and After mermaid excerpts of ONLY the affected classes and their
|
|
immediate relationships (Before = diagram at the merge base), never the full
|
|
diagram. If nothing structural changed, re-run the same command with
|
|
'# skip-diagram-check' appended.
|
|
EOF
|
|
exit 2
|
|
fi
|
|
exit 0
|