mirror of
https://github.com/runbear-io/beardrive.git
synced 2026-08-25 08:08:08 +02:00
* fix(cli): agent hooks never sync folders this device didn't opt into The turn hooks decided "this folder is managed" from the mere presence of .bdrive/config.json — a file designed to travel with the folder. Two holes: - A config.json arriving via git clone / copied dir made one hook firing silently mint a device identity, register the mount, create a volume store, journal the whole folder, and inject the hub-link formula — on a device that never ran init or login. - `bdrive stop` only killed the daemon: the next agent turn's `bdrive sync --hook` resumed a full sync cycle and kept injecting links, and `stop --forget` was undone within one turn by registry self-heal. Fix: one gate (`syncBlocked`) in the paths all hooks route through — sync/sync --hook/read-log now require the mount to already be enrolled in this device's mounts.json (read without ResolveMount's enrolling self-heal) and not paused. Hook mode exits silently; plain `bdrive sync` errors with a `bdrive init` pointer. New per-device paused marker in the volume dir: set by `bdrive stop`, cleared by `bdrive init` (startSync). Only init enrolls or resumes; folder moves still self-heal since enrollment is keyed by mount id, not path. Docs updated (README, SKILL.md, docs cli reference, CHANGELOG). Tests: hook/read-log no-op + no-enrollment on unenrolled and paused mounts, plain-sync refusals, stop→pause→forget regression, paused marker contract. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: architecture-diagram PRs must show before/after excerpts of changed classes The "Architecture changes" PR section now names exactly what changed and shows Before and After mermaid excerpts scoped to the affected classes and their immediate relationships — never the full diagram (Before = merge base). Convention updated in CLAUDE.md, architecture/README.md, and the pre-PR hook's reminder text. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: add cli-sync architecture diagram; widen diagram convention to the CLI architecture/cli-sync.md draws the CLI and sync engine (cmd/bdrive + internal/{syncer,store,journal,config,daemon,agenthooks}): the Session cycle over Store/journal/remote, and the command layer with the new syncBlocked opt-in gate, paused marker, and enrollment ownership. The pre-PR hook and CLAUDE.md now watch these packages too, so CLI-side structural changes trigger the before/after-excerpt convention the same way server changes do. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: full-coverage architecture diagrams — overview, frontend, agentskills Every application package is now drawn somewhere: overview.md (system diagram — package map, device↔hub↔storage flow, agent surfaces, and the private cloud/ repo as an external seam consumer), webapp-frontend.md (the hub SPA's modules: App/HubApp/VolumeApp/Browser, the in-repo nav/router, api layer, hooks, components), and agentskills added to cli-sync.md. The pre-PR hook now watches all of cmd/, internal Go code, and frontend/src (generated static/ excluded); CLAUDE.md and architecture/README.md state the coverage rule: every code change lands in exactly one detail diagram's scope, web/docs and cloud/ deliberately excluded. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> * docs: PR bodies start with a TL;DR — max 5 informal one-liners Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> --------- Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
199 lines
6.0 KiB
Go
199 lines
6.0 KiB
Go
package main
|
|
|
|
import (
|
|
"bytes"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"testing"
|
|
|
|
"github.com/runbear-io/beardrive/internal/config"
|
|
"github.com/runbear-io/beardrive/internal/store"
|
|
)
|
|
|
|
// Real hook payload shapes from the supported platforms — read-log must find
|
|
// the file paths wherever each platform puts them. Shell and search events
|
|
// are mined heuristically, so the folder holds real files to stat against.
|
|
func TestExtractEventPaths(t *testing.T) {
|
|
folder := t.TempDir()
|
|
for _, f := range []string{"wiki/a.md", "wiki/b.md", "notes.md", "out.md"} {
|
|
p := filepath.Join(folder, f)
|
|
if err := os.MkdirAll(filepath.Dir(p), 0o755); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := os.WriteFile(p, []byte("x"), 0o644); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
}
|
|
abs := func(rel string) string { return filepath.Join(folder, rel) }
|
|
|
|
cases := map[string]struct {
|
|
payload string
|
|
want []string
|
|
}{
|
|
"claude read": {
|
|
`{"session_id":"abc","hook_event_name":"PostToolUse","tool_name":"Read",
|
|
"tool_input":{"file_path":"/proj/wiki/a.md"},"tool_response":{"type":"text"}}`,
|
|
[]string{"/proj/wiki/a.md"},
|
|
},
|
|
"gemini read_many_files": {
|
|
`{"session_id":"g1","tool":{"name":"read_many_files","args":{"paths":["wiki/a.md","wiki/b.md"]}}}`,
|
|
[]string{"wiki/a.md", "wiki/b.md"},
|
|
},
|
|
"gemini read_file absolute": {
|
|
`{"session_id":"g2","tool":{"name":"read_file","args":{"absolute_path":"/proj/notes.md"}}}`,
|
|
[]string{"/proj/notes.md"},
|
|
},
|
|
"hermes read_file": {
|
|
`{"hook_event_name":"post_tool_call","tool_name":"read_file","tool_args":{"path":"docs/x.md"}}`,
|
|
[]string{"docs/x.md"},
|
|
},
|
|
"duplicates collapse": {
|
|
`{"tool_input":{"file_path":"a.md"},"extra":{"file_path":"a.md"}}`,
|
|
[]string{"a.md"},
|
|
},
|
|
"no paths": {
|
|
`{"session_id":"abc","prompt":"hello"}`,
|
|
nil,
|
|
},
|
|
"not json": {
|
|
`plain text`,
|
|
nil,
|
|
},
|
|
// Shell commands: existing files named as arguments count as reads;
|
|
// flags, missing files, and redirect targets don't.
|
|
"bash cat and grep": {
|
|
`{"tool_name":"Bash","tool_input":{"command":"cat wiki/a.md && grep -n foo notes.md missing.md > out.md"}}`,
|
|
[]string{"wiki/a.md", "notes.md"},
|
|
},
|
|
"bash pipeline with quotes": {
|
|
`{"tool_name":"Bash","tool_input":{"command":"tail -20 'wiki/b.md' | head -5"}}`,
|
|
[]string{"wiki/b.md"},
|
|
},
|
|
// Search tools: reads are the files the MATCHES came from, mined
|
|
// from the response; the scope dir in tool_input.path must not leak.
|
|
"grep content lines": {
|
|
`{"tool_name":"Grep","tool_input":{"pattern":"foo","path":"` + folder + `"},
|
|
"tool_response":{"content":"wiki/a.md:3:foo bar\nwiki/b.md:9:foo"}}`,
|
|
[]string{"wiki/a.md", "wiki/b.md"},
|
|
},
|
|
"grep filenames list": {
|
|
`{"tool_name":"Grep","tool_input":{"pattern":"foo","path":"` + folder + `"},
|
|
"tool_response":{"filenames":["` + abs("notes.md") + `"]}}`,
|
|
[]string{abs("notes.md")},
|
|
},
|
|
// Listing tools: seeing a file's name is not reading it.
|
|
"glob ignored": {
|
|
`{"tool_name":"Glob","tool_input":{"pattern":"**/*.md"},
|
|
"tool_response":{"filenames":["` + abs("wiki/a.md") + `"]}}`,
|
|
nil,
|
|
},
|
|
}
|
|
for name, c := range cases {
|
|
got := extractEventPaths([]byte(c.payload), folder)
|
|
if strings.Join(got, ",") != strings.Join(c.want, ",") {
|
|
t.Errorf("%s: paths = %v, want %v", name, got, c.want)
|
|
}
|
|
}
|
|
}
|
|
|
|
// End to end through the cobra command: a claude-style event lands in the
|
|
// mount's read spool, filtered to project-relative synced paths.
|
|
func TestReadLogCommand(t *testing.T) {
|
|
t.Setenv("BDRIVE_HOME", t.TempDir())
|
|
folder := t.TempDir()
|
|
folder, _ = filepath.EvalSymlinks(folder)
|
|
proj, err := config.SaveProject(folder, config.Project{Volume: "wiki"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, _, err := config.ResolveMount(folder); err != nil { // enroll, as `bdrive init` would
|
|
t.Fatal(err)
|
|
}
|
|
|
|
c := readLogCmd()
|
|
c.SetIn(bytes.NewReader([]byte(`{"session_id":"abc","tool_name":"Read",
|
|
"tool_input":{"file_path":"` + folder + `/wiki/a.md"},
|
|
"other":{"file_path":"/somewhere/else/entirely.md"}}`)))
|
|
c.SetArgs([]string{folder})
|
|
if err := c.Execute(); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
|
|
vdir, err := config.VolumeDir(proj.ID)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
st, err := store.Open(vdir)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
evs, err := st.PendingReads()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(evs) != 1 || evs[0].Path != "wiki/a.md" {
|
|
t.Fatalf("spool = %+v, want just the in-project read, mount-relative", evs)
|
|
}
|
|
}
|
|
|
|
// read-log fires on every agent tool call in every folder, so it must be
|
|
// inert where this device never opted in: an unenrolled config.json (one
|
|
// that arrived with a git clone / copied folder) spools nothing, enrolls
|
|
// nothing, and creates no volume store; a paused project spools nothing.
|
|
func TestReadLogGated(t *testing.T) {
|
|
t.Setenv("BDRIVE_HOME", t.TempDir())
|
|
folder := t.TempDir()
|
|
folder, _ = filepath.EvalSymlinks(folder)
|
|
proj, err := config.SaveProject(folder, config.Project{Volume: "wiki"})
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
vdir, err := config.VolumeDir(proj.ID)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
event := `{"tool_name":"Read","tool_input":{"file_path":"` + folder + `/wiki/a.md"}}`
|
|
run := func() {
|
|
c := readLogCmd()
|
|
c.SetIn(bytes.NewReader([]byte(event)))
|
|
c.SetArgs([]string{folder})
|
|
if err := c.Execute(); err != nil {
|
|
t.Fatalf("read-log must never fail: %v", err)
|
|
}
|
|
}
|
|
|
|
// Unenrolled: no spool, no store, no registry entry.
|
|
run()
|
|
if _, err := os.Stat(vdir); !os.IsNotExist(err) {
|
|
t.Fatal("unenrolled read-log created the volume store")
|
|
}
|
|
mounts, err := config.LoadMounts()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if _, enrolled := mounts[proj.ID]; enrolled {
|
|
t.Fatal("read-log enrolled the mount; only `bdrive init` may do that")
|
|
}
|
|
|
|
// Enrolled but paused by `bdrive stop`: still nothing spooled.
|
|
if _, _, err := config.ResolveMount(folder); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if err := store.SetPaused(vdir, true); err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
run()
|
|
st, err := store.Open(vdir)
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
evs, err := st.PendingReads()
|
|
if err != nil {
|
|
t.Fatal(err)
|
|
}
|
|
if len(evs) != 0 {
|
|
t.Fatalf("paused read-log spooled %+v, want nothing", evs)
|
|
}
|
|
}
|