mirror of
https://github.com/addyosmani/agent-skills.git
synced 2026-08-12 18:07:26 +02:00
JunghwanNA
cea2f381cd
The maintainer confirmed the original preventDefault fix was mergeable, but also pointed out that the example could better mirror native button behavior. This follow-up keeps the docs-only scope while making the example clearer: Enter stays on keydown, Space only suppresses default scrolling on keydown, and activation happens on keyup. Constraint: Keep the change limited to the existing accessibility example in the frontend UI skill Rejected: Leave the first patch as-is and wait | low-cost maintainer suggestion that improves behavioral fidelity Confidence: high Scope-risk: narrow Reversibility: clean Directive: For custom role=button examples, document Space activation in a way that does not reintroduce page scrolling or drift from native button timing without explanation Tested: git diff --check; manual browser/WKWebView reasoning against the example semantics Not-tested: Cross-browser live rerun after the keyup refinement