From 27dcc32b83460aa4b186db3a31305387352a83c7 Mon Sep 17 00:00:00 2001 From: Joan Leon Date: Sun, 12 Jul 2026 19:47:07 +0200 Subject: [PATCH] docs(adoption-guide): name the merge-blocking review labels Per review: the severity-label taxonomy's point is the labels that gate a merge (Critical and Required), with Nit/Optional/FYI being the don't-block side. In a doc about protecting a legacy codebase, name the blocking half instead of only the optional one; let the skill remain the source of the full taxonomy. --- docs/adoption-guide.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/adoption-guide.md b/docs/adoption-guide.md index 91e1484..77deeae 100644 --- a/docs/adoption-guide.md +++ b/docs/adoption-guide.md @@ -79,7 +79,7 @@ In an established codebase, the risk profile inverts: the danger isn't building Goal: the agent understands the codebase before it modifies anything. 1. **`context-engineering` first.** Write the project rules file describing the real conventions, the ones in the code, not the ones in the wiki. Include build/test commands, directory meaning, known landmines ("don't touch `legacy/billing`, it has no tests and three known workarounds"). -2. **`code-review-and-quality` on incoming changes.** Reviewing is zero-risk and immediately valuable: the five-axis review and severity labels (Nit/Optional/FYI) work on any PR regardless of the codebase's state. +2. **`code-review-and-quality` on incoming changes.** Reviewing is zero-risk and immediately valuable: the five-axis review and its severity labels (which separate what blocks a merge, Critical and Required, from what doesn't) work on any PR regardless of the codebase's state. 3. **`debugging-and-error-recovery` for the bugs you were fixing anyway.** The five-step triage (reproduce → localize → reduce → fix → guard) shines in unfamiliar code, and the "guard" step starts building the regression suite you don't have. 4. **`doubt-driven-development` as a safety net.** Legacy code is exactly the "unfamiliar code, high cost of being wrong" scenario this skill targets. Adversarial fresh-context review of the agent's claims about how the legacy system works catches confident hallucinations before they become commits.