mirror of
https://github.com/SuperClaude-Org/SuperClaude_Framework.git
synced 2025-12-20 11:16:33 +00:00
* refactor: PM Agent complete independence from external MCP servers ## Summary Implement graceful degradation to ensure PM Agent operates fully without any MCP server dependencies. MCP servers now serve as optional enhancements rather than required components. ## Changes ### Responsibility Separation (NEW) - **PM Agent**: Development workflow orchestration (PDCA cycle, task management) - **mindbase**: Memory management (long-term, freshness, error learning) - **Built-in memory**: Session-internal context (volatile) ### 3-Layer Memory Architecture with Fallbacks 1. **Built-in Memory** [OPTIONAL]: Session context via MCP memory server 2. **mindbase** [OPTIONAL]: Long-term semantic search via airis-mcp-gateway 3. **Local Files** [ALWAYS]: Core functionality in docs/memory/ ### Graceful Degradation Implementation - All MCP operations marked with [ALWAYS] or [OPTIONAL] - Explicit IF/ELSE fallback logic for every MCP call - Dual storage: Always write to local files + optionally to mindbase - Smart lookup: Semantic search (if available) → Text search (always works) ### Key Fallback Strategies **Session Start**: - mindbase available: search_conversations() for semantic context - mindbase unavailable: Grep docs/memory/*.jsonl for text-based lookup **Error Detection**: - mindbase available: Semantic search for similar past errors - mindbase unavailable: Grep docs/mistakes/ + solutions_learned.jsonl **Knowledge Capture**: - Always: echo >> docs/memory/patterns_learned.jsonl (persistent) - Optional: mindbase.store() for semantic search enhancement ## Benefits - ✅ Zero external dependencies (100% functionality without MCP) - ✅ Enhanced capabilities when MCPs available (semantic search, freshness) - ✅ No functionality loss, only reduced search intelligence - ✅ Transparent degradation (no error messages, automatic fallback) ## Related Research - Serena MCP investigation: Exposes tools (not resources), memory = markdown files - mindbase superiority: PostgreSQL + pgvector > Serena memory features - Best practices alignment: /Users/kazuki/github/airis-mcp-gateway/docs/mcp-best-practices.md 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore: add PR template and pre-commit config - Add structured PR template with Git workflow checklist - Add pre-commit hooks for secret detection and Conventional Commits - Enforce code quality gates (YAML/JSON/Markdown lint, shellcheck) NOTE: Execute pre-commit inside Docker container to avoid host pollution: docker compose exec workspace uv tool install pre-commit docker compose exec workspace pre-commit run --all-files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * docs: update PM Agent context with token efficiency architecture - Add Layer 0 Bootstrap (150 tokens, 95% reduction) - Document Intent Classification System (5 complexity levels) - Add Progressive Loading strategy (5-layer) - Document mindbase integration incentive (38% savings) - Update with 2025-10-17 redesign details * refactor: PM Agent command with progressive loading - Replace auto-loading with User Request First philosophy - Add 5-layer progressive context loading - Implement intent classification system - Add workflow metrics collection (.jsonl) - Document graceful degradation strategy * fix: installer improvements Update installer logic for better reliability * docs: add comprehensive development documentation - Add architecture overview - Add PM Agent improvements analysis - Add parallel execution architecture - Add CLI install improvements - Add code style guide - Add project overview - Add install process analysis * docs: add research documentation Add LLM agent token efficiency research and analysis * docs: add suggested commands reference * docs: add session logs and testing documentation - Add session analysis logs - Add testing documentation * feat: migrate CLI to typer + rich for modern UX ## What Changed ### New CLI Architecture (typer + rich) - Created `superclaude/cli/` module with modern typer-based CLI - Replaced custom UI utilities with rich native features - Added type-safe command structure with automatic validation ### Commands Implemented - **install**: Interactive installation with rich UI (progress, panels) - **doctor**: System diagnostics with rich table output - **config**: API key management with format validation ### Technical Improvements - Dependencies: Added typer>=0.9.0, rich>=13.0.0, click>=8.0.0 - Entry Point: Updated pyproject.toml to use `superclaude.cli.app:cli_main` - Tests: Added comprehensive smoke tests (11 passed) ### User Experience Enhancements - Rich formatted help messages with panels and tables - Automatic input validation with retry loops - Clear error messages with actionable suggestions - Non-interactive mode support for CI/CD ## Testing ```bash uv run superclaude --help # ✓ Works uv run superclaude doctor # ✓ Rich table output uv run superclaude config show # ✓ API key management pytest tests/test_cli_smoke.py # ✓ 11 passed, 1 skipped ``` ## Migration Path - ✅ P0: Foundation complete (typer + rich + smoke tests) - 🔜 P1: Pydantic validation models (next sprint) - 🔜 P2: Enhanced error messages (next sprint) - 🔜 P3: API key retry loops (next sprint) ## Performance Impact - **Code Reduction**: Prepared for -300 lines (custom UI → rich) - **Type Safety**: Automatic validation from type hints - **Maintainability**: Framework primitives vs custom code 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: consolidate documentation directories Merged claudedocs/ into docs/research/ for consistent documentation structure. Changes: - Moved all claudedocs/*.md files to docs/research/ - Updated all path references in documentation (EN/KR) - Updated RULES.md and research.md command templates - Removed claudedocs/ directory - Removed ClaudeDocs/ from .gitignore Benefits: - Single source of truth for all research reports - PEP8-compliant lowercase directory naming - Clearer documentation organization - Prevents future claudedocs/ directory creation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * perf: reduce /sc:pm command output from 1652 to 15 lines - Remove 1637 lines of documentation from command file - Keep only minimal bootstrap message - 99% token reduction on command execution - Detailed specs remain in superclaude/agents/pm-agent.md 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * perf: split PM Agent into execution workflows and guide - Reduce pm-agent.md from 735 to 429 lines (42% reduction) - Move philosophy/examples to docs/agents/pm-agent-guide.md - Execution workflows (PDCA, file ops) stay in pm-agent.md - Guide (examples, quality standards) read once when needed Token savings: - Agent loading: ~6K → ~3.5K tokens (42% reduction) - Total with pm.md: 71% overall reduction 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: consolidate PM Agent optimization and pending changes PM Agent optimization (already committed separately): - superclaude/commands/pm.md: 1652→14 lines - superclaude/agents/pm-agent.md: 735→429 lines - docs/agents/pm-agent-guide.md: new guide file Other pending changes: - setup: framework_docs, mcp, logger, remove ui.py - superclaude: __main__, cli/app, cli/commands/install - tests: test_ui updates - scripts: workflow metrics analysis tools - docs/memory: session state updates 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: simplify MCP installer to unified gateway with legacy mode ## Changes ### MCP Component (setup/components/mcp.py) - Simplified to single airis-mcp-gateway by default - Added legacy mode for individual official servers (sequential-thinking, context7, magic, playwright) - Dynamic prerequisites based on mode: - Default: uv + claude CLI only - Legacy: node (18+) + npm + claude CLI - Removed redundant server definitions ### CLI Integration - Added --legacy flag to setup/cli/commands/install.py - Added --legacy flag to superclaude/cli/commands/install.py - Config passes legacy_mode to component installer ## Benefits - ✅ Simpler: 1 gateway vs 9+ individual servers - ✅ Lighter: No Node.js/npm required (default mode) - ✅ Unified: All tools in one gateway (sequential-thinking, context7, magic, playwright, serena, morphllm, tavily, chrome-devtools, git, puppeteer) - ✅ Flexible: --legacy flag for official servers if needed ## Usage ```bash superclaude install # Default: airis-mcp-gateway (推奨) superclaude install --legacy # Legacy: individual official servers ``` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: rename CoreComponent to FrameworkDocsComponent and add PM token tracking ## Changes ### Component Renaming (setup/components/) - Renamed CoreComponent → FrameworkDocsComponent for clarity - Updated all imports in __init__.py, agents.py, commands.py, mcp_docs.py, modes.py - Better reflects the actual purpose (framework documentation files) ### PM Agent Enhancement (superclaude/commands/pm.md) - Added token usage tracking instructions - PM Agent now reports: 1. Current token usage from system warnings 2. Percentage used (e.g., "27% used" for 54K/200K) 3. Status zone: 🟢 <75% | 🟡 75-85% | 🔴 >85% - Helps prevent token exhaustion during long sessions ### UI Utilities (setup/utils/ui.py) - Added new UI utility module for installer - Provides consistent user interface components ## Benefits - ✅ Clearer component naming (FrameworkDocs vs Core) - ✅ PM Agent token awareness for efficiency - ✅ Better visual feedback with status zones 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor(pm-agent): minimize output verbosity (471→284 lines, 40% reduction) **Problem**: PM Agent generated excessive output with redundant explanations - "System Status Report" with decorative formatting - Repeated "Common Tasks" lists user already knows - Verbose session start/end protocols - Duplicate file operations documentation **Solution**: Compress without losing functionality - Session Start: Reduced to symbol-only status (🟢 branch | nM nD | token%) - Session End: Compressed to essential actions only - File Operations: Consolidated from 2 sections to 1 line reference - Self-Improvement: 5 phases → 1 unified workflow - Output Rules: Explicit constraints to prevent Claude over-explanation **Quality Preservation**: - ✅ All core functions retained (PDCA, memory, patterns, mistakes) - ✅ PARALLEL Read/Write preserved (performance critical) - ✅ Workflow unchanged (session lifecycle intact) - ✅ Added output constraints (prevents verbose generation) **Reduction Method**: - Deleted: Explanatory text, examples, redundant sections - Retained: Action definitions, file paths, core workflows - Added: Explicit output constraints to enforce minimalism **Token Impact**: 40% reduction in agent documentation size **Before**: Verbose multi-section report with task lists **After**: Single line status: 🟢 integration | 15M 17D | 36% 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: consolidate MCP integration to unified gateway **Changes**: - Remove individual MCP server docs (superclaude/mcp/*.md) - Remove MCP server configs (superclaude/mcp/configs/*.json) - Delete MCP docs component (setup/components/mcp_docs.py) - Simplify installer (setup/core/installer.py) - Update components for unified gateway approach **Rationale**: - Unified gateway (airis-mcp-gateway) provides all MCP servers - Individual docs/configs no longer needed (managed centrally) - Reduces maintenance burden and file count - Simplifies installation process **Files Removed**: 17 MCP files (docs + configs) **Installer Changes**: Removed legacy MCP installation logic 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore: update version and component metadata - Bump version (pyproject.toml, setup/__init__.py) - Update CLAUDE.md import service references - Reflect component structure changes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: kazuki <kazuki@kazukinoMacBook-Air.local> Co-authored-by: Claude <noreply@anthropic.com>
305 lines
10 KiB
Python
305 lines
10 KiB
Python
"""
|
|
Base installer logic for SuperClaude installation system fixed some issues
|
|
"""
|
|
|
|
from typing import List, Dict, Optional, Set, Tuple, Any
|
|
from pathlib import Path
|
|
import shutil
|
|
import tempfile
|
|
from datetime import datetime
|
|
from .base import Component
|
|
from ..utils.logger import get_logger
|
|
|
|
|
|
class Installer:
|
|
"""Main installer orchestrator"""
|
|
|
|
def __init__(self, install_dir: Optional[Path] = None, dry_run: bool = False):
|
|
"""
|
|
Initialize installer
|
|
|
|
Args:
|
|
install_dir: Target installation directory
|
|
dry_run: If True, only simulate installation
|
|
"""
|
|
from .. import DEFAULT_INSTALL_DIR
|
|
|
|
self.install_dir = install_dir or DEFAULT_INSTALL_DIR
|
|
self.dry_run = dry_run
|
|
self.components: Dict[str, Component] = {}
|
|
from ..services.settings import SettingsService
|
|
|
|
settings_manager = SettingsService(self.install_dir)
|
|
self.installed_components: Set[str] = set(
|
|
settings_manager.get_installed_components().keys()
|
|
)
|
|
self.updated_components: Set[str] = set()
|
|
|
|
self.failed_components: Set[str] = set()
|
|
self.skipped_components: Set[str] = set()
|
|
self.logger = get_logger()
|
|
|
|
def register_component(self, component: Component) -> None:
|
|
"""
|
|
Register a component for installation
|
|
|
|
Args:
|
|
component: Component instance to register
|
|
"""
|
|
metadata = component.get_metadata()
|
|
self.components[metadata["name"]] = component
|
|
|
|
def register_components(self, components: List[Component]) -> None:
|
|
"""
|
|
Register multiple components
|
|
|
|
Args:
|
|
components: List of component instances
|
|
"""
|
|
for component in components:
|
|
self.register_component(component)
|
|
|
|
def resolve_dependencies(self, component_names: List[str]) -> List[str]:
|
|
"""
|
|
Resolve component dependencies in correct installation order
|
|
|
|
Args:
|
|
component_names: List of component names to install
|
|
|
|
Returns:
|
|
Ordered list of component names including dependencies
|
|
|
|
Raises:
|
|
ValueError: If circular dependencies detected or unknown component
|
|
"""
|
|
resolved = []
|
|
resolving = set()
|
|
|
|
def resolve(name: str) -> None:
|
|
if name in resolved:
|
|
return
|
|
|
|
if name in resolving:
|
|
raise ValueError(f"Circular dependency detected involving {name}")
|
|
|
|
if name not in self.components:
|
|
raise ValueError(f"Unknown component: {name}")
|
|
|
|
resolving.add(name)
|
|
|
|
# Resolve dependencies first
|
|
for dep in self.components[name].get_dependencies():
|
|
resolve(dep)
|
|
|
|
resolving.remove(name)
|
|
resolved.append(name)
|
|
|
|
# Resolve each requested component
|
|
for name in component_names:
|
|
resolve(name)
|
|
|
|
return resolved
|
|
|
|
def validate_system_requirements(self) -> Tuple[bool, List[str]]:
|
|
"""
|
|
Validate system requirements for all registered components
|
|
|
|
Returns:
|
|
Tuple of (success: bool, error_messages: List[str])
|
|
"""
|
|
errors = []
|
|
|
|
# Check disk space (500MB minimum)
|
|
try:
|
|
stat = shutil.disk_usage(self.install_dir.parent)
|
|
free_mb = stat.free / (1024 * 1024)
|
|
if free_mb < 500:
|
|
errors.append(
|
|
f"Insufficient disk space: {free_mb:.1f}MB free (500MB required)"
|
|
)
|
|
except Exception as e:
|
|
errors.append(f"Could not check disk space: {e}")
|
|
|
|
# Check write permissions
|
|
test_file = self.install_dir / ".write_test"
|
|
try:
|
|
self.install_dir.mkdir(parents=True, exist_ok=True)
|
|
test_file.touch()
|
|
test_file.unlink()
|
|
except Exception as e:
|
|
errors.append(f"No write permission to {self.install_dir}: {e}")
|
|
|
|
return len(errors) == 0, errors
|
|
|
|
def install_component(self, component_name: str, config: Dict[str, Any]) -> bool:
|
|
"""
|
|
Install a single component
|
|
|
|
Args:
|
|
component_name: Name of component to install
|
|
config: Installation configuration
|
|
|
|
Returns:
|
|
True if successful, False otherwise
|
|
"""
|
|
if component_name not in self.components:
|
|
raise ValueError(f"Unknown component: {component_name}")
|
|
|
|
component = self.components[component_name]
|
|
|
|
# Framework components are ALWAYS updated to latest version
|
|
# These are SuperClaude implementation files, not user configurations
|
|
framework_components = {'framework_docs', 'agents', 'commands', 'modes', 'core', 'mcp'}
|
|
|
|
if component_name in framework_components:
|
|
# Always update framework components to latest version
|
|
if component_name in self.installed_components:
|
|
self.logger.info(f"Updating framework component to latest version: {component_name}")
|
|
else:
|
|
self.logger.info(f"Installing framework component: {component_name}")
|
|
# Force update for framework components
|
|
config = {**config, 'force_update': True}
|
|
elif (
|
|
not component.is_reinstallable()
|
|
and component_name in self.installed_components
|
|
and not config.get("update_mode")
|
|
and not config.get("force")
|
|
):
|
|
# Only skip non-framework components that are already installed
|
|
self.skipped_components.add(component_name)
|
|
self.logger.info(f"Skipping already installed component: {component_name}")
|
|
return True
|
|
|
|
# Check prerequisites
|
|
success, errors = component.validate_prerequisites()
|
|
if not success:
|
|
self.logger.error(f"Prerequisites failed for {component_name}:")
|
|
for error in errors:
|
|
self.logger.error(f" - {error}")
|
|
self.failed_components.add(component_name)
|
|
return False
|
|
|
|
# Perform installation or update
|
|
try:
|
|
if self.dry_run:
|
|
self.logger.info(f"[DRY RUN] Would install {component_name}")
|
|
success = True
|
|
else:
|
|
# If component is already installed and this is a framework component, call update() instead of install()
|
|
if component_name in self.installed_components and component_name in framework_components:
|
|
success = component.update(config)
|
|
else:
|
|
success = component.install(config)
|
|
|
|
if success:
|
|
self.installed_components.add(component_name)
|
|
self.updated_components.add(component_name)
|
|
else:
|
|
self.failed_components.add(component_name)
|
|
|
|
return success
|
|
|
|
except Exception as e:
|
|
self.logger.error(f"Error installing {component_name}: {e}")
|
|
self.failed_components.add(component_name)
|
|
return False
|
|
|
|
def install_components(
|
|
self, component_names: List[str], config: Optional[Dict[str, Any]] = None
|
|
) -> bool:
|
|
"""
|
|
Install multiple components in dependency order
|
|
|
|
Args:
|
|
component_names: List of component names to install
|
|
config: Installation configuration
|
|
|
|
Returns:
|
|
True if all successful, False if any failed
|
|
"""
|
|
config = config or {}
|
|
|
|
# Resolve dependencies
|
|
try:
|
|
ordered_names = self.resolve_dependencies(component_names)
|
|
except ValueError as e:
|
|
self.logger.error(f"Dependency resolution error: {e}")
|
|
return False
|
|
|
|
# Validate system requirements
|
|
success, errors = self.validate_system_requirements()
|
|
if not success:
|
|
self.logger.error("System requirements not met:")
|
|
for error in errors:
|
|
self.logger.error(f" - {error}")
|
|
return False
|
|
|
|
# Install each component
|
|
all_success = True
|
|
for name in ordered_names:
|
|
self.logger.info(f"Installing {name}...")
|
|
if not self.install_component(name, config):
|
|
all_success = False
|
|
# Continue installing other components even if one fails
|
|
|
|
if not self.dry_run:
|
|
self._run_post_install_validation()
|
|
|
|
return all_success
|
|
|
|
def _run_post_install_validation(self) -> None:
|
|
"""Run post-installation validation for all installed components"""
|
|
self.logger.info("Running post-installation validation...")
|
|
|
|
all_valid = True
|
|
for name in self.updated_components:
|
|
if name not in self.components:
|
|
self.logger.warning(
|
|
f"Cannot validate component '{name}' as it was not part of this installation session."
|
|
)
|
|
continue
|
|
|
|
component = self.components[name]
|
|
success, errors = component.validate_installation()
|
|
|
|
if success:
|
|
self.logger.info(f" + {name}: Valid")
|
|
else:
|
|
self.logger.error(f" x {name}: Invalid")
|
|
for error in errors:
|
|
self.logger.error(f" - {error}")
|
|
all_valid = False
|
|
|
|
if all_valid:
|
|
self.logger.info("All components validated successfully!")
|
|
else:
|
|
self.logger.error("Some components failed validation. Check errors above.")
|
|
|
|
def update_components(
|
|
self, component_names: List[str], config: Dict[str, Any]
|
|
) -> bool:
|
|
"""Alias for update operation (uses install logic)"""
|
|
config["update_mode"] = True
|
|
return self.install_components(component_names, config)
|
|
|
|
def get_installation_summary(self) -> Dict[str, Any]:
|
|
"""
|
|
Get summary of installation results
|
|
|
|
Returns:
|
|
Dict with installation statistics and results
|
|
"""
|
|
return {
|
|
"installed": list(self.installed_components),
|
|
"failed": list(self.failed_components),
|
|
"skipped": list(self.skipped_components),
|
|
"install_dir": str(self.install_dir),
|
|
"dry_run": self.dry_run,
|
|
}
|
|
|
|
def get_update_summary(self) -> Dict[str, Any]:
|
|
return {
|
|
"updated": list(self.updated_components),
|
|
"failed": list(self.failed_components),
|
|
}
|