External/SuperClaude
1
0
Fork 0
mirror of https://github.com/SuperClaude-Org/SuperClaude_Framework.git synced 2025-12-29 16:16:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fixed Some Bugs (#355)

Browse Source 
* Fix: Install only selected MCP servers and ensure valid empty backups

This commit addresses two separate issues:

1.  **MCP Installation:** The `install` command was installing all MCP servers instead of only the ones selected by the user. The `_install` method in `setup/components/mcp.py` was iterating through all available servers, not the user's selection. This has been fixed to respect the `selected_mcp_servers` configuration. A new test has been added to verify this fix.

2.  **Backup Creation:** The `create_backup` method in `setup/core/installer.py` created an invalid `.tar.gz` file when the backup source was empty. This has been fixed to ensure that a valid, empty tar archive is always created. A test was added for this as well.
Co-authored-by: Mithun Gowda B <mithungowda.b7411@gmail.com>
Co-authored-by: Jules <jules-ai-assistant@users.noreply.github.com>

* Fix: Correct installer validation for MCP and MCP Docs components

This commit fixes a validation issue in the installer where it would incorrectly fail after a partial installation of MCP servers.

The `MCPComponent` validation logic was checking for all "required" servers, regardless of whether they were selected by the user. This has been corrected to only validate the servers that were actually installed, by checking against the list of installed servers stored in the metadata. The metadata storage has also been fixed to only record the installed servers.

The `MCPDocsComponent` was failing validation because it was not being registered in the metadata if no documentation files were installed. This has been fixed by ensuring the post-installation hook runs even when no files are copied.

New tests have been added for both components to verify the corrected logic.

Co-authored-by: Mithun Gowda B <mithungowda.b7411@gmail.com>
Co-authored-by: Jules <jules-ai-assistant@users.noreply.github.com>

* Fix: Allow re-installation of components and correct validation logic

This commit fixes a bug that prevented new MCP servers from being installed on subsequent runs of the installer. It also fixes the validation logic that was causing failures after a partial installation.

The key changes are:
1.  A new `is_reinstallable` method has been added to the base `Component` class. This allows certain components (like the `mcp` component) to be re-run even if they are already marked as installed.
2.  The installer logic has been updated to respect this new method.
3.  The `MCPComponent` now correctly stores only the installed servers in the metadata.
4.  The validation logic for `MCPComponent` and `MCPDocsComponent` has been corrected to prevent incorrect failures.

New tests have been added to verify all aspects of the new logic.

Co-authored-by: Mithun Gowda B <mithungowda.b7411@gmail.com>
Co-authored-by: Jules <jules-ai-assistant@users.noreply.github.com>

* feat: Display authors in UI header and update author info

This commit implements the user's request to display author names and emails in the UI header of the installer.

The key changes are:
1.  The `__email__` field in `SuperClaude/__init__.py` has been updated to include both authors' emails.
2.  The `display_header` function in `setup/utils/ui.py` has been modified to read the author and email information and display it.
3.  A new test has been added to `tests/test_ui.py` to verify the new UI output.

Co-authored-by: Mithun Gowda B <mithungowda.b7411@gmail.com>
Co-authored-by: Jules <jules-ai-assistant@users.noreply.github.com>

* feat: Version bump to 4.1.0 and various fixes

This commit prepares the project for the v4.1.0 release. It includes a version bump across all relevant files and incorporates several bug fixes and feature enhancements from recent tasks.

Key changes in this release:

- **Version Bump**: The project version has been updated from 4.0.9 to 4.1.0 in all configuration files, documentation, and source code.

- **Installer Fixes**:
  - Components can now be marked as `reinstallable`, allowing them to be re-run on subsequent installations. This fixes a bug where new MCP servers could not be added.
  - The validation logic for `mcp` and `mcp_docs` components has been corrected to avoid incorrect failures.
  - A bug in the backup creation process that created invalid empty archives has been fixed.

- **UI Enhancements**:
  - Author names and emails are now displayed in the installer UI header.

- **Metadata Updates**:
  - Mithun Gowda B has been added as an author.

- **New Tests**:
  - Comprehensive tests have been added for the installer logic, MCP components, and UI changes to ensure correctness and prevent regressions.

Co-authored-by: Mithun Gowda B <mithungowda.b7411@gmail.com>
Co-authored-by: Jules <jules-ai-assistant@users.noreply.github.com>

* fix: Resolve dependencies for partial installs and other fixes

This commit addresses several issues, the main one being a dependency resolution failure during partial installations.

Key changes:
- **Dependency Resolution**: The installer now correctly resolves the full dependency tree when a user requests to install a subset of components. This fixes the "Unknown component: core" error.
- **Component Re-installation**: A new `is_reinstallable` flag allows components like `mcp` to be re-run on subsequent installs, enabling the addition of new servers.
- **Validation Logic**: The validation for `mcp` and `mcp_docs` has been corrected to avoid spurious failures.
- **UI and Metadata**: Author information has been added to the UI header and source files.
- **Version Bump**: The project version has been updated to 4.1.0.
- **Tests**: New tests have been added to cover all the above changes.

Co-authored-by: Mithun Gowda B <mithungowda.b7411@gmail.com>
Co-authored-by: Jules <jules-ai-assistant@users.noreply.github.com>

* fix: Installer fixes and version bump to 4.1.0

This commit includes a collection of fixes for the installer logic, UI enhancements, and a version bump to 4.1.0.

Key changes:
- **Dependency Resolution**: The installer now correctly resolves the full dependency tree for partial installations, fixing the "Unknown component: core" error.
- **Component Re-installation**: A new `is_reinstallable` flag allows components like `mcp` to be re-run to add new servers.
- **MCP Installation**: The non-interactive installation of the `mcp` component now correctly prompts the user to select servers.
- **Validation Logic**: The post-installation validation logic has been corrected to only validate components from the current session and to use the correct list of installed servers.
- **UI & Metadata**: Author information has been added to the UI and source files.
- **Version Bump**: The project version has been updated from 4.0.9 to 4.1.0 across all files.
- **Tests**: New tests have been added to cover all the bug fixes.

Co-authored-by: Mithun Gowda B <mithungowda.b7411@gmail.com>
Co-authored-by: Jules <jules-ai-assistant@users.noreply.github.com>

* feat: Add --authors flag and multiple installer fixes

This commit introduces the `--authors` flag to display author information and includes a collection of fixes for the installer logic.

Key changes:
- **New Feature**: Added an `--authors` flag that displays the names, emails, and GitHub usernames of the project authors.
- **Dependency Resolution**: Fixed a critical bug where partial installations would fail due to unresolved dependencies.
- **Component Re-installation**: Added a mechanism to allow components to be "reinstallable", fixing an issue that prevented adding new MCP servers on subsequent runs.
- **MCP Installation**: The non-interactive installation of the `mcp` component now correctly prompts for server selection.
- **Validation Logic**: Corrected the post-installation validation to prevent spurious errors.
- **Version Bump**: The project version has been updated to 4.1.0.
- **Metadata**: Author and GitHub information has been added to the source files.
- **UI**: The installer header now displays author information.
- **Tests**: Added new tests for all new features and bug fixes.


Co-authored-by: Jules <jules-ai-assistant@users.noreply.github.com>

---------
Co-authored-by: Mithun Gowda B <mithungowda.b7411@gmail.com>
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Co-authored-by: Jules <jules-ai-assistant@users.noreply.github.com>
This commit is contained in:
Mithun Gowda B
2025-09-13 17:28:52 +05:30
committed by GitHub
parent caf94facc4
commit fb609c6a06
34 changed files with 521 additions and 86 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
setup/__init__.py
View File

@@ -8,9 +8,9 @@ from pathlib import Path
try:
__version__ = (Path(__file__).parent.parent / "VERSION").read_text().strip()
except Exception:
__version__ = "4.0.9" # Fallback
__version__ = "4.1.0" # Fallback
__author__ = "NomenAK"
__author__ = "NomenAK, Mithun Gowda B"
# Core paths
SETUP_DIR = Path(__file__).parent

2
setup/cli/base.py
View File

@@ -10,7 +10,7 @@ from pathlib import Path
try:
__version__ = (Path(__file__).parent.parent.parent / "VERSION").read_text().strip()
except Exception:
__version__ = "4.0.9" # Fallback
__version__ = "4.1.0" # Fallback
def get_command_info():

41
setup/cli/commands/install.py
View File

@@ -121,8 +121,22 @@ def get_components_to_install(args: argparse.Namespace, registry: ComponentRegis
# Explicit components specified
if args.components:
if 'all' in args.components:
return ["core", "commands", "agents", "modes", "mcp", "mcp_docs"]
return args.components
components = ["core", "commands", "agents", "modes", "mcp", "mcp_docs"]
else:
components = args.components
# If mcp is specified non-interactively, we should still ask which servers to install.
if 'mcp' in components:
selected_servers = select_mcp_servers(registry)
if not hasattr(config_manager, '_installation_context'):
config_manager._installation_context = {}
config_manager._installation_context["selected_mcp_servers"] = selected_servers
# If the user selected some servers, but didn't select mcp_docs, add it.
if selected_servers and 'mcp_docs' not in components:
components.append('mcp_docs')
return components
# Interactive two-stage selection
return interactive_component_selection(registry, config_manager)
@@ -446,8 +460,8 @@ def perform_installation(components: List[str], args: argparse.Namespace, config
# Register components with installer
installer.register_components(list(component_instances.values()))
# Resolve dependencies
ordered_components = registry.resolve_dependencies(components)
# The 'components' list is already resolved, so we can use it directly.
ordered_components = components
# Setup progress tracking
progress = ProgressBar(
@@ -609,13 +623,20 @@ def run(args: argparse.Namespace) -> int:
return 1
# Get components to install
components = get_components_to_install(args, registry, config_manager)
if not components:
components_to_install = get_components_to_install(args, registry, config_manager)
if not components_to_install:
logger.error("No components selected for installation")
return 1
# Resolve dependencies
try:
resolved_components = registry.resolve_dependencies(components_to_install)
except ValueError as e:
logger.error(f"Dependency resolution error: {e}")
return 1
# Validate system requirements
if not validate_system_requirements(validator, components):
# Validate system requirements for all components
if not validate_system_requirements(validator, resolved_components):
if not args.force:
logger.error("System requirements not met. Use --force to override.")
return 1
@@ -632,7 +653,7 @@ def run(args: argparse.Namespace) -> int:
# Display installation plan
if not args.quiet:
display_installation_plan(components, registry, args.install_dir)
display_installation_plan(resolved_components, registry, args.install_dir)
if not args.dry_run:
if not args.yes and not confirm("Proceed with installation?", default=True):
@@ -640,7 +661,7 @@ def run(args: argparse.Namespace) -> int:
return 0
# Perform installation
success = perform_installation(components, args, config_manager)
success = perform_installation(resolved_components, args, config_manager)
if success:
if not args.quiet:

64
setup/components/mcp.py
View File

@@ -18,6 +18,7 @@ class MCPComponent(Component):
def __init__(self, install_dir: Optional[Path] = None):
"""Initialize MCP component"""
super().__init__(install_dir)
self.installed_servers_in_session: List[str] = []
# Define MCP servers to install
self.mcp_servers = {
@@ -73,6 +74,10 @@ class MCPComponent(Component):
"description": "MCP server integration (Context7, Sequential, Magic, Playwright)",
"category": "integration"
}
def is_reinstallable(self) -> bool:
"""This component manages sub-components (servers) and should be re-run."""
return True
def validate_prerequisites(self, installSubPath: Optional[Path] = None) -> Tuple[bool, List[str]]:
"""Check prerequisites"""
@@ -150,12 +155,12 @@ class MCPComponent(Component):
"mcp": {
"version": __version__,
"installed": True,
"servers_count": len(self.mcp_servers)
"servers_count": len(self.installed_servers_in_session)
}
},
"mcp": {
"enabled": True,
"servers": list(self.mcp_servers.keys()),
"servers": self.installed_servers_in_session,
"auto_update": False
}
}
@@ -362,20 +367,35 @@ class MCPComponent(Component):
self.logger.error(error)
return False
# Install each MCP server
# Get selected servers from config
selected_servers = config.get("selected_mcp_servers", [])
if not selected_servers:
self.logger.info("No MCP servers selected for installation.")
return self._post_install()
self.logger.info(f"Installing selected MCP servers: {', '.join(selected_servers)}")
# Install each selected MCP server
installed_count = 0
failed_servers = []
self.installed_servers_in_session = []
for server_name, server_info in self.mcp_servers.items():
if self._install_mcp_server(server_info, config):
installed_count += 1
for server_name in selected_servers:
if server_name in self.mcp_servers:
server_info = self.mcp_servers[server_name]
if self._install_mcp_server(server_info, config):
installed_count += 1
self.installed_servers_in_session.append(server_name)
else:
failed_servers.append(server_name)
# Check if this is a required server
if server_info.get("required", False):
self.logger.error(f"Required MCP server {server_name} failed to install")
return False
else:
failed_servers.append(server_name)
# Check if this is a required server
if server_info.get("required", False):
self.logger.error(f"Required MCP server {server_name} failed to install")
return False
self.logger.warning(f"Unknown MCP server '{server_name}' selected for installation.")
# Verify installation
if not config.get("dry_run", False):
@@ -539,7 +559,7 @@ class MCPComponent(Component):
if installed_version != expected_version:
errors.append(f"Version mismatch: installed {installed_version}, expected {expected_version}")
# Check if Claude CLI is available
# Check if Claude CLI is available and validate installed servers
try:
result = subprocess.run(
["claude", "mcp", "list"],
@@ -548,17 +568,19 @@ class MCPComponent(Component):
timeout=60,
shell=(sys.platform == "win32")
)
if result.returncode != 0:
errors.append("Could not communicate with Claude CLI for MCP server verification")
else:
# Check if required servers are installed
output = result.stdout.lower()
for server_name, server_info in self.mcp_servers.items():
if server_info.get("required", False):
if server_name.lower() not in output:
errors.append(f"Required MCP server not found: {server_name}")
claude_mcp_output = result.stdout.lower()
# Get the list of servers that should be installed from metadata
installed_servers = self.settings_manager.get_metadata_setting("mcp.servers", [])
for server_name in installed_servers:
if server_name.lower() not in claude_mcp_output:
errors.append(f"Installed MCP server '{server_name}' not found in 'claude mcp list' output.")
except Exception as e:
errors.append(f"Could not verify MCP server installation: {e}")

12
setup/components/mcp_docs.py
View File

@@ -87,14 +87,12 @@ class MCPDocsComponent(Component):
# Get selected servers from config
selected_servers = config.get("selected_mcp_servers", [])
self.set_selected_servers(selected_servers)
self.component_files = self._discover_component_files()
if not selected_servers:
self.logger.info("No MCP servers selected - skipping documentation installation")
return True
self.set_selected_servers(selected_servers)
# Update component files based on selection
self.component_files = self._discover_component_files()
return self._post_install()
# Validate installation
success, errors = self.validate_prerequisites()
@@ -108,7 +106,7 @@ class MCPDocsComponent(Component):
if not files_to_install:
self.logger.warning("No MCP documentation files found to install")
return True # Not an error - just no docs to install
return self._post_install()
# Copy documentation files
success_count = 0

7
setup/core/base.py
View File

@@ -45,6 +45,13 @@ class Component(ABC):
- category: Component category (core, command, integration, etc.)
"""
pass
def is_reinstallable(self) -> bool:
"""
Whether this component should be re-installed if already present.
Useful for container-like components that can install sub-parts.
"""
return False
def validate_prerequisites(self, installSubPath: Optional[Path] = None) -> Tuple[bool, List[str]]:
"""

27
setup/core/installer.py
View File

@@ -172,16 +172,13 @@ class Installer:
# Log warning but continue backup process
self.logger.warning(f"Could not backup {item.name}: {e}")
# Create archive only if there are files to backup
if any(temp_backup.iterdir()):
# shutil.make_archive adds .tar.gz automatically, so use base name without extensions
base_path = backup_dir / backup_name
shutil.make_archive(str(base_path), 'gztar', temp_backup)
else:
# Create empty backup file to indicate backup was attempted
backup_path.touch()
# Always create an archive, even if empty, to ensure it's a valid tarball
base_path = backup_dir / backup_name
shutil.make_archive(str(base_path), 'gztar', temp_backup)
if not any(temp_backup.iterdir()):
self.logger.warning(
f"No files to backup, created empty backup marker: {backup_path.name}"
f"No files to backup, created empty backup archive: {backup_path.name}"
)
self.backup_path = backup_path
@@ -204,8 +201,10 @@ class Installer:
component = self.components[component_name]
# Skip if already installed and not in update mode
if component_name in self.installed_components and not config.get("update_mode"):
# Skip if already installed and not in update mode, unless component is reinstallable
if not component.is_reinstallable() and component_name in self.installed_components and not config.get("update_mode"):
self.skipped_components.add(component_name)
self.logger.info(f"Skipping already installed component: {component_name}")
return True
# Check prerequisites
@@ -295,7 +294,11 @@ class Installer:
self.logger.info("Running post-installation validation...")
all_valid = True
for name in self.installed_components:
for name in self.updated_components:
if name not in self.components:
self.logger.warning(f"Cannot validate component '{name}' as it was not part of this installation session.")
continue
component = self.components[name]
success, errors = component.validate_installation()

12
setup/data/features.json
View File

@@ -2,7 +2,7 @@
"components": {
"core": {
"name": "core",
"version": "4.0.9",
"version": "4.1.0",
"description": "SuperClaude framework documentation and core files",
"category": "core",
"dependencies": [],
@@ -11,7 +11,7 @@
},
"commands": {
"name": "commands",
"version": "4.0.9",
"version": "4.1.0",
"description": "SuperClaude slash command definitions",
"category": "commands",
"dependencies": ["core"],
@@ -20,7 +20,7 @@
},
"mcp": {
"name": "mcp",
"version": "4.0.9",
"version": "4.1.0",
"description": "MCP server configuration management via .claude.json",
"category": "integration",
"dependencies": ["core"],
@@ -29,7 +29,7 @@
},
"modes": {
"name": "modes",
"version": "4.0.9",
"version": "4.1.0",
"description": "SuperClaude behavioral modes (Brainstorming, Introspection, Task Management, Token Efficiency)",
"category": "modes",
"dependencies": ["core"],
@@ -38,7 +38,7 @@
},
"mcp_docs": {
"name": "mcp_docs",
"version": "4.0.9",
"version": "4.1.0",
"description": "MCP server documentation and usage guides",
"category": "documentation",
"dependencies": ["core"],
@@ -47,7 +47,7 @@
},
"agents": {
"name": "agents",
"version": "4.0.9",
"version": "4.1.0",
"description": "14 specialized AI agents with domain expertise and intelligent routing",
"category": "agents",
"dependencies": ["core"],

41
setup/utils/ui.py
View File

@@ -271,13 +271,54 @@ def display_header(title: str, subtitle: str = '') -> None:
title: Main title
subtitle: Optional subtitle
"""
from SuperClaude import __author__, __email__
print(f"\n{Colors.CYAN}{Colors.BRIGHT}{'='*60}{Colors.RESET}")
print(f"{Colors.CYAN}{Colors.BRIGHT}{title:^60}{Colors.RESET}")
if subtitle:
print(f"{Colors.WHITE}{subtitle:^60}{Colors.RESET}")
# Display authors
authors = [a.strip() for a in __author__.split(',')]
emails = [e.strip() for e in __email__.split(',')]
author_lines = []
for i in range(len(authors)):
name = authors[i]
email = emails[i] if i < len(emails) else ''
author_lines.append(f"{name} <{email}>")
authors_str = " | ".join(author_lines)
print(f"{Colors.BLUE}{authors_str:^60}{Colors.RESET}")
print(f"{Colors.CYAN}{Colors.BRIGHT}{'='*60}{Colors.RESET}\n")
def display_authors() -> None:
"""Display author information"""
from SuperClaude import __author__, __email__, __github__
print(f"\n{Colors.CYAN}{Colors.BRIGHT}{'='*60}{Colors.RESET}")
print(f"{Colors.CYAN}{Colors.BRIGHT}{'SuperClaude Authors':^60}{Colors.RESET}")
print(f"{Colors.CYAN}{Colors.BRIGHT}{'='*60}{Colors.RESET}\n")
authors = [a.strip() for a in __author__.split(',')]
emails = [e.strip() for e in __email__.split(',')]
github_users = [g.strip() for g in __github__.split(',')]
for i in range(len(authors)):
name = authors[i]
email = emails[i] if i < len(emails) else 'N/A'
github = github_users[i] if i < len(github_users) else 'N/A'
print(f" {Colors.BRIGHT}{name}{Colors.RESET}")
print(f" Email: {Colors.YELLOW}{email}{Colors.RESET}")
print(f" GitHub: {Colors.YELLOW}https://github.com/{github}{Colors.RESET}")
print()
print(f"{Colors.CYAN}{'='*60}{Colors.RESET}\n")
def display_info(message: str) -> None:
"""Display info message"""
print(f"{Colors.BLUE}[INFO] {message}{Colors.RESET}")