External/SuperClaude
1
0
Fork 0
mirror of https://github.com/SuperClaude-Org/SuperClaude_Framework.git synced 2025-12-29 16:16:08 +00:00
Code Issues Packages Projects Releases Wiki Activity

Revert "feat: comprehensive framework improvements (#447)"

Browse Source 
This reverts commit 00706f0ea9.
This commit is contained in:
Mithun Gowda B
2025-10-21 09:48:04 +05:30
committed by GitHub
parent 1aa4039f9c
commit 73fe01c4be
52 changed files with 6488 additions and 3278 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
setup/cli/commands/install.py
View File

@@ -138,7 +138,7 @@ def get_components_to_install(
# Explicit components specified
if args.components:
if "all" in args.components:
components = ["knowledge_base", "commands", "agents", "modes", "mcp"]
components = ["framework_docs", "commands", "agents", "modes", "mcp"]
else:
components = args.components
@@ -302,7 +302,7 @@ def select_framework_components(
try:
# Framework components (excluding MCP-related ones)
framework_components = ["knowledge_base", "modes", "commands", "agents"]
framework_components = ["framework_docs", "modes", "commands", "agents"]
# Create component menu
component_options = []
@@ -334,9 +334,9 @@ def select_framework_components(
selections = menu.display()
if not selections:
# Default to knowledge_base if nothing selected
logger.info("No components selected, defaulting to knowledge_base")
selected_components = ["knowledge_base"]
# Default to framework_docs if nothing selected
logger.info("No components selected, defaulting to framework_docs")
selected_components = ["framework_docs"]
else:
selected_components = []
all_components = framework_components
@@ -354,7 +354,7 @@ def select_framework_components(
except Exception as e:
logger.error(f"Error in framework component selection: {e}")
return ["knowledge_base"] # Fallback to knowledge_base
return ["framework_docs"] # Fallback to framework_docs
def interactive_component_selection(

31
setup/components/__init__.py
View File

@@ -1,24 +1,15 @@
"""
Component Directory
"""Component implementations for SuperClaude installation system"""
Each module defines an installable responsibility unit:
- knowledge_base: Framework knowledge initialization
- behavior_modes: Execution mode definitions
- agent_personas: AI agent personality definitions
- slash_commands: CLI command registration
- mcp_integration: External tool integration via MCP
"""
from .knowledge_base import KnowledgeBaseComponent
from .behavior_modes import BehaviorModesComponent
from .agent_personas import AgentPersonasComponent
from .slash_commands import SlashCommandsComponent
from .mcp_integration import MCPIntegrationComponent
from .framework_docs import FrameworkDocsComponent
from .commands import CommandsComponent
from .mcp import MCPComponent
from .agents import AgentsComponent
from .modes import ModesComponent
__all__ = [
"KnowledgeBaseComponent",
"BehaviorModesComponent",
"AgentPersonasComponent",
"SlashCommandsComponent",
"MCPIntegrationComponent",
"FrameworkDocsComponent",
"CommandsComponent",
"MCPComponent",
"AgentsComponent",
"ModesComponent",
]

9
setup/components/agent_personas.py → setup/components/agents.py
View File

@@ -1,8 +1,5 @@
"""
Agent Personas Component
Responsibility: Defines AI agent personalities and role-based behaviors.
Provides specialized personas for different task types.
Agents component for SuperClaude specialized AI agents installation
"""
from typing import Dict, List, Tuple, Optional, Any
@@ -12,7 +9,7 @@ from ..core.base import Component
from setup import __version__
class AgentPersonasComponent(Component):
class AgentsComponent(Component):
"""SuperClaude specialized AI agents component"""
def __init__(self, install_dir: Optional[Path] = None):
@@ -136,7 +133,7 @@ class AgentPersonasComponent(Component):
def get_dependencies(self) -> List[str]:
"""Get component dependencies"""
return ["knowledge_base"]
return ["framework_docs"]
def update(self, config: Dict[str, Any]) -> bool:
"""

69
setup/components/slash_commands.py → setup/components/commands.py
View File

@@ -1,8 +1,5 @@
"""
Slash Commands Component
Responsibility: Registers and manages slash commands for CLI interactions.
Provides custom command definitions and execution logic.
Commands component for SuperClaude slash command definitions
"""
from typing import Dict, List, Tuple, Optional, Any
@@ -12,7 +9,7 @@ from ..core.base import Component
from setup import __version__
class SlashCommandsComponent(Component):
class CommandsComponent(Component):
"""SuperClaude slash commands component"""
def __init__(self, install_dir: Optional[Path] = None):
@@ -183,7 +180,7 @@ class SlashCommandsComponent(Component):
def get_dependencies(self) -> List[str]:
"""Get dependencies"""
return ["knowledge_base"]
return ["framework_docs"]
def update(self, config: Dict[str, Any]) -> bool:
"""
@@ -284,66 +281,6 @@ class SlashCommandsComponent(Component):
project_root = Path(__file__).parent.parent.parent
return project_root / "superclaude" / "commands"
def _discover_component_files(self) -> List[str]:
"""
Discover command files including modules subdirectory
Returns:
List of relative file paths (e.g., ['pm.md', 'modules/token-counter.md'])
"""
source_dir = self._get_source_dir()
if not source_dir or not source_dir.exists():
return []
files = []
# Discover top-level .md files (slash commands)
for file_path in source_dir.iterdir():
if (
file_path.is_file()
and file_path.suffix.lower() == ".md"
and file_path.name not in ["README.md", "CHANGELOG.md", "LICENSE.md"]
):
files.append(file_path.name)
# Discover modules subdirectory files
modules_dir = source_dir / "modules"
if modules_dir.exists() and modules_dir.is_dir():
for file_path in modules_dir.iterdir():
if file_path.is_file() and file_path.suffix.lower() == ".md":
# Store as relative path: modules/token-counter.md
files.append(f"modules/{file_path.name}")
# Sort for consistent ordering
files.sort()
self.logger.debug(
f"Discovered {len(files)} command files (including modules)"
)
if files:
self.logger.debug(f"Files found: {files}")
return files
def get_files_to_install(self) -> List[Tuple[Path, Path]]:
"""
Return list of files to install, including modules subdirectory
Returns:
List of tuples (source_path, target_path)
"""
source_dir = self._get_source_dir()
files = []
if source_dir:
for filename in self.component_files:
source = source_dir / filename
target = self.install_component_subdir / filename
files.append((source, target))
return files
def get_size_estimate(self) -> int:
"""Get estimated installation size"""
total_size = 0

218
setup/components/knowledge_base.py → setup/components/framework_docs.py
View File

@@ -1,9 +1,6 @@
"""
Knowledge Base Component for SuperClaude
Responsibility: Provides structured knowledge initialization for the framework.
Manages framework knowledge documents (principles, rules, flags, research config, business patterns).
These files form the foundation of Claude's understanding of the SuperClaude framework.
Framework documentation component for SuperClaude
Manages core framework documentation files (CLAUDE.md, FLAGS.md, PRINCIPLES.md, etc.)
"""
from typing import Dict, List, Tuple, Optional, Any
@@ -15,25 +12,20 @@ from ..services.claude_md import CLAUDEMdService
from setup import __version__
class KnowledgeBaseComponent(Component):
"""
Knowledge Base Component
Responsibility: Initialize and maintain SuperClaude's knowledge base.
Installs framework knowledge documents that guide Claude's behavior and decision-making.
"""
class FrameworkDocsComponent(Component):
"""SuperClaude framework documentation files component"""
def __init__(self, install_dir: Optional[Path] = None):
"""Initialize knowledge base component"""
"""Initialize framework docs component"""
super().__init__(install_dir)
def get_metadata(self) -> Dict[str, str]:
"""Get component metadata"""
return {
"name": "knowledge_base",
"name": "framework_docs",
"version": __version__,
"description": "SuperClaude knowledge base (principles, rules, flags, patterns)",
"category": "knowledge",
"description": "SuperClaude framework documentation (CLAUDE.md, FLAGS.md, PRINCIPLES.md, RULES.md, etc.)",
"category": "documentation",
}
def is_reinstallable(self) -> bool:
@@ -43,74 +35,6 @@ class KnowledgeBaseComponent(Component):
"""
return True
def validate_prerequisites(
self, installSubPath: Optional[Path] = None
) -> Tuple[bool, List[str]]:
"""
Check prerequisites for framework docs component (multi-directory support)
Returns:
Tuple of (success: bool, error_messages: List[str])
"""
from ..utils.security import SecurityValidator
errors = []
# Check if all source directories exist
for source_dir in self._get_source_dirs():
if not source_dir.exists():
errors.append(f"Source directory not found: {source_dir}")
# Check if all required framework files exist
missing_files = []
for source, _ in self.get_files_to_install():
if not source.exists():
missing_files.append(str(source.relative_to(Path(__file__).parent.parent.parent / "superclaude")))
if missing_files:
errors.append(f"Missing component files: {missing_files}")
# Check write permissions to install directory
has_perms, missing = SecurityValidator.check_permissions(
self.install_dir, {"write"}
)
if not has_perms:
errors.append(f"No write permissions to {self.install_dir}: {missing}")
# Validate installation target
is_safe, validation_errors = SecurityValidator.validate_installation_target(
self.install_component_subdir
)
if not is_safe:
errors.extend(validation_errors)
# Validate files individually (each file with its own source dir)
for source, target in self.get_files_to_install():
# Get the appropriate base source directory for this file
source_parent = source.parent
# Validate source path
is_safe, msg = SecurityValidator.validate_path(source, source_parent)
if not is_safe:
errors.append(f"Invalid source path {source}: {msg}")
# Validate target path
is_safe, msg = SecurityValidator.validate_path(target, self.install_component_subdir)
if not is_safe:
errors.append(f"Invalid target path {target}: {msg}")
# Validate file extension
is_allowed, msg = SecurityValidator.validate_file_extension(source)
if not is_allowed:
errors.append(f"File {source}: {msg}")
if not self.file_manager.ensure_directory(self.install_component_subdir):
errors.append(
f"Could not create install directory: {self.install_component_subdir}"
)
return len(errors) == 0, errors
def get_metadata_modifications(self) -> Dict[str, Any]:
"""Get metadata modifications for SuperClaude"""
return {
@@ -119,7 +43,7 @@ class KnowledgeBaseComponent(Component):
"name": "superclaude",
"description": "AI-enhanced development framework for Claude Code",
"installation_type": "global",
"components": ["knowledge_base"],
"components": ["framework_docs"],
},
"superclaude": {
"enabled": True,
@@ -130,8 +54,8 @@ class KnowledgeBaseComponent(Component):
}
def _install(self, config: Dict[str, Any]) -> bool:
"""Install knowledge base component"""
self.logger.info("Installing SuperClaude knowledge base...")
"""Install framework docs component"""
self.logger.info("Installing SuperClaude framework documentation...")
return super()._install(config)
@@ -144,7 +68,7 @@ class KnowledgeBaseComponent(Component):
# Add component registration to metadata (with file list for sync)
self.settings_manager.add_component_registration(
"knowledge_base",
"framework_docs",
{
"version": __version__,
"category": "documentation",
@@ -153,7 +77,7 @@ class KnowledgeBaseComponent(Component):
},
)
self.logger.info("Updated metadata with knowledge base component registration")
self.logger.info("Updated metadata with framework docs component registration")
# Migrate any existing SuperClaude data from settings.json
if self.settings_manager.migrate_superclaude_data():
@@ -185,24 +109,24 @@ class KnowledgeBaseComponent(Component):
return True
def uninstall(self) -> bool:
"""Uninstall knowledge base component"""
"""Uninstall framework docs component"""
try:
self.logger.info("Uninstalling SuperClaude knowledge base component...")
self.logger.info("Uninstalling SuperClaude framework docs component...")
# Remove framework files
removed_count = 0
for filename in self.component_files:
file_path = self.install_component_subdir / filename
file_path = self.install_dir / filename
if self.file_manager.remove_file(file_path):
removed_count += 1
self.logger.debug(f"Removed {filename}")
else:
self.logger.warning(f"Could not remove {filename}")
# Update metadata to remove knowledge base component
# Update metadata to remove framework docs component
try:
if self.settings_manager.is_component_installed("knowledge_base"):
self.settings_manager.remove_component_registration("knowledge_base")
if self.settings_manager.is_component_installed("framework_docs"):
self.settings_manager.remove_component_registration("framework_docs")
metadata_mods = self.get_metadata_modifications()
metadata = self.settings_manager.load_metadata()
for key in metadata_mods.keys():
@@ -210,7 +134,7 @@ class KnowledgeBaseComponent(Component):
del metadata[key]
self.settings_manager.save_metadata(metadata)
self.logger.info("Removed knowledge base component from metadata")
self.logger.info("Removed framework docs component from metadata")
except Exception as e:
self.logger.warning(f"Could not update metadata: {e}")
@@ -220,26 +144,26 @@ class KnowledgeBaseComponent(Component):
return True
except Exception as e:
self.logger.exception(f"Unexpected error during knowledge base uninstallation: {e}")
self.logger.exception(f"Unexpected error during framework docs uninstallation: {e}")
return False
def get_dependencies(self) -> List[str]:
"""Get component dependencies (knowledge base has none)"""
"""Get component dependencies (framework docs has none)"""
return []
def update(self, config: Dict[str, Any]) -> bool:
"""
Sync knowledge base component (overwrite + delete obsolete files).
Sync framework docs component (overwrite + delete obsolete files).
No backup needed - SuperClaude source files are always authoritative.
"""
try:
self.logger.info("Syncing SuperClaude knowledge base component...")
self.logger.info("Syncing SuperClaude framework docs component...")
# Get previously installed files from metadata
metadata = self.settings_manager.load_metadata()
previous_files = set(
metadata.get("components", {})
.get("knowledge_base", {})
.get("framework_docs", {})
.get("files", [])
)
@@ -252,7 +176,7 @@ class KnowledgeBaseComponent(Component):
# Delete obsolete files
deleted_count = 0
for filename in files_to_delete:
file_path = self.install_component_subdir / filename
file_path = self.install_dir / filename
if file_path.exists():
try:
file_path.unlink()
@@ -267,7 +191,7 @@ class KnowledgeBaseComponent(Component):
if success:
# Update metadata with current file list
self.settings_manager.add_component_registration(
"knowledge_base",
"framework_docs",
{
"version": __version__,
"category": "documentation",
@@ -285,27 +209,27 @@ class KnowledgeBaseComponent(Component):
return success
except Exception as e:
self.logger.exception(f"Unexpected error during knowledge base sync: {e}")
self.logger.exception(f"Unexpected error during framework docs sync: {e}")
return False
def validate_installation(self) -> Tuple[bool, List[str]]:
"""Validate knowledge base component installation"""
"""Validate framework docs component installation"""
errors = []
# Check if all framework files exist
for filename in self.component_files:
file_path = self.install_component_subdir / filename
file_path = self.install_dir / filename
if not file_path.exists():
errors.append(f"Missing framework file: {filename}")
elif not file_path.is_file():
errors.append(f"Framework file is not a regular file: {filename}")
# Check metadata registration
if not self.settings_manager.is_component_installed("knowledge_base"):
errors.append("Knowledge base component not registered in metadata")
if not self.settings_manager.is_component_installed("framework_docs"):
errors.append("Framework docs component not registered in metadata")
else:
# Check version matches
installed_version = self.settings_manager.get_component_version("knowledge_base")
installed_version = self.settings_manager.get_component_version("framework_docs")
expected_version = self.get_metadata()["version"]
if installed_version != expected_version:
errors.append(
@@ -327,78 +251,22 @@ class KnowledgeBaseComponent(Component):
return len(errors) == 0, errors
def _get_source_dirs(self):
"""Get source directories for framework documentation files"""
# Assume we're in superclaude/setup/components/framework_docs.py
# Framework files are organized in superclaude/{framework,business,research}
project_root = Path(__file__).parent.parent.parent
return [
project_root / "superclaude" / "framework",
project_root / "superclaude" / "business",
project_root / "superclaude" / "research",
]
def _get_source_dir(self):
"""Get source directory (compatibility method, returns first directory)"""
dirs = self._get_source_dirs()
return dirs[0] if dirs else None
def _discover_component_files(self) -> List[str]:
"""
Discover framework .md files across multiple directories
Returns:
List of relative paths (e.g., ['framework/flags.md', 'business/examples.md'])
"""
all_files = []
project_root = Path(__file__).parent.parent.parent / "superclaude"
for source_dir in self._get_source_dirs():
if not source_dir.exists():
self.logger.warning(f"Source directory not found: {source_dir}")
continue
# Get directory name relative to superclaude/
dir_name = source_dir.relative_to(project_root)
# Discover .md files in this directory
files = self._discover_files_in_directory(
source_dir,
extension=".md",
exclude_patterns=["README.md", "CHANGELOG.md", "LICENSE.md"],
)
# Add directory prefix to each file
for file in files:
all_files.append(str(dir_name / file))
return all_files
def get_files_to_install(self) -> List[Tuple[Path, Path]]:
"""
Return list of files to install from multiple source directories
Returns:
List of tuples (source_path, target_path)
"""
files = []
project_root = Path(__file__).parent.parent.parent / "superclaude"
for relative_path in self.component_files:
source = project_root / relative_path
# Install to superclaude/ subdirectory structure
target = self.install_component_subdir / relative_path
files.append((source, target))
return files
"""Get source directory for framework documentation files"""
# Assume we're in superclaude/setup/components/framework_docs.py
# and framework files are in superclaude/superclaude/core/
project_root = Path(__file__).parent.parent.parent
return project_root / "superclaude" / "core"
def get_size_estimate(self) -> int:
"""Get estimated installation size"""
total_size = 0
source_dir = self._get_source_dir()
for source, _ in self.get_files_to_install():
if source.exists():
total_size += source.stat().st_size
for filename in self.component_files:
file_path = source_dir / filename
if file_path.exists():
total_size += file_path.stat().st_size
# Add overhead for settings.json and directories
total_size += 10240 # ~10KB overhead

13
setup/components/mcp_integration.py → setup/components/mcp.py
View File

@@ -1,8 +1,5 @@
"""
MCP Integration Component
Responsibility: Integrates Model Context Protocol for external tool access.
Manages connections to specialized MCP servers and capabilities.
MCP component for MCP server integration
"""
import os
@@ -18,7 +15,7 @@ from setup import __version__
from ..core.base import Component
class MCPIntegrationComponent(Component):
class MCPComponent(Component):
"""MCP servers integration component"""
def __init__(self, install_dir: Optional[Path] = None):
@@ -34,8 +31,8 @@ class MCPIntegrationComponent(Component):
"name": "airis-mcp-gateway",
"description": "Unified MCP Gateway with all tools (sequential-thinking, context7, magic, playwright, serena, morphllm, tavily, chrome-devtools, git, puppeteer)",
"install_method": "github",
"install_command": "uvx --from git+https://github.com/agiletec-inc/airis-mcp-gateway airis-mcp-gateway --help",
"run_command": "uvx --from git+https://github.com/agiletec-inc/airis-mcp-gateway airis-mcp-gateway",
"install_command": "uvx --from git+https://github.com/oraios/airis-mcp-gateway airis-mcp-gateway --help",
"run_command": "uvx --from git+https://github.com/oraios/airis-mcp-gateway airis-mcp-gateway",
"required": True,
},
}
@@ -944,7 +941,7 @@ class MCPIntegrationComponent(Component):
def get_dependencies(self) -> List[str]:
"""Get dependencies"""
return ["knowledge_base"]
return ["framework_docs"]
def update(self, config: Dict[str, Any]) -> bool:
"""Update MCP component"""

16
setup/components/behavior_modes.py → setup/components/modes.py
View File

@@ -1,8 +1,5 @@
"""
Behavior Modes Component
Responsibility: Defines and manages execution modes for Claude behavior.
Controls how Claude responds to different contexts and user intent.
Modes component for SuperClaude behavioral modes
"""
from typing import Dict, List, Tuple, Optional, Any
@@ -13,12 +10,12 @@ from setup import __version__
from ..services.claude_md import CLAUDEMdService
class BehaviorModesComponent(Component):
class ModesComponent(Component):
"""SuperClaude behavioral modes component"""
def __init__(self, install_dir: Optional[Path] = None):
"""Initialize modes component"""
super().__init__(install_dir, Path("modes"))
super().__init__(install_dir, Path(""))
def get_metadata(self) -> Dict[str, str]:
"""Get component metadata"""
@@ -94,11 +91,10 @@ class BehaviorModesComponent(Component):
self.settings_manager.update_metadata(metadata_mods)
self.logger.info("Updated metadata with modes component registration")
# Update CLAUDE.md with mode imports (include modes/ prefix)
# Update CLAUDE.md with mode imports
try:
manager = CLAUDEMdService(self.install_dir)
mode_files_with_path = [f"modes/{f}" for f in self.component_files]
manager.add_imports(mode_files_with_path, category="Behavioral Modes")
manager.add_imports(self.component_files, category="Behavioral Modes")
self.logger.info("Updated CLAUDE.md with mode imports")
except Exception as e:
self.logger.warning(
@@ -152,7 +148,7 @@ class BehaviorModesComponent(Component):
def get_dependencies(self) -> List[str]:
"""Get dependencies"""
return ["knowledge_base"]
return ["framework_docs"]
def update(self, config: Dict[str, Any]) -> bool:
"""

2
setup/core/installer.py
View File

@@ -149,7 +149,7 @@ class Installer:
# Framework components are ALWAYS updated to latest version
# These are SuperClaude implementation files, not user configurations
framework_components = {'knowledge_base', 'agents', 'commands', 'modes', 'core', 'mcp'}
framework_components = {'framework_docs', 'agents', 'commands', 'modes', 'core', 'mcp'}
if component_name in framework_components:
# Always update framework components to latest version