mirror of
https://github.com/SuperClaude-Org/SuperClaude_Framework.git
synced 2025-12-29 16:16:08 +00:00
refactor: PEP8 compliance - directory rename and code formatting (#425)
* fix(orchestration): add WebFetch auto-trigger for infrastructure configuration Problem: Infrastructure configuration changes (e.g., Traefik port settings) were being made based on assumptions without consulting official documentation, violating the 'Evidence > assumptions' principle in PRINCIPLES.md. Solution: - Added Infrastructure Configuration Validation section to MODE_Orchestration.md - Auto-triggers WebFetch for infrastructure tools (Traefik, nginx, Docker, etc.) - Enforces MODE_DeepResearch activation for investigation - BLOCKS assumption-based configuration changes Testing: Verified WebFetch successfully retrieves Traefik official docs (port 80 default) This prevents production outages from infrastructure misconfiguration by ensuring all technical recommendations are backed by official documentation. * feat: Add PM Agent (Project Manager Agent) for seamless orchestration Introduces PM Agent as the default orchestration layer that coordinates all sub-agents and manages workflows automatically. Key Features: - Default orchestration: All user interactions handled by PM Agent - Auto-delegation: Intelligent sub-agent selection based on task analysis - Docker Gateway integration: Zero-token baseline with dynamic MCP loading - Self-improvement loop: Automatic documentation of patterns and mistakes - Optional override: Users can specify sub-agents explicitly if desired Architecture: - Agent spec: SuperClaude/Agents/pm-agent.md - Command: SuperClaude/Commands/pm.md - Updated docs: README.md (15→16 agents), agents.md (new Orchestration category) User Experience: - Default: PM Agent handles everything (seamless, no manual routing) - Optional: Explicit --agent flag for direct sub-agent access - Both modes available simultaneously (no user downside) Implementation Status: - ✅ Specification complete - ✅ Documentation complete - ⏳ Prototype implementation needed - ⏳ Docker Gateway integration needed - ⏳ Testing and validation needed Refs: kazukinakai/docker-mcp-gateway (IRIS MCP Gateway integration) * feat: Add Agent Orchestration rules for PM Agent default activation Implements PM Agent as the default orchestration layer in RULES.md. Key Changes: - New 'Agent Orchestration' section (CRITICAL priority) - PM Agent receives ALL user requests by default - Manual override with @agent-[name] bypasses PM Agent - Agent Selection Priority clearly defined: 1. Manual override → Direct routing 2. Default → PM Agent → Auto-delegation 3. Delegation based on keywords, file types, complexity, context User Experience: - Default: PM Agent handles everything (seamless) - Override: @agent-[name] for direct specialist access - Transparent: PM Agent reports delegation decisions This establishes PM Agent as the orchestration layer while respecting existing auto-activation patterns and manual overrides. Next Steps: - Local testing in agiletec project - Iteration based on actual behavior - Documentation updates as needed * refactor(pm-agent): redesign as self-improvement meta-layer Problem Resolution: PM Agent's initial design competed with existing auto-activation for task routing, creating confusion about orchestration responsibilities and adding unnecessary complexity. Design Change: Redefined PM Agent as a meta-layer agent that operates AFTER specialist agents complete tasks, focusing on: - Post-implementation documentation and pattern recording - Immediate mistake analysis with prevention checklists - Monthly documentation maintenance and noise reduction - Pattern extraction and knowledge synthesis Two-Layer Orchestration System: 1. Task Execution Layer: Existing auto-activation handles task routing (unchanged) 2. Self-Improvement Layer: PM Agent meta-layer handles documentation (new) Files Modified: - SuperClaude/Agents/pm-agent.md: Complete rewrite with meta-layer design - Category: orchestration → meta - Triggers: All user interactions → Post-implementation, mistakes, monthly - Behavioral Mindset: Continuous learning system - Self-Improvement Workflow: BEFORE/DURING/AFTER/MISTAKE RECOVERY/MAINTENANCE - SuperClaude/Core/RULES.md: Agent Orchestration section updated - Split into Task Execution Layer + Self-Improvement Layer - Added orchestration flow diagram - Clarified PM Agent activates AFTER task completion - README.md: Updated PM Agent description - "orchestrates all interactions" → "ensures continuous learning" - Docs/User-Guide/agents.md: PM Agent section rewritten - Section: Orchestration Agent → Meta-Layer Agent - Expertise: Project orchestration → Self-improvement workflow executor - Examples: Task coordination → Post-implementation documentation - PR_DOCUMENTATION.md: Comprehensive PR documentation added - Summary, motivation, changes, testing, breaking changes - Two-layer orchestration system diagram - Verification checklist Integration Validated: Tested with agiletec project's self-improvement-workflow.md: ✅ PM Agent aligns with existing BEFORE/DURING/AFTER/MISTAKE RECOVERY phases ✅ Complements (not competes with) existing workflow ✅ agiletec workflow defines WHAT, PM Agent defines WHO executes it Breaking Changes: None - Existing auto-activation continues unchanged - Specialist agents unaffected - User workflows remain the same - New capability: Automatic documentation and knowledge maintenance Value Proposition: Transforms SuperClaude into a continuously learning system that accumulates knowledge, prevents recurring mistakes, and maintains fresh documentation without manual intervention. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * docs: add Claude Code conversation history management research Research covering .jsonl file structure, performance impact, and retention policies. Content: - Claude Code .jsonl file format and message types - Performance issues from GitHub (memory leaks, conversation compaction) - Retention policies (consumer vs enterprise) - Rotation recommendations based on actual data - File history snapshot tracking mechanics Source: Moved from agiletec project (research applicable to all Claude Code projects) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * feat: add Development documentation structure Phase 1: Documentation Structure complete - Add Docs/Development/ directory for development documentation - Add ARCHITECTURE.md - System architecture with PM Agent meta-layer - Add ROADMAP.md - 5-phase development plan with checkboxes - Add TASKS.md - Daily task tracking with progress indicators - Add PROJECT_STATUS.md - Current status dashboard and metrics - Add pm-agent-integration.md - Implementation guide for PM Agent mode This establishes comprehensive documentation foundation for: - System architecture understanding - Development planning and tracking - Implementation guidance - Progress visibility Related: #pm-agent-mode #documentation #phase-1 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * feat: PM Agent session lifecycle and PDCA implementation Phase 2: PM Agent Mode Integration (Design Phase) Commands/pm.md updates: - Add "Always-Active Foundation Layer" concept - Add Session Lifecycle (Session Start/During Work/Session End) - Add PDCA Cycle (Plan/Do/Check/Act) automation - Add Serena MCP Memory Integration (list/read/write_memory) - Document auto-activation triggers Agents/pm-agent.md updates: - Add Session Start Protocol (MANDATORY auto-activation) - Add During Work PDCA Cycle with example workflows - Add Session End Protocol with state preservation - Add PDCA Self-Evaluation Pattern - Add Documentation Strategy (temp → patterns/mistakes) - Add Memory Operations Reference Key Features: - Session start auto-activation for context restoration - 30-minute checkpoint saves during work - Self-evaluation with think_about_* operations - Systematic documentation lifecycle - Knowledge evolution to CLAUDE.md Implementation Status: - ✅ Design complete (Commands/pm.md, Agents/pm-agent.md) - ⏳ Implementation pending (Core components) - ⏳ Serena MCP integration pending Salvaged from mistaken development in ~/.claude directory Related: #pm-agent-mode #session-lifecycle #pdca-cycle #phase-2 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: disable Serena MCP auto-browser launch Disable web dashboard and GUI log window auto-launch in Serena MCP server to prevent intrusive browser popups on startup. Users can still manually access the dashboard at http://localhost:24282/dashboard/ if needed. Changes: - Add CLI flags to Serena run command: - --enable-web-dashboard false - --enable-gui-log-window false - Ensures Git-tracked configuration (no reliance on ~/.serena/serena_config.yml) - Aligns with AIRIS MCP Gateway integration approach 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: rename directories to lowercase for PEP8 compliance - Rename superclaude/Agents -> superclaude/agents - Rename superclaude/Commands -> superclaude/commands - Rename superclaude/Core -> superclaude/core - Rename superclaude/Examples -> superclaude/examples - Rename superclaude/MCP -> superclaude/mcp - Rename superclaude/Modes -> superclaude/modes This change follows Python PEP8 naming conventions for package directories. * style: fix PEP8 violations and update package name to lowercase Changes: - Format all Python files with black (43 files reformatted) - Update package name from 'SuperClaude' to 'superclaude' in pyproject.toml - Fix import statements to use lowercase package name - Add missing imports (timedelta, __version__) - Remove old SuperClaude.egg-info directory PEP8 violations reduced from 2672 to 701 (mostly E501 line length due to black's 88 char vs flake8's 79 char limit). * docs: add PM Agent development documentation Add comprehensive PM Agent development documentation: - PM Agent ideal workflow (7-phase autonomous cycle) - Project structure understanding (Git vs installed environment) - Installation flow understanding (CommandsComponent behavior) - Task management system (current-tasks.md) Purpose: Eliminate repeated explanations and enable autonomous PDCA cycles 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * feat(pm-agent): add self-correcting execution and warning investigation culture ## Changes ### superclaude/commands/pm.md - Add "Self-Correcting Execution" section with root cause analysis protocol - Add "Warning/Error Investigation Culture" section enforcing zero-tolerance for dismissal - Define error detection protocol: STOP → Investigate → Hypothesis → Different Solution → Execute - Document anti-patterns (retry without understanding) and correct patterns (research-first) ### docs/Development/hypothesis-pm-autonomous-enhancement-2025-10-14.md - Add PDCA workflow hypothesis document for PM Agent autonomous enhancement ## Rationale PM Agent must never retry failed operations without understanding root causes. All warnings and errors require investigation via context7/WebFetch/documentation to ensure production-quality code and prevent technical debt accumulation. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * feat(installer): add airis-mcp-gateway MCP server option ## Changes - Add airis-mcp-gateway to MCP server options in installer - Configuration: GitHub-based installation via uvx - Repository: https://github.com/oraios/airis-mcp-gateway - Purpose: Dynamic MCP Gateway for zero-token baseline and on-demand tool loading ## Implementation Added to setup/components/mcp.py self.mcp_servers dictionary with: - install_method: github - install_command: uvx test installation - run_command: uvx runtime execution - required: False (optional server) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: kazuki <kazuki@kazukinoMacBook-Air.local> Co-authored-by: Claude <noreply@anthropic.com>
This commit is contained in:
kazuki nakai
@@ -3,23 +3,26 @@ from unittest.mock import patch, MagicMock
|
||||
import argparse
|
||||
from setup.cli.commands.install import get_components_to_install
|
||||
|
||||
|
||||
class TestGetComponents:
|
||||
@patch('setup.cli.commands.install.select_mcp_servers')
|
||||
@patch("setup.cli.commands.install.select_mcp_servers")
|
||||
def test_get_components_to_install_interactive_mcp(self, mock_select_mcp):
|
||||
# Arrange
|
||||
mock_registry = MagicMock()
|
||||
mock_config_manager = MagicMock()
|
||||
mock_config_manager._installation_context = {}
|
||||
mock_select_mcp.return_value = ['magic']
|
||||
mock_select_mcp.return_value = ["magic"]
|
||||
|
||||
args = argparse.Namespace(components=['mcp'])
|
||||
args = argparse.Namespace(components=["mcp"])
|
||||
|
||||
# Act
|
||||
components = get_components_to_install(args, mock_registry, mock_config_manager)
|
||||
|
||||
# Assert
|
||||
mock_select_mcp.assert_called_once()
|
||||
assert 'mcp' in components
|
||||
assert 'mcp_docs' in components # Should be added automatically
|
||||
assert hasattr(mock_config_manager, '_installation_context')
|
||||
assert mock_config_manager._installation_context['selected_mcp_servers'] == ['magic']
|
||||
assert "mcp" in components
|
||||
assert "mcp_docs" in components # Should be added automatically
|
||||
assert hasattr(mock_config_manager, "_installation_context")
|
||||
assert mock_config_manager._installation_context["selected_mcp_servers"] == [
|
||||
"magic"
|
||||
]
|
||||
|
||||
@@ -4,34 +4,43 @@ from unittest.mock import patch, MagicMock, ANY
|
||||
import argparse
|
||||
from setup.cli.commands import install
|
||||
|
||||
|
||||
class TestInstallCommand:
|
||||
@patch('setup.cli.commands.install.get_components_to_install')
|
||||
@patch('setup.cli.commands.install.ComponentRegistry')
|
||||
@patch('setup.cli.commands.install.ConfigService')
|
||||
@patch('setup.cli.commands.install.Validator')
|
||||
@patch('setup.cli.commands.install.display_installation_plan')
|
||||
@patch('setup.cli.commands.install.perform_installation')
|
||||
@patch('setup.cli.commands.install.confirm', return_value=True)
|
||||
@patch('setup.cli.commands.install.validate_system_requirements', return_value=True)
|
||||
@patch('pathlib.Path.home')
|
||||
@patch("setup.cli.commands.install.get_components_to_install")
|
||||
@patch("setup.cli.commands.install.ComponentRegistry")
|
||||
@patch("setup.cli.commands.install.ConfigService")
|
||||
@patch("setup.cli.commands.install.Validator")
|
||||
@patch("setup.cli.commands.install.display_installation_plan")
|
||||
@patch("setup.cli.commands.install.perform_installation")
|
||||
@patch("setup.cli.commands.install.confirm", return_value=True)
|
||||
@patch("setup.cli.commands.install.validate_system_requirements", return_value=True)
|
||||
@patch("pathlib.Path.home")
|
||||
def test_run_resolves_dependencies_before_planning(
|
||||
self, mock_home, mock_validate_reqs, mock_confirm, mock_perform,
|
||||
mock_display, mock_validator, mock_config, mock_registry_class,
|
||||
mock_get_components, tmp_path
|
||||
self,
|
||||
mock_home,
|
||||
mock_validate_reqs,
|
||||
mock_confirm,
|
||||
mock_perform,
|
||||
mock_display,
|
||||
mock_validator,
|
||||
mock_config,
|
||||
mock_registry_class,
|
||||
mock_get_components,
|
||||
tmp_path,
|
||||
):
|
||||
# Arrange
|
||||
mock_home.return_value = tmp_path
|
||||
install_dir = tmp_path / ".claude"
|
||||
|
||||
mock_args = argparse.Namespace(
|
||||
components=['mcp'],
|
||||
components=["mcp"],
|
||||
install_dir=install_dir,
|
||||
quiet=True, # to avoid calling display_header
|
||||
quiet=True, # to avoid calling display_header
|
||||
yes=True,
|
||||
force=False,
|
||||
dry_run=False,
|
||||
diagnose=False,
|
||||
list_components=False
|
||||
list_components=False,
|
||||
)
|
||||
|
||||
mock_registry_instance = MagicMock()
|
||||
@@ -41,18 +50,18 @@ class TestInstallCommand:
|
||||
mock_config.return_value = mock_config_instance
|
||||
mock_config_instance.validate_config_files.return_value = []
|
||||
|
||||
mock_get_components.return_value = ['mcp']
|
||||
mock_registry_instance.resolve_dependencies.return_value = ['core', 'mcp']
|
||||
mock_get_components.return_value = ["mcp"]
|
||||
mock_registry_instance.resolve_dependencies.return_value = ["core", "mcp"]
|
||||
|
||||
# Act
|
||||
install.run(mock_args)
|
||||
|
||||
# Assert
|
||||
# Check that resolve_dependencies was called with the initial list
|
||||
mock_registry_instance.resolve_dependencies.assert_called_once_with(['mcp'])
|
||||
mock_registry_instance.resolve_dependencies.assert_called_once_with(["mcp"])
|
||||
|
||||
# Check that display_installation_plan was not called because of quiet=True
|
||||
mock_display.assert_not_called()
|
||||
|
||||
# Check that perform_installation was called with the resolved list
|
||||
mock_perform.assert_called_once_with(['core', 'mcp'], mock_args, ANY)
|
||||
mock_perform.assert_called_once_with(["core", "mcp"], mock_args, ANY)
|
||||
|
||||
@@ -6,6 +6,7 @@ import tempfile
|
||||
from unittest.mock import MagicMock
|
||||
from setup.core.installer import Installer
|
||||
|
||||
|
||||
class TestInstaller:
|
||||
def test_create_backup_empty_dir(self):
|
||||
with tempfile.TemporaryDirectory() as temp_dir_str:
|
||||
@@ -33,7 +34,7 @@ class TestInstaller:
|
||||
def test_skips_already_installed_component(self):
|
||||
# Create a mock component that is NOT reinstallable
|
||||
mock_component = MagicMock()
|
||||
mock_component.get_metadata.return_value = {'name': 'test_component'}
|
||||
mock_component.get_metadata.return_value = {"name": "test_component"}
|
||||
mock_component.is_reinstallable.return_value = False
|
||||
mock_component.install.return_value = True
|
||||
mock_component.validate_prerequisites.return_value = (True, [])
|
||||
@@ -42,18 +43,18 @@ class TestInstaller:
|
||||
installer.register_component(mock_component)
|
||||
|
||||
# Simulate component is already installed
|
||||
installer.installed_components = {'test_component'}
|
||||
installer.installed_components = {"test_component"}
|
||||
|
||||
installer.install_component('test_component', {})
|
||||
installer.install_component("test_component", {})
|
||||
|
||||
# Assert that the install method was NOT called
|
||||
mock_component.install.assert_not_called()
|
||||
assert 'test_component' in installer.skipped_components
|
||||
assert "test_component" in installer.skipped_components
|
||||
|
||||
def test_installs_reinstallable_component(self):
|
||||
# Create a mock component that IS reinstallable
|
||||
mock_component = MagicMock()
|
||||
mock_component.get_metadata.return_value = {'name': 'reinstallable_component'}
|
||||
mock_component.get_metadata.return_value = {"name": "reinstallable_component"}
|
||||
mock_component.is_reinstallable.return_value = True
|
||||
mock_component.install.return_value = True
|
||||
mock_component.validate_prerequisites.return_value = (True, [])
|
||||
@@ -62,30 +63,30 @@ class TestInstaller:
|
||||
installer.register_component(mock_component)
|
||||
|
||||
# Simulate component is already installed
|
||||
installer.installed_components = {'reinstallable_component'}
|
||||
installer.installed_components = {"reinstallable_component"}
|
||||
|
||||
installer.install_component('reinstallable_component', {})
|
||||
installer.install_component("reinstallable_component", {})
|
||||
|
||||
# Assert that the install method WAS called
|
||||
mock_component.install.assert_called_once()
|
||||
assert 'reinstallable_component' not in installer.skipped_components
|
||||
assert "reinstallable_component" not in installer.skipped_components
|
||||
|
||||
def test_post_install_validation_only_validates_updated_components(self):
|
||||
# Arrange
|
||||
installer = Installer()
|
||||
|
||||
mock_comp1 = MagicMock()
|
||||
mock_comp1.get_metadata.return_value = {'name': 'comp1'}
|
||||
mock_comp1.get_metadata.return_value = {"name": "comp1"}
|
||||
mock_comp1.validate_installation.return_value = (True, [])
|
||||
|
||||
mock_comp2 = MagicMock()
|
||||
mock_comp2.get_metadata.return_value = {'name': 'comp2'}
|
||||
mock_comp2.get_metadata.return_value = {"name": "comp2"}
|
||||
mock_comp2.validate_installation.return_value = (True, [])
|
||||
|
||||
installer.register_component(mock_comp1)
|
||||
installer.register_component(mock_comp2)
|
||||
|
||||
installer.updated_components = {'comp1'}
|
||||
installer.updated_components = {"comp1"}
|
||||
|
||||
# Act
|
||||
installer._run_post_install_validation()
|
||||
|
||||
@@ -3,20 +3,24 @@ from pathlib import Path
|
||||
from unittest.mock import MagicMock, patch
|
||||
from setup.components.mcp import MCPComponent
|
||||
|
||||
|
||||
class TestMCPComponent:
|
||||
@patch('setup.components.mcp.MCPComponent._post_install', return_value=True)
|
||||
@patch('setup.components.mcp.MCPComponent.validate_prerequisites', return_value=(True, []))
|
||||
@patch('setup.components.mcp.MCPComponent._install_mcp_server')
|
||||
def test_install_selected_servers_only(self, mock_install_mcp_server, mock_validate_prereqs, mock_post_install):
|
||||
@patch("setup.components.mcp.MCPComponent._post_install", return_value=True)
|
||||
@patch(
|
||||
"setup.components.mcp.MCPComponent.validate_prerequisites",
|
||||
return_value=(True, []),
|
||||
)
|
||||
@patch("setup.components.mcp.MCPComponent._install_mcp_server")
|
||||
def test_install_selected_servers_only(
|
||||
self, mock_install_mcp_server, mock_validate_prereqs, mock_post_install
|
||||
):
|
||||
mock_install_mcp_server.return_value = True
|
||||
|
||||
component = MCPComponent(install_dir=Path('/fake/dir'))
|
||||
component = MCPComponent(install_dir=Path("/fake/dir"))
|
||||
component.installed_servers_in_session = []
|
||||
|
||||
# Simulate selecting only the 'magic' server
|
||||
config = {
|
||||
"selected_mcp_servers": ["magic"]
|
||||
}
|
||||
config = {"selected_mcp_servers": ["magic"]}
|
||||
|
||||
success = component._install(config)
|
||||
|
||||
@@ -30,18 +34,23 @@ class TestMCPComponent:
|
||||
called_args, _ = mock_install_mcp_server.call_args
|
||||
server_info_arg = called_args[0]
|
||||
|
||||
assert server_info_arg['name'] == 'magic'
|
||||
assert server_info_arg['npm_package'] == '@21st-dev/magic'
|
||||
assert server_info_arg["name"] == "magic"
|
||||
assert server_info_arg["npm_package"] == "@21st-dev/magic"
|
||||
|
||||
@patch('subprocess.run')
|
||||
@patch("subprocess.run")
|
||||
def test_validate_installation_success(self, mock_subprocess_run):
|
||||
component = MCPComponent(install_dir=Path('/fake/dir'))
|
||||
component = MCPComponent(install_dir=Path("/fake/dir"))
|
||||
|
||||
# Mock settings manager
|
||||
component.settings_manager = MagicMock()
|
||||
component.settings_manager.is_component_installed.return_value = True
|
||||
component.settings_manager.get_component_version.return_value = component.get_metadata()['version']
|
||||
component.settings_manager.get_metadata_setting.return_value = ['magic', 'playwright']
|
||||
component.settings_manager.get_component_version.return_value = (
|
||||
component.get_metadata()["version"]
|
||||
)
|
||||
component.settings_manager.get_metadata_setting.return_value = [
|
||||
"magic",
|
||||
"playwright",
|
||||
]
|
||||
|
||||
# Mock `claude mcp list` output
|
||||
mock_subprocess_run.return_value.returncode = 0
|
||||
@@ -52,15 +61,20 @@ class TestMCPComponent:
|
||||
assert success is True
|
||||
assert not errors
|
||||
|
||||
@patch('subprocess.run')
|
||||
@patch("subprocess.run")
|
||||
def test_validate_installation_failure(self, mock_subprocess_run):
|
||||
component = MCPComponent(install_dir=Path('/fake/dir'))
|
||||
component = MCPComponent(install_dir=Path("/fake/dir"))
|
||||
|
||||
# Mock settings manager
|
||||
component.settings_manager = MagicMock()
|
||||
component.settings_manager.is_component_installed.return_value = True
|
||||
component.settings_manager.get_component_version.return_value = component.get_metadata()['version']
|
||||
component.settings_manager.get_metadata_setting.return_value = ['magic', 'playwright']
|
||||
component.settings_manager.get_component_version.return_value = (
|
||||
component.get_metadata()["version"]
|
||||
)
|
||||
component.settings_manager.get_metadata_setting.return_value = [
|
||||
"magic",
|
||||
"playwright",
|
||||
]
|
||||
|
||||
# Mock `claude mcp list` output - 'playwright' is missing
|
||||
mock_subprocess_run.return_value.returncode = 0
|
||||
|
||||
@@ -3,31 +3,37 @@ from pathlib import Path
|
||||
from unittest.mock import MagicMock, patch
|
||||
from setup.components.mcp_docs import MCPDocsComponent
|
||||
|
||||
|
||||
class TestMCPDocsComponent:
|
||||
@patch('setup.components.mcp_docs.MCPDocsComponent._post_install', return_value=True)
|
||||
@patch(
|
||||
"setup.components.mcp_docs.MCPDocsComponent._post_install", return_value=True
|
||||
)
|
||||
def test_install_calls_post_install_even_if_no_docs(self, mock_post_install):
|
||||
component = MCPDocsComponent(install_dir=Path('/fake/dir'))
|
||||
component = MCPDocsComponent(install_dir=Path("/fake/dir"))
|
||||
|
||||
# Simulate no servers selected
|
||||
config = {
|
||||
"selected_mcp_servers": []
|
||||
}
|
||||
config = {"selected_mcp_servers": []}
|
||||
|
||||
success = component._install(config)
|
||||
|
||||
assert success is True
|
||||
mock_post_install.assert_called_once()
|
||||
|
||||
@patch('setup.components.mcp_docs.MCPDocsComponent._post_install', return_value=True)
|
||||
@patch('setup.components.mcp_docs.MCPDocsComponent.get_files_to_install', return_value=[])
|
||||
@patch('setup.core.base.Component.validate_prerequisites', return_value=(True, []))
|
||||
def test_install_calls_post_install_if_docs_not_found(self, mock_validate_prereqs, mock_get_files, mock_post_install):
|
||||
component = MCPDocsComponent(install_dir=Path('/tmp/fake_dir'))
|
||||
@patch(
|
||||
"setup.components.mcp_docs.MCPDocsComponent._post_install", return_value=True
|
||||
)
|
||||
@patch(
|
||||
"setup.components.mcp_docs.MCPDocsComponent.get_files_to_install",
|
||||
return_value=[],
|
||||
)
|
||||
@patch("setup.core.base.Component.validate_prerequisites", return_value=(True, []))
|
||||
def test_install_calls_post_install_if_docs_not_found(
|
||||
self, mock_validate_prereqs, mock_get_files, mock_post_install
|
||||
):
|
||||
component = MCPDocsComponent(install_dir=Path("/tmp/fake_dir"))
|
||||
|
||||
# Simulate a server was selected, but the doc file doesn't exist
|
||||
config = {
|
||||
"selected_mcp_servers": ["some_server_with_no_doc_file"]
|
||||
}
|
||||
config = {"selected_mcp_servers": ["some_server_with_no_doc_file"]}
|
||||
|
||||
success = component._install(config)
|
||||
|
||||
|
||||
@@ -5,11 +5,13 @@ import io
|
||||
|
||||
from setup.utils.ui import display_authors
|
||||
|
||||
@patch('sys.stdout', new_callable=io.StringIO)
|
||||
|
||||
@patch("sys.stdout", new_callable=io.StringIO)
|
||||
def test_display_header_with_authors(mock_stdout):
|
||||
# Mock the author and email info from SuperClaude/__init__.py
|
||||
with patch('SuperClaude.__author__', "Author One, Author Two"), \
|
||||
patch('SuperClaude.__email__', "one@example.com, two@example.com"):
|
||||
# Mock the author and email info from superclaude/__init__.py
|
||||
with patch("superclaude.__author__", "Author One, Author Two"), patch(
|
||||
"superclaude.__email__", "one@example.com, two@example.com"
|
||||
):
|
||||
|
||||
display_header("Test Title", "Test Subtitle")
|
||||
|
||||
@@ -21,12 +23,13 @@ def test_display_header_with_authors(mock_stdout):
|
||||
assert "Author Two <two@example.com>" in output
|
||||
assert "Author One <one@example.com> | Author Two <two@example.com>" in output
|
||||
|
||||
@patch('sys.stdout', new_callable=io.StringIO)
|
||||
|
||||
@patch("sys.stdout", new_callable=io.StringIO)
|
||||
def test_display_authors(mock_stdout):
|
||||
# Mock the author, email, and github info from SuperClaude/__init__.py
|
||||
with patch('SuperClaude.__author__', "Author One, Author Two"), \
|
||||
patch('SuperClaude.__email__', "one@example.com, two@example.com"), \
|
||||
patch('SuperClaude.__github__', "user1, user2"):
|
||||
# Mock the author, email, and github info from superclaude/__init__.py
|
||||
with patch("superclaude.__author__", "Author One, Author Two"), patch(
|
||||
"superclaude.__email__", "one@example.com, two@example.com"
|
||||
), patch("superclaude.__github__", "user1, user2"):
|
||||
|
||||
display_authors()
|
||||
|
||||
|
||||
Reference in New Issue
Block a user