SuperClaude/docs/Development/pm-agent-improvements.md

150 lines
5.6 KiB
Markdown
Raw Normal View History

refactor: PM Agent complete independence from external MCP servers (#439) * refactor: PM Agent complete independence from external MCP servers ## Summary Implement graceful degradation to ensure PM Agent operates fully without any MCP server dependencies. MCP servers now serve as optional enhancements rather than required components. ## Changes ### Responsibility Separation (NEW) - **PM Agent**: Development workflow orchestration (PDCA cycle, task management) - **mindbase**: Memory management (long-term, freshness, error learning) - **Built-in memory**: Session-internal context (volatile) ### 3-Layer Memory Architecture with Fallbacks 1. **Built-in Memory** [OPTIONAL]: Session context via MCP memory server 2. **mindbase** [OPTIONAL]: Long-term semantic search via airis-mcp-gateway 3. **Local Files** [ALWAYS]: Core functionality in docs/memory/ ### Graceful Degradation Implementation - All MCP operations marked with [ALWAYS] or [OPTIONAL] - Explicit IF/ELSE fallback logic for every MCP call - Dual storage: Always write to local files + optionally to mindbase - Smart lookup: Semantic search (if available) → Text search (always works) ### Key Fallback Strategies **Session Start**: - mindbase available: search_conversations() for semantic context - mindbase unavailable: Grep docs/memory/*.jsonl for text-based lookup **Error Detection**: - mindbase available: Semantic search for similar past errors - mindbase unavailable: Grep docs/mistakes/ + solutions_learned.jsonl **Knowledge Capture**: - Always: echo >> docs/memory/patterns_learned.jsonl (persistent) - Optional: mindbase.store() for semantic search enhancement ## Benefits - ✅ Zero external dependencies (100% functionality without MCP) - ✅ Enhanced capabilities when MCPs available (semantic search, freshness) - ✅ No functionality loss, only reduced search intelligence - ✅ Transparent degradation (no error messages, automatic fallback) ## Related Research - Serena MCP investigation: Exposes tools (not resources), memory = markdown files - mindbase superiority: PostgreSQL + pgvector > Serena memory features - Best practices alignment: /Users/kazuki/github/airis-mcp-gateway/docs/mcp-best-practices.md 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore: add PR template and pre-commit config - Add structured PR template with Git workflow checklist - Add pre-commit hooks for secret detection and Conventional Commits - Enforce code quality gates (YAML/JSON/Markdown lint, shellcheck) NOTE: Execute pre-commit inside Docker container to avoid host pollution: docker compose exec workspace uv tool install pre-commit docker compose exec workspace pre-commit run --all-files 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * docs: update PM Agent context with token efficiency architecture - Add Layer 0 Bootstrap (150 tokens, 95% reduction) - Document Intent Classification System (5 complexity levels) - Add Progressive Loading strategy (5-layer) - Document mindbase integration incentive (38% savings) - Update with 2025-10-17 redesign details * refactor: PM Agent command with progressive loading - Replace auto-loading with User Request First philosophy - Add 5-layer progressive context loading - Implement intent classification system - Add workflow metrics collection (.jsonl) - Document graceful degradation strategy * fix: installer improvements Update installer logic for better reliability * docs: add comprehensive development documentation - Add architecture overview - Add PM Agent improvements analysis - Add parallel execution architecture - Add CLI install improvements - Add code style guide - Add project overview - Add install process analysis * docs: add research documentation Add LLM agent token efficiency research and analysis * docs: add suggested commands reference * docs: add session logs and testing documentation - Add session analysis logs - Add testing documentation * feat: migrate CLI to typer + rich for modern UX ## What Changed ### New CLI Architecture (typer + rich) - Created `superclaude/cli/` module with modern typer-based CLI - Replaced custom UI utilities with rich native features - Added type-safe command structure with automatic validation ### Commands Implemented - **install**: Interactive installation with rich UI (progress, panels) - **doctor**: System diagnostics with rich table output - **config**: API key management with format validation ### Technical Improvements - Dependencies: Added typer>=0.9.0, rich>=13.0.0, click>=8.0.0 - Entry Point: Updated pyproject.toml to use `superclaude.cli.app:cli_main` - Tests: Added comprehensive smoke tests (11 passed) ### User Experience Enhancements - Rich formatted help messages with panels and tables - Automatic input validation with retry loops - Clear error messages with actionable suggestions - Non-interactive mode support for CI/CD ## Testing ```bash uv run superclaude --help # ✓ Works uv run superclaude doctor # ✓ Rich table output uv run superclaude config show # ✓ API key management pytest tests/test_cli_smoke.py # ✓ 11 passed, 1 skipped ``` ## Migration Path - ✅ P0: Foundation complete (typer + rich + smoke tests) - 🔜 P1: Pydantic validation models (next sprint) - 🔜 P2: Enhanced error messages (next sprint) - 🔜 P3: API key retry loops (next sprint) ## Performance Impact - **Code Reduction**: Prepared for -300 lines (custom UI → rich) - **Type Safety**: Automatic validation from type hints - **Maintainability**: Framework primitives vs custom code 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: consolidate documentation directories Merged claudedocs/ into docs/research/ for consistent documentation structure. Changes: - Moved all claudedocs/*.md files to docs/research/ - Updated all path references in documentation (EN/KR) - Updated RULES.md and research.md command templates - Removed claudedocs/ directory - Removed ClaudeDocs/ from .gitignore Benefits: - Single source of truth for all research reports - PEP8-compliant lowercase directory naming - Clearer documentation organization - Prevents future claudedocs/ directory creation 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * perf: reduce /sc:pm command output from 1652 to 15 lines - Remove 1637 lines of documentation from command file - Keep only minimal bootstrap message - 99% token reduction on command execution - Detailed specs remain in superclaude/agents/pm-agent.md 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * perf: split PM Agent into execution workflows and guide - Reduce pm-agent.md from 735 to 429 lines (42% reduction) - Move philosophy/examples to docs/agents/pm-agent-guide.md - Execution workflows (PDCA, file ops) stay in pm-agent.md - Guide (examples, quality standards) read once when needed Token savings: - Agent loading: ~6K → ~3.5K tokens (42% reduction) - Total with pm.md: 71% overall reduction 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: consolidate PM Agent optimization and pending changes PM Agent optimization (already committed separately): - superclaude/commands/pm.md: 1652→14 lines - superclaude/agents/pm-agent.md: 735→429 lines - docs/agents/pm-agent-guide.md: new guide file Other pending changes: - setup: framework_docs, mcp, logger, remove ui.py - superclaude: __main__, cli/app, cli/commands/install - tests: test_ui updates - scripts: workflow metrics analysis tools - docs/memory: session state updates 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: simplify MCP installer to unified gateway with legacy mode ## Changes ### MCP Component (setup/components/mcp.py) - Simplified to single airis-mcp-gateway by default - Added legacy mode for individual official servers (sequential-thinking, context7, magic, playwright) - Dynamic prerequisites based on mode: - Default: uv + claude CLI only - Legacy: node (18+) + npm + claude CLI - Removed redundant server definitions ### CLI Integration - Added --legacy flag to setup/cli/commands/install.py - Added --legacy flag to superclaude/cli/commands/install.py - Config passes legacy_mode to component installer ## Benefits - ✅ Simpler: 1 gateway vs 9+ individual servers - ✅ Lighter: No Node.js/npm required (default mode) - ✅ Unified: All tools in one gateway (sequential-thinking, context7, magic, playwright, serena, morphllm, tavily, chrome-devtools, git, puppeteer) - ✅ Flexible: --legacy flag for official servers if needed ## Usage ```bash superclaude install # Default: airis-mcp-gateway (推奨) superclaude install --legacy # Legacy: individual official servers ``` 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: rename CoreComponent to FrameworkDocsComponent and add PM token tracking ## Changes ### Component Renaming (setup/components/) - Renamed CoreComponent → FrameworkDocsComponent for clarity - Updated all imports in __init__.py, agents.py, commands.py, mcp_docs.py, modes.py - Better reflects the actual purpose (framework documentation files) ### PM Agent Enhancement (superclaude/commands/pm.md) - Added token usage tracking instructions - PM Agent now reports: 1. Current token usage from system warnings 2. Percentage used (e.g., "27% used" for 54K/200K) 3. Status zone: 🟢 <75% | 🟡 75-85% | 🔴 >85% - Helps prevent token exhaustion during long sessions ### UI Utilities (setup/utils/ui.py) - Added new UI utility module for installer - Provides consistent user interface components ## Benefits - ✅ Clearer component naming (FrameworkDocs vs Core) - ✅ PM Agent token awareness for efficiency - ✅ Better visual feedback with status zones 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor(pm-agent): minimize output verbosity (471→284 lines, 40% reduction) **Problem**: PM Agent generated excessive output with redundant explanations - "System Status Report" with decorative formatting - Repeated "Common Tasks" lists user already knows - Verbose session start/end protocols - Duplicate file operations documentation **Solution**: Compress without losing functionality - Session Start: Reduced to symbol-only status (🟢 branch | nM nD | token%) - Session End: Compressed to essential actions only - File Operations: Consolidated from 2 sections to 1 line reference - Self-Improvement: 5 phases → 1 unified workflow - Output Rules: Explicit constraints to prevent Claude over-explanation **Quality Preservation**: - ✅ All core functions retained (PDCA, memory, patterns, mistakes) - ✅ PARALLEL Read/Write preserved (performance critical) - ✅ Workflow unchanged (session lifecycle intact) - ✅ Added output constraints (prevents verbose generation) **Reduction Method**: - Deleted: Explanatory text, examples, redundant sections - Retained: Action definitions, file paths, core workflows - Added: Explicit output constraints to enforce minimalism **Token Impact**: 40% reduction in agent documentation size **Before**: Verbose multi-section report with task lists **After**: Single line status: 🟢 integration | 15M 17D | 36% 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * refactor: consolidate MCP integration to unified gateway **Changes**: - Remove individual MCP server docs (superclaude/mcp/*.md) - Remove MCP server configs (superclaude/mcp/configs/*.json) - Delete MCP docs component (setup/components/mcp_docs.py) - Simplify installer (setup/core/installer.py) - Update components for unified gateway approach **Rationale**: - Unified gateway (airis-mcp-gateway) provides all MCP servers - Individual docs/configs no longer needed (managed centrally) - Reduces maintenance burden and file count - Simplifies installation process **Files Removed**: 17 MCP files (docs + configs) **Installer Changes**: Removed legacy MCP installation logic 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore: update version and component metadata - Bump version (pyproject.toml, setup/__init__.py) - Update CLAUDE.md import service references - Reflect component structure changes 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> --------- Co-authored-by: kazuki <kazuki@kazukinoMacBook-Air.local> Co-authored-by: Claude <noreply@anthropic.com>
2025-10-17 09:13:06 +09:00
# PM Agent Improvement Implementation - 2025-10-14
## Implemented Improvements
### 1. Self-Correcting Execution (Root Cause First) ✅
**Core Change**: Never retry the same approach without understanding WHY it failed.
**Implementation**:
- 6-step error detection protocol
- Mandatory root cause investigation (context7, WebFetch, Grep, Read)
- Hypothesis formation before solution attempt
- Solution must be DIFFERENT from previous attempts
- Learning capture for future reference
**Anti-Patterns Explicitly Forbidden**:
- ❌ "エラーが出た。もう一回やってみよう"
- ❌ Retry 1, 2, 3 times with same approach
- ❌ "Warningあるけど動くからOK"
**Correct Patterns Enforced**:
- ✅ Error → Investigate official docs
- ✅ Understand root cause → Design different solution
- ✅ Document learning → Prevent future recurrence
### 2. Warning/Error Investigation Culture ✅
**Core Principle**: 全ての警告・エラーに興味を持って調査する
**Implementation**:
- Zero tolerance for dismissal
- Mandatory investigation protocol (context7 + WebFetch)
- Impact categorization (Critical/Important/Informational)
- Documentation requirement for all decisions
**Quality Mindset**:
- Warnings = Future technical debt
- "Works now" ≠ "Production ready"
- Thorough investigation = Higher code quality
- Every warning is a learning opportunity
### 3. Memory Key Schema (Standardized) ✅
**Pattern**: `[category]/[subcategory]/[identifier]`
**Inspiration**: Kubernetes namespaces, Git refs, Prometheus metrics
**Categories Defined**:
- `session/`: Session lifecycle management
- `plan/`: Planning phase (hypothesis, architecture, rationale)
- `execution/`: Do phase (experiments, errors, solutions)
- `evaluation/`: Check phase (analysis, metrics, lessons)
- `learning/`: Knowledge capture (patterns, solutions, mistakes)
- `project/`: Project understanding (context, architecture, conventions)
**Benefits**:
- Consistent naming across all memory operations
- Easy to query and retrieve related memories
- Clear organization for knowledge management
- Inspired by proven OSS practices
### 4. PDCA Document Structure (Normalized) ✅
**Location**: `docs/pdca/[feature-name]/`
**Structure** (明確・わかりやすい):
```
docs/pdca/[feature-name]/
├── plan.md # Plan: 仮説・設計
├── do.md # Do: 実験・試行錯誤
├── check.md # Check: 評価・分析
└── act.md # Act: 改善・次アクション
```
**Templates Provided**:
- plan.md: Hypothesis, Expected Outcomes, Risks
- do.md: Implementation log (時系列), Learnings
- check.md: Results vs Expectations, What worked/failed
- act.md: Success patterns, Global rule updates, Checklist updates
**Lifecycle**:
1. Start → Create plan.md
2. Work → Update do.md continuously
3. Complete → Create check.md
4. Success → Formalize to docs/patterns/ + create act.md
5. Failure → Move to docs/mistakes/ + create act.md with prevention
## User Feedback Integration
### Key Insights from User:
1. **同じ方法を繰り返すからループする** → Root cause analysis mandatory
2. **警告を興味を持って調べる癖** → Zero tolerance culture implemented
3. **スキーマ未定義なら定義すべき** → Kubernetes-inspired schema added
4. **plan/do/check/actでわかりやすい** → PDCA structure normalized
5. **OSS参考にアイデアをパクる** → Kubernetes, Git, Prometheus patterns adopted
### Philosophy Embedded:
- "間違いを理解してから再試行" (Understand before retry)
- "警告 = 将来の技術的負債" (Warnings = Future debt)
- "コード品質向上 = 徹底調査文化" (Quality = Investigation culture)
- "アイデアに著作権なし" (Ideas are free to adopt)
## Expected Impact
### Code Quality:
- ✅ Fewer repeated errors (root cause analysis)
- ✅ Proactive technical debt prevention (warning investigation)
- ✅ Higher test coverage and security compliance
- ✅ Consistent documentation and knowledge capture
### Developer Experience:
- ✅ Clear PDCA structure (plan/do/check/act)
- ✅ Standardized memory keys (easy to use)
- ✅ Learning captured systematically
- ✅ Patterns reusable across projects
### Long-term Benefits:
- ✅ Continuous improvement culture
- ✅ Knowledge accumulation over sessions
- ✅ Reduced time on repeated mistakes
- ✅ Higher quality autonomous execution
## Next Steps
1. **Test in Real Usage**: Apply PM Agent to actual feature implementation
2. **Validate Improvements**: Measure error recovery cycles, warning handling
3. **Iterate Based on Results**: Refine based on real-world performance
4. **Document Success Cases**: Build example library of PDCA cycles
5. **Upstream Contribution**: After validation, contribute to SuperClaude
## Files Modified
- `superclaude/commands/pm.md`:
- Added "Self-Correcting Execution (Root Cause First)" section
- Added "Warning/Error Investigation Culture" section
- Added "Memory Key Schema (Standardized)" section
- Added "PDCA Document Structure (Normalized)" section
- ~260 lines of detailed implementation guidance
## Implementation Quality
- ✅ User feedback directly incorporated
- ✅ Real-world practices from Kubernetes, Git, Prometheus
- ✅ Clear anti-patterns and correct patterns defined
- ✅ Concrete examples and templates provided
- ✅ Japanese and English mixed (user preference respected)
- ✅ Philosophical principles embedded in implementation
This improvement represents a fundamental shift from "retry on error" to "understand then solve" approach, which should dramatically improve PM Agent's code quality and learning capabilities.